summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* MDEV-16101: ADD PARTITION on table partitioned by list does not work with ↵bb-10.3-MDEV-16101Jacob Mathew2018-05-143-1/+254
| | | | | | | | | | | | | | | more than 32 list values. This problem occured because the reorganization of the list of values when the number of elements exceeds 32 was not handled correctly. I have fixed the problem by fixing the way that the list values are reorganized when the number of list values exceeds 32. Author: Jacob Mathew. Reviewer: Alexey Botchkov.
* Moving a few static functions in sql_lex.cc to new methods in Lex_input_streamAlexander Barkov2018-05-094-284/+302
| | | | | | | | | | | | | | | | | | | | | | | | | | | Reasoning: - Shorter and clearer code - Better encapsulation (a fair number of Lex_input_stream methods and members were moved to the private section) New methods: int lex_token(union YYSTYPE *yylval, THD *thd); bool consume_comment(int remaining_recursions_permitted); int lex_one_token(union YYSTYPE *yylval, THD *thd); int find_keyword(Lex_ident_cli_st *str, uint len, bool function); LEX_CSTRING get_token(uint skip, uint length); Additional changes: - Removing Lex_input_stream::yylval. In the original code it was just an alias for the "yylval" passed to lex_one_token(). This coding style is bug prone and is hard to follow. In the new reduction "yylval" (or its components) is passed to the affected methods as a parameter. - Moving the code in sql_lex.h up and down between "private" and "public" sections (sorry if this made the diff somewhat harder to read)
* Fixing tabs to spaces in sql_lex.cc and sql_lex.h (and coding style slightly)Alexander Barkov2018-05-082-184/+184
|
* Merge 10.2 into 10.3Marko Mäkelä2018-05-085-2/+89
|\
| * MDEV-16106 Record in index was not found on rollback, trying to insert: TUPLEThirunarayanan Balathandayuthapani2018-05-083-8/+27
| | | | | | | | | | During rollback of temporary table logs, secondary index should delete mark the index entry instead of removing it completely.
| * Added the test case from MDEV-16086 tfixed by the patch for MDEV-15575Igor Babaev2018-05-072-0/+64
| |
* | Remove a "register" keyword from C++ codeMarko Mäkelä2018-05-081-1/+1
| | | | | | | | | | The register keyword has no effect in C++, and it has been deprecated in newer versions of the standard.
* | Added test case for MDEV-13029Monty2018-05-083-0/+23
| | | | | | | | | | | | | | | | MDEV 13029 Assertion `ds_control' failed in debug_sync upon closing connection after creating temporary sequence This test doesn't fail anymore. Adding it to ensure that the bug doesn't appear again.
* | Added test case for MDEV-13007 ALTER .. ENGINE on temporary sequence may go ↵Monty2018-05-072-0/+42
| | | | | | | | | | | | | | wrong Looks like the bug was fixed some time ago (at least I can't repeat it). I added the test case just have this case tested properly.
* | mysys: disable "optimized" memcpy from 18 years agoDaniel Black2018-05-071-21/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | MDEV-15843 mysys: remove optimized memcpy from 18 years ago While this code has remained dormant for 18 years, libc implementers have used assembly features to gain improvements using achitecture features optimized and by the buffer length like: * https://svnweb.freebsd.org/base/head/lib/libc/amd64/string/memcmp.S * https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/aarch64/memcmp.S * https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/powerpc/powerpc64/memcpy.S From an sysbench-1.0.6 oltp_read_only test on binary charset table: x86_64: was ptr_compare_0: perf report -g --no-children: + 3.37% mysqld mysqld [.] hp_rec_hashnr + 3.15% mysqld libc-2.26.so [.] __memmove_avx_unaligned_erms + 2.73% mysqld mysqld [.] row_search_mvcc + 1.97% mysqld mysqld [.] rec_get_offsets_func + 1.24% mysqld mysqld [.] ptr_compare_0 + 1.14% mysqld mysqld [.] my_qsort2 After: __memcmp_avx2_movbe + 3.42% mysqld mysqld [.] hp_rec_hashnr + 2.96% mysqld libc-2.26.so [.] __memmove_avx_unaligned_erms + 2.91% mysqld mysqld [.] row_search_mvcc + 2.13% mysqld mysqld [.] rec_get_offsets_func + 1.18% mysqld libc-2.26.so [.] __memcmp_avx2_movbe + 1.04% mysqld mysqld [.] evaluate_join_record + 1.02% mysqld mysqld [.] my_qsort2 Power9: Before: ptr_compare_0 + 4.24% mysqld mysqld [.] _Z15row_search_mvccPh15page_cur_mode_tP14row_prebuilt_tmm + 2.18% mysqld mysqld [.] hp_rec_hashnr + 2.07% mysqld mysqld [.] _Z20rec_get_offsets_funcPKhPK12dict_index_tPmbmPP16mem_block_info_t + 1.60% mysqld mysqld [.] _ZL20evaluate_join_recordP4JOINP13st_join_tablei + 1.20% mysqld mysqld [.] _ZN11ha_innobase13general_fetchEPhjj + 1.05% mysqld mysqld [.] _ZN17Item_func_between15val_int_cmp_intEv + 0.92% mysqld mysqld [.] _Z40row_sel_field_store_in_mysql_format_funcPhPK17mysql_row_templ_tPKhm + 0.91% mysqld mysqld [.] _ZNK10Item_param6PValue7val_intEPK19Type_std_attributes + 0.84% mysqld mysqld [.] ptr_compare_0 After: __memcmp_power8 + 2.29% mysqld mysqld [.] _Z15row_search_mvccPh15page_cur_mode_tP14row_prebuilt_tmm + 1.32% mysqld mysqld [.] hp_rec_hashnr + 1.18% swapper [kernel.kallsyms] [k] power_enter_stop + 1.12% mysqld mysqld [.] _Z20rec_get_offsets_funcPKhPK12dict_index_tPmbmPP16mem_block_info_t + 0.87% mysqld mysqld [.] _ZL20evaluate_join_recordP4JOINP13st_join_tablei + 0.87% mysqld [kernel.kallsyms] [k] ___bpf_prog_run + 0.76% mysqld libc-2.26.so [.] __memcmp_power8 + 0.68% mysqld mysqld [.] _ZN11ha_innobase13general_fetchEPhjj + 0.58% mysqld mysqld [.] _ZN17Item_func_between15val_int_cmp_intEv
* | Merge 10.2 into 10.3Marko Mäkelä2018-05-0716-85/+115
|\ \ | |/
| * MDEV-14825 Assertion `col->ord_part' in row_build_index_entry_low upon ↵Marko Mäkelä2018-05-0716-85/+115
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ROLLBACK or DELETE with concurrent ALTER on partitioned table If creating a secondary index fails (typically, ADD UNIQUE INDEX fails due to duplicate key), it is possible that concurrently running UPDATE or DELETE will access the index stub and hit the debug assertion. It does not make any sense to keep updating an uncommitted index whose creation has failed. dict_index_t::is_corrupted(): Replaces dict_index_is_corrupted(). Also take online_status into account. Replace some calls to dict_index_is_clust() with calls to dict_index_t::is_primary().
* | sp_cache_package_routine: fix compile warningDaniel Black2018-05-071-1/+1
| | | | | | | | | | | | | | | | (clang-3.8) sql/sp.cc:2834:53: warning: implicit conversion of NULL constant to 'size_t' (aka 'unsigned long') [-Wnull-conversion] size_t prefix_length= dot ? dot - tmp.str + 1 : NULL; ~~~~~~~~~~~~~ ^~~~ 0
* | MDEV-13134 Introduce ALTER TABLE attributes ALGORITHM=NOCOPY and ↵Thirunarayanan Balathandayuthapani2018-05-0716-117/+0
| | | | | | | | | | | | ALGORITHM=INSTANT Remove the warning for InnoDB rebuilding table to add column FTS_DOC_ID.
* | MDEV-13134 Introduce ALTER TABLE attributes ALGORITHM=NOCOPY and ↵Thirunarayanan Balathandayuthapani2018-05-0744-342/+1337
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ALGORITHM=INSTANT Introduced new alter algorithm type called NOCOPY & INSTANT for inplace alter operation. NOCOPY - Algorithm refuses any alter operation that would rebuild the clustered index. It is a subset of INPLACE algorithm. INSTANT - Algorithm allow any alter operation that would modify only meta data. It is a subset of NOCOPY algorithm. Introduce new variable called alter_algorithm. The values are DEFAULT(0), COPY(1), INPLACE(2), NOCOPY(3), INSTANT(4) Message to deprecate old_alter_table variable and make it alias for alter_algorithm variable. alter_algorithm variable for slave is always set to default.
* | Change read_to_buffer to use ulong instead of uintMichael Widenius2018-05-073-60/+54
| | | | | | | | | | This is mostly to document that read_to_buffer can read more than 65K. Also changed merge_buffers to return bool instead of int
* | Remove mem_alloc_error()Michael Widenius2018-05-078-169/+67
| | | | | | | | | | | | | | | | | | As thd->alloc() and new automatically calls my_error(ER_OUTOFMEORY) there is no reason to call mem_alloc_error() Other things: - Fixed bug in mysql_unpack_partition() where lex.part_info was changed even if it would be a null pointer
* | Optimize performance schema likely/unlikelyMichael Widenius2018-05-0714-401/+486
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Performance schema likely/unlikely assume that performance schema is enabled by default, which causes a performance degradation for default installations that doesn't have performance schema enabled. Fixed by changing the likely/unlikely in PS to assume it's not enabled. This can be changed by compiling with -DPSI_ON_BY_DEFAULT Other changes: - Added psi_likely/psi_unlikely that is depending on PSI_ON_BY_DEFAULT. psi_likely() is assumed to be true if PS is enabled. - Added likely/unlikely to some PS interface code. - Moved pfs_enabled to mysys (was initialized but not used before) - Added "if (pfs_likely(pfs_enabled))" around calls to PS to avoid an extra call if PS is not enabled. - Moved checking flag_global_instrumention before other flags to speed up the case when PS is not enabled.
* | Add checking of correct likely/unlikelyMichael Widenius2018-05-076-12/+212
| | | | | | | | | | | | | | | | | | | | To use: - Compile with -DUSE_MY_LIKELY - Change (with replace) all likely/unlikely to my_likely/my_/unlikely replace likely my_likely unlikely my_unlikely -- *c *h - Start mysqld with -T - run some test - When mysqld has shut down cleanely, report will be on stderr
* | Add likely/unlikely to speed up executionMonty2018-05-07118-4440/+4874
| | | | | | | | | | | | | | | | | | Added to: - if (error) - Lex - sql_yacc.yy and sql_yacc_ora.yy - In header files to alloc() calls - Added thd argument to thd_net_is_killed()
* | MDEV-13024: Server crashes in my_store_ptr upon DELETE from sequence in ↵Oleksandr Byelkin2018-05-062-0/+36
| | | | | | | | | | | | multi-table format It is test only (fix was done by Monty in ha_sequence::open by allocating ref)
* | MDEV-16057: Using optimization Splitting with Group BY we see an unnecessary ↵Varun Gupta2018-05-062-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | attached condition t1.pk IS NOT NULL where pk is a PRIMARY KEY For equalites in the WHERE clause we create a keyuse array that contains the set of all equalities. For each KEYUSE inside the keyuse array we have a field "null_rejecting" which tells that the equality will not hold if either the left or right hand side of the equality is NULL. If the equality is NULL rejecting then we accordingly add a NOT NULL condition for the field present in the item val(present in the KEYUSE struct) when we are doing ref access. For the optimization of splitting with GROUP BY we always set the null_rejecting to TRUE and we are doing ref access on the GROUP by field. This does create a problem when the equality is NOT NULL rejecting. This happens in this case as in the equality we have the right hand side as t1.pk where pk is a PRIMARY KEY , hence it is NOT NULLABLE. So we should have null rejecting set to FALSE for such a case.
* | Fix for MDEV-15812 Assert in SEQUENCE when forcing STATEMEMT formatMonty2018-05-063-1/+24
| | | | | | | | | | The bug was the we copied the lock type to the underlying engine even when external_lock failed.
* | Fixed compiler warnings in spiderMonty2018-05-061-7/+7
| |
* | MDEV-16095 Oracle-style placeholder inside GROUP BY..WITH ROLLUP breaks ↵Alexander Barkov2018-05-065-11/+65
| | | | | | | | replication
* | Merge 10.2 into 10.3Marko Mäkelä2018-05-041-1/+4
|\ \ | |/
| * MDEV-15764 InnoDB may write uninitialized garbage to redo logMarko Mäkelä2018-05-041-1/+6
| | | | | | | | | | | | log_sys_init(), log_buffer_extend(): Add TRASH_ALLOC() instrumentation log_write_up_to(): Correctly calculate the byte offset.
| * MDEV-15698: Spider ignores syntax errors in connection string in COMMENT fieldJacob Mathew2018-05-014-239/+418
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a comma separator is missing between COMMENT fields, Spider ignores the parameter values that are beyond the last expected parameter value. There are also some error messages that Spider does generate on COMMENT fields that are incorrectly formed. I have introduced additional infrastructure in Spider to fix these problems. Author: Jacob Mathew. Reviewer: Kentoku Shiba. Cherry-Picked: Commit c10da98 on branch bb-10.3-MDEV-15698
| * MDEV-15712: If remote server used by Spider table is unavailable, some ↵Jacob Mathew2018-04-303-2/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | operations hang for a long time When an attempt to connect to the remote server fails, Spider retries to connect to the remote server 1000 times or until the connection attempt succeeds. This is perceived as a hang if the remote server remains unavailable. I have introduced changes in Spider's table status handler to fix this problem. Author: Jacob Mathew. Reviewer: Kentoku Shiba. Cherry-Picked: Commit 6ee6933 on branch bb-10.3-MDEV-15712
* | Make a test independent of the build optionsMarko Mäkelä2018-05-042-4/+4
| | | | | | | | | | | | | | | | | | | | | | The number of records in INFORMATION_SCHEMA.COLUMNS depends on the build options, and could easily change when features are added. We are not interested in the number of rows returned. The test was originally added because of problem 15 reported in MDEV-13900 (testing for MDEV-11369 instant ADD COLUMN). The issue was an assertion failure ut_ad(!rec_is_default_row(rec, index)) in lock_clust_rec_cons_read_sees(), because the 'default row' record was not being properly ignored by the b-tree cursor.
* | Follow up for 9a8498066865b5 - adjustments to storage_engine testsElena Stepanova2018-05-037-38/+12
| |
* | MDEV-14019: Spider + binlog_format = ROW => CRASHJacob Mathew2018-05-031-25/+12
| | | | | | | | | | | | | | | | | | | | | | | | The fix for this bug was automatically merged from 10.2. However, that fix was incomplete in 10.3. This commit is for the additional changes that are necessary in 10.3. Author: Jacob Mathew. Reviewer: Kentoku Shiba.
* | MDEV-15106 Unexpected ER_WRONG_INSERT_INTO_SEQUENCE upon INSERT with ↵Monty2018-05-035-19/+50
| | | | | | | | | | | | | | multiple locks on sequences Fixed by removing the check of single lock in sequence insert and let MDL code handle deadlock detection
* | MDEV-15060 Assertion in row_log_table_apply_op after instant ADD when the ↵Marko Mäkelä2018-05-036-31/+160
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | table is emptied during subsequent ALTER TABLE During an online table rebuild, a table could be emptied and converted from 'instant ADD' format to plain (pre-10.3) format. All online_log records for rebuilding the table must be written and parsed in the format of the table that existed at the start of the operation. row_log_t::n_core_fields: A new field for recording index->n_core_fields when online ALTER is initiated in row_log_allocate(). row_log_t::is_instant(): Determine if the log is in the instant format. Only invoked by the row_log_table_ family of functions. dict_index_t::get_n_nullable(): Remove is_instant() debug assertions. Because a table can be converted to non-instant format during a table-rebuilding ALTER TABLE, these assertions would be bogus when executing row_log_table_apply(). rec_init_offsets_temp(): Add the parameter n_core for passing the original index->n_core_fields. rec_init_offsets_temp(): Add a 3-parameter variant. rec_init_offsets_comp_ordinary(): Add the parameter n_core for passing the index->n_core_fields.
* | Follow-up to MDEV-12266: Do not display table->spaceMarko Mäkelä2018-05-031-8/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | MDEV-12266 changed dict_table_t::space to a pointer. Displaying pointer values in error messages would be even more meaningless than displaying numeric tablespace identifiers. row_create_table_for_mysql(): Do not display table->space when deleting the file fails. We cannot dereference table->space here, because fil_delete_tablespace() would have freed the object. fil_wait_crypt_bg_threads(): Do not display table->space. We could display table->space_id here, but it should not really add any value, because the table reference-counts have no direct connection to files or tablespaces.
* | MDEV-16065 Assertion failed in btr_pcur_restore_position_func on UPDATEMarko Mäkelä2018-05-027-46/+94
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | btr_pcur_store_position(): Assert that the 'default row' record never is the only record in a page. (If that would happen, an empty root page would be re-created in the non-instant format, not containing the special record.) When the cursor is positioned on the page infimum, never use the 'default row' as the BTR_PCUR_BEFORE reference. (This is additional cleanup, not fixing the bug.) rec_copy_prefix_to_buf(): When converting a record prefix to the non-instant-add format, copy the original number of null flags. Rename the variable instant_len to instant_omit, and introduce a few more variables to make the code easiser to read. Note: In purge, rec_copy_prefix_to_buf() is also used for storing the persistent cursor position on a 'default row' record. The stored record reference will be garbage, but row_search_on_row_ref() will do special handling to reposition the cursor on the 'default row', based on ref->info_bits. innodb.dml_purge: Also cover the 'default row'.
* | MDEV-16071 Server crashed in innobase_build_col_map / ↵Thirunarayanan Balathandayuthapani2018-05-023-2/+16
| | | | | | | | | | | | | | prepare_inplace_alter_table_dict or Assertion `tuple' failed in dtuple_get_nth_field upon altering table with virtual column - Virtual column should be considered during innobase_build_col_map() to find out whether the field changed from NULL to NOT NULL.
* | MDEV-14168 Unconditionally allow ALGORITHM=INPLACE for setting a column NOT NULLThirunarayanan Balathandayuthapani2018-05-024-0/+269
| | | | | | | | - Added two new test case for it.
* | MDEV-15698: Spider ignores syntax errors in connection string in COMMENT fieldJacob Mathew2018-05-014-242/+419
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a comma separator is missing between COMMENT fields, Spider ignores the parameter values that are beyond the last expected parameter value. There are also some error messages that Spider does generate on COMMENT fields that are incorrectly formed. I have introduced additional infrastructure in Spider to fix these problems. Author: Jacob Mathew. Reviewer: Kentoku Shiba. Merged From: Branch bb-10.3-MDEV-15698
| * | MDEV-15698: Spider ignores syntax errors in connection string in COMMENT fieldbb-10.3-MDEV-15698Jacob Mathew2018-04-244-242/+419
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a comma separator is missing between COMMENT fields, Spider ignores the parameter values that are beyond the last expected parameter value. There are also some error messages that Spider does generate on COMMENT fields that are incorrectly formed. I have introduced additional infrastructure in Spider to fix these problems. Author: Jacob Mathew. Reviewer: Kentoku Shiba.
* | | Fix many -Wunused-parameterMarko Mäkelä2018-05-0178-1076/+422
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove unused InnoDB function parameters and functions. i_s_sys_virtual_fill_table(): Do not allocate heap memory. mtr_is_block_fix(): Replace with mtr_memo_contains(). mtr_is_page_fix(): Replace with mtr_memo_contains_page().
* | | MDEV-12645: mysql_install_db --no-test (postfixDaniel Black2018-05-011-1/+1
| | | | | | | | | | | | mysql_test_db.sql is in the srcdir
* | | MDEV-15712: If remote server used by Spider table is unavailable, some ↵Jacob Mathew2018-04-303-2/+27
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | operations hang for a long time When an attempt to connect to the remote server fails, Spider retries to connect to the remote server 1000 times or until the connection attempt succeeds. This is perceived as a hang if the remote server remains unavailable. I have introduced changes in Spider's table status handler to fix this problem. Author: Jacob Mathew. Reviewer: Kentoku Shiba. Merged From: Branch bb-10.3-MDEV-15712.
| * | | MDEV-15712: If remote server used by Spider table is unavailable, some ↵bb-10.3-MDEV-15712Jacob Mathew2018-04-233-2/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | operations hang for a long time When an attempt to connect to the remote server fails, Spider retries to connect to the remote server 1000 times or until the connection attempt succeeds. This is perceived as a hang if the remote server remains unavailable. I have introduced changes in Spider's table status handler to fix this problem. Author: Jacob Mathew. Reviewer: Kentoku Shiba.
* | | | MDEV-15938 - TINYTEXT CHARACTER SET utf8 COMPRESSED truncates dataSergey Vojtovich2018-04-306-34/+78
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Unexpected data truncation may occur when storing data to compressed blob column having multi byte variable length character sets. The reason was incorrect number of characters limit was enforced for blobs.
* | | | MDEV-12645 - mysql_install_db: no install test db optionSergey Vojtovich2018-04-3052-1386/+729
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added --skip-test-db option to mysql_install_db. If specified, no test database created and relevant grants issued. Removed --skip-auth-anonymous-user option of mysql_install_db. Now it is covered by --skip-test-db. Dropped some Debian patches that did the same. Removed unused make_win_bin_dist.1, make_win_bin_dist and mysql_install_db.pl.in.
* | | | MDEV-12218: Put back mariabackup --innodb-flush-methodMarko Mäkelä2018-04-308-39/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Implement innodb_flush_method as an enum parameter in Mariabackup, instead of ignoring the option and hard-wiring it to a default value. xb0xb.h: Remove. Only xtrabackup.cc refers to the enum parameters. innodb_flush_method_names[], innodb_flush_method_typelib[]: Define as non-static, so that mariabackup can share the definitions. srv_file_flush_method: Change the type to ulong, to match the assignment in init_one_value() and handle_options() in mariabackup.
* | | | Use compile_time_assert() in InnoDBMarko Mäkelä2018-04-3028-262/+102
| | | | | | | | | | | | | | | | | | | | | | | | Replace most use of #error. Some checks were impossible to evaluate in the preprocessor due to the use of named integer constants or enumerations.
* | | | Fix WITH_INNODB_EXTRA_DEBUGMarko Mäkelä2018-04-303-23/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The checks that used to be enabled by the flags UNIV_AHI_DEBUG, UNIV_DDL_DEBUG, UNIV_DEBUG_FILE_ACCESSES were already enabled in debug builds. So, there is no point in setting these. Only UNIV_ZIP_DEBUG is set independently of the debug build. Allow WITH_INNODB_EXTRA_DEBUG to be set for non-debug builds as well. Currently it only implies UNIV_ZIP_DEBUG, that is, extra validation for operations on ROW_FORMAT=COMPRESSED tables. page_zip_validate_low(): Allow the code to be built on non-debug server. buf_LRU_block_remove_hashed(): Allow the code to be built without WITH_INNODB_AHI.
* | | | Removed even more warning that was found with -WunusedMonty2018-04-3015-50/+28
| | | | | | | | | | | | | | | | | | | | | | | | - Removed test if HA_FT_WTYPE == HA_KEYTYPE_FLOAT as this never worked (HA_KEYTYPE_FLOAT is an enum) - Define HA_FT_MAXLEN to 126 (was tested before but never defined)
View Lorry Controller Status