summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* MDEV-13732 User with SELECT privilege can ALTER sequenceMonty2017-09-084-4/+84
| | | | Bug in privilege checking of sequences. Test case added.
* Add some const qualifiersMarko Mäkelä2017-09-084-8/+8
|
* Merge bb-10.2-ext into 10.3Marko Mäkelä2017-09-0735-132/+243
|\
| * Merge 10.2 into bb-10.2-extMarko Mäkelä2017-09-0750-255/+320
| |\
| | * Merge 10.1 into 10.2Marko Mäkelä2017-09-074-2/+5
| | |\
| | | * Merge 10.0 into 10.1Marko Mäkelä2017-09-074-2/+5
| | | |\
| | | | * MDEV-13253 After rebuilding redo logs, InnoDB can leak data from redo log bufferMarko Mäkelä2017-09-072-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | recv_reset_logs(): Initialize the redo log buffer, so that no data from the old redo log can be written to the new redo log. This bug has very little impact before MariaDB 10.2. The innodb_log_encrypt option that was introduced in MariaDB 10.1 increases the impact. If the redo log used to be encrypted, and it is being resized and encryption disabled, then previously encrypted data could end up being written to the new redo log in clear text. This resulted in encryption.innodb_encrypt_log test failures in MariaDB 10.2.
| | | | * Make the SEARCH_ABORT logic actually workMarko Mäkelä2017-09-071-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | The SEARCH_ABORT logic was not working as intended (tests were not being aborted).
| | | | * Follow-up to MDEV-13103: Do not add __attribute__((nonnull))Marko Mäkelä2017-09-071-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In XtraDB, buf_block_get_frame() can return NULL, and this value can be passed to buf_page_print(). Do not declare the parameter as nonnull.
| | * | | Fix a typo to silence -Wimplicit-fallthroughMarko Mäkelä2017-09-061-2/+1
| | | | |
| | * | | Merge 10.1 into 10.2Marko Mäkelä2017-09-0633-239/+214
| | |\ \ \ | | | |/ /
| | | * | Follow-up to MDEV-13227: Shorten the testMarko Mäkelä2017-09-062-52/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The bug only affects ROW_FORMAT=DYNAMIC tables. It is reproducible already with 2 records in the table. Keep testing with ROW_FORMAT=REDUNDANT just in case.
| | | * | Follow-up to MDEV-13227: Do not run unnecessary test combinationsMarko Mäkelä2017-09-062-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | The bug only affected innodb_page_size=64k. There is no point running the test with smaller page sizes.
| | | * | Merge 10.0 into 10.1Marko Mäkelä2017-09-0633-262/+164
| | | |\ \ | | | | |/
| | | | * MDEV-13103 Assertion `flags & BUF_PAGE_PRINT_NO_CRASH' failed in buf_page_printMarko Mäkelä2017-09-0624-251/+132
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | buf_page_print(): Remove the parameter 'flags', and when a server abort is intended, perform that in the caller. In this way, page corruption reports due to different reasons can be distinguished better. This is non-functional code refactoring that does not fix any page corruption issues. The change is only made to avoid falsely grouping together unrelated causes of page corruption.
| | | | * Post-push for MDEV-13437Andrei Elkin2017-09-041-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A new $MYSQLD_LAST_CMD evaluation was too late in case --manual-gdb. Now it is done before the server restart type branches which is safe and the args value has been fully computed by the new point of evaluation.
| | | | * MDEV-13705 10.0.32 does not compile on architectures without 64-bit atomicsMarko Mäkelä2017-09-041-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a backport of the following: MDEV-13009 10.1.24 does not compile on architectures without 64-bit atomics Add a missing #include "sync0types.h" that was removed in MDEV-12674.
| | | | * Fix compiler warningsMarko Mäkelä2017-09-017-8/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | metadata_lock_info_duration[]: Remove the unused variable. Add some comments /* fall through */ to silence -Wimplicit-fallthrough
| | | * | MDEV-10972: Insert from select / view / union -- repeatable crash in 10.1, ↵Oleksandr Byelkin2017-09-045-1/+82
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 10.2 Linux/Mac/Windows save thd->select_number between parsing and executions (in case it was not complete executed due to errors (for example epsent table))
| | * | | Fix nondeterministic failure of innodb.table_flagsMarko Mäkelä2017-09-062-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | The files ibtmp1 and ib_buffer_pool are sometimes created, sometimes not. Remove them if they exist.
| | * | | Mariabackup: Detach the threads at exitMarko Mäkelä2017-09-062-2/+2
| | | | |
| | * | | MDEV-13523: Group By in a View, called within a Stored Routine causes Error ↵Oleksandr Byelkin2017-09-062-0/+73
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Code 1356 when a non-root user runs the routine for a second time it is actually test suite for second code chunk fix in MDEV-13439
| | * | | MDEV-13585: RocksDB plugin fails to build on macOS because of unknown type ↵Varun Gupta2017-09-054-9/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `timer_t` etc. Rdb_io_watchdog can not be built on OS X. Disable it.
| | * | | Update test results for rocksdb.bulk_load_rev_cf_and_dataSergei Petrunia2017-09-051-0/+3
| | | | |
| | * | | MDEV-12731andrelkin2017-09-041-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Was reported as 'rpl.rpl_gtid_stop_start fails with Valgrind in buildbot and outside'. The 'Conditional jump or move depends on uninitialized value' valgrind complaint is valid and means THD::m_current_stage_key that is not initialized indeed by constructor. Fixed with its initialization added to the initializer list of THD::THD. Double checked with mysql to have found a similar fixes for the very same issue which was discovered after P_S merge to Maria (60589aeee where the member is introduced) had been done.
| | * | | Fix bash expansion issue in wsrep_sst_rsync (#443)Julien Del-Piccolo2017-09-031-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix bash expansion issue in wsrep_sst_rsync. https://github.com/docker-library/mariadb/issues/126 * Fix permissions
* | | | | MDEV-13724 ALTER TABLE…ALGORITHM=INPLACE is modifying the source tableMarko Mäkelä2017-09-063-13/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | row_merge_read_clustered_index(): The row->fields[] could point to a record in the clustered index page of the source table, or to an old version of the record that was constructed in row_heap. If the row->fields[] points to the clustered index page, then we were modifying buffer pool data without holding appropriate block->lock and without appropriate redo logging. The intention was to modify a copy of the data, not the source file page, because concurrent readers would still very much need the original values of the DB_TRX_ID,DB_ROLL_PTR for their multi-versioning. Either way, it is simplest to not write anything at all, and to make row->fields[] point to the constant reset_trx_id.
* | | | | Inline definition of mem_heap_dup(), mem_heap_strdup(), mem_heap_strdupl()Marko Mäkelä2017-09-053-66/+30
| | | | |
* | | | | update sysvars_server_notembedded,32bit.rdiffSergei Golubchik2017-09-021-132/+132
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | so that even the ancient patch 2.5.4 could apply it correctly. fixes centos5-x86
* | | | | Fix compile warnings.Vladislav Vaintroub2017-09-011-1/+0
| | | | |
* | | | | Merge bb-10.2-ext into 10.3Marko Mäkelä2017-09-011-0/+1
|\ \ \ \ \ | |/ / / /
| * | | | Merge 10.2 into bb-10.2-extMarko Mäkelä2017-09-011-0/+1
| |\ \ \ \ | | |/ / /
| | * | | Follow-up to MDEV-13570 Assertion failure !srv_read_only_mode in ↵Marko Mäkelä2017-09-011-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | --innodb-read-only shutdown when buf_resize_thread is active logs_empty_and_mark_files_at_shutdown(): Actually skip the debug assertion when the buf_resize_thread is active. The previous fix skipped the debug assertion failure when buf_dump_thread is active. Both these threads are created also in innodb_read_only mode. Depending on how fast these threads react to the shutdown signal, the debug assertion could be triggered. There is no impact on non-debug servers, and very little impact on debug servers either, because in innodb_read_only shutdown, no InnoDB files will need to be written.
* | | | | MDEV-13656 10.3 does not build on CentOS 5 x86Sergei Golubchik2017-09-011-1/+2
| | | | | | | | | | | | | | | | | | | | followup for 62139dc2e27
* | | | | MDEV-13690: Remove unnecessary innodb_use_mtflush, innodb_mtflush_threads ↵Jan Lindström2017-09-0116-1039/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | parameters and related code Users can use innodb-page-cleaners instead.
* | | | | Fix of a warning of gcc 7.0Oleksandr Byelkin2017-09-011-0/+1
| | | | |
* | | | | MDEV-13359 Enable ALTER TABLE...ALGORITHM=INPLACE for compressed columnsMarko Mäkelä2017-09-013-42/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | innobase_rec_reset(): Remove. This function was introduced in the InnoDB Plugin for MySQL 5.1, which later evolved into MySQL 5.5. There used to be a bug that ADD UNIQUE INDEX would not always correctly report the duplicate key value of the secondary index. This function ensured that instead of reporting total garbage values, InnoDB would report NULL. It looks like the function was made unnecessary in MySQL 5.6.6 by https://github.com/mysql/mysql-server/commit/d143097eb1e02904baed34990db637ff68fe3113 The corresponding test was subsequently adjusted in https://github.com/mysql/mysql-server/commit/fde80cf49d4b7635d2aef47d8a77681f2df62105 The ALTER TABLE tests were imported to MariaDB as part of MDEV-13625, and these tests do pass with this change. The unnecessary function did not do any harm before MDEV-11371 introduced compressed columns. One question remains: What if we needed to report a duplicate key value for a compressed column? The simple answer is that the test main.column_compression demonstrates that no indexes can be defined on compressed columns.
* | | | | Fix a buffer overflow in INFORMATION_SCHEMA.GLOBAL_VARIABLES, caused by ↵Marko Mäkelä2017-09-011-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | MDEV-12179 pretty_print_engine_list(): When the plugin list is empty, return an empty string instead of allocating a buffer of 0 bytes and then trying to write a NUL byte into it.
* | | | | Merge bb-10.2-ext into 10.3Marko Mäkelä2017-09-01302-1511/+12039
|\ \ \ \ \ | |/ / / /
| * | | | After-merge fixes for Galera test resultsMarko Mäkelä2017-09-014-4/+4
| | | | |
| * | | | Merge 10.2 into bb-10.2-extMarko Mäkelä2017-09-011-0/+2
| |\ \ \ \ | | |/ / /
| | * | | After-merge fix for a Galera test resultMarko Mäkelä2017-09-011-0/+2
| | | | |
| * | | | Merge 10.2 into bb-10.2-extMarko Mäkelä2017-09-01318-1799/+12435
| |\ \ \ \ | | |/ / /
| | * | | Fix test for MDEV-13674: Deprecate innodb_use_mtflush and innodb_mtflush_threadsMarko Mäkelä2017-09-011-1/+1
| | | | |
| | * | | Merge 10.1 into 10.2Marko Mäkelä2017-08-312-2/+4
| | |\ \ \ | | | |/ /
| | | * | Merge 10.0 into 10.1Marko Mäkelä2017-08-312-2/+4
| | | |\ \ | | | | |/
| | | | * MDEV-13693 : Fix parameter passing to my_error.Vladislav Vaintroub2017-08-311-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | char* parameter is expected by the message ER_KEY_COLUMN_DOES_NOT_EXITS, thus pass char*, rather than LEX_STRING.
| | | | * MDEV-13691 : my_write() sets inappropriate errno for ERROR_FILE_SYSTEM_LIMITATONVladislav Vaintroub2017-08-311-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ERROR_FILE_SYSTEM_LIMITATION was seen by support when backing up large file. However mariabackup error message was not very helpful, since it mapped the error to generic catch-all EINVAL. With the patch, ERROR_FILE_SYSTEM_LIMITATION will be mapped to more appropriate EFBIG. Also add mapping from ERROR_NO_SYSTEM_RESOURCES to ENOMEM.
| | * | | Disable a badly written, randomly failing Galera testMarko Mäkelä2017-08-311-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | CURRENT_TEST: galera.galera_kill_applier mysqltest: At line 14: query 'KILL $applier_thread' failed with wrong errno 1064: 'You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '' at line 1', instead of 1095...
| | * | | MDEV-13674: Deprecate innodb_use_mtflush and innodb_mtflush_threadsbb-10.2-MDEV-13674Jan Lindström2017-08-312-4/+22
| | | | | | | | | | | | | | | | | | | | | | | | | These parameters and associated code is to be removed in 10.3. Users can use innodb-page-cleaners > 1 instead.