summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* MDEV-23026 purge fails with assert !rw_lock_own_flagged(lock, ↵st-10.2-MDEV-23026Thirunarayanan Balathandayuthapani2021-04-151-2/+4
| | | | | | | | | | | | | | | RW_LOCK_FLAG_X | RW_LOCK_FLAG_S) InnoDB purge thread locks the root page of clustered index while accessing the undo log records and later same thread tries to open the table, initialize statistics and tries to lock the clustered index root page while doing virtual column computation. Solution: ========= InnoDB should prevent statistics initialization when the table is being opened by purge thread
* update C/CSergei Golubchik2021-04-151-0/+0
|
* MDEV-25403 ALTER TABLE wrongly checks for field's default value if AFTER is usedSergei Golubchik2021-04-153-1/+30
| | | | | | | | When a column is added to an non-empty table, existing rows will have a column's default value for existing rows. Or a "zero value" if the column has no default. But this check should be skipped when an existing column is altered.
* signal handler, display coredump file pattern similarly to MDEV-25294 but ↵David Carlier2021-04-151-3/+3
| | | | for FreeBSD, thankfully the sysctl OID is the same.
* Update mysqlbinlog man page with --table optionIan Gilfillan2021-04-141-2/+19
|
* MDEV-25363 binlog_stm_datetime_ranges_mdev15289 failed in bbAlice Sherepa2021-04-142-0/+2
|
* MDEV-25354: Fix my_print_defaults wordingIan Gilfillan2021-04-141-1/+1
|
* -DMYSQL_MAINTAINER_MODE=NOSergei Golubchik2021-04-132-3/+7
| | | | | also add =WARN as an alias for =OFF and clarify the help text
* MDEV-24971 InnoDB access freed virtual column after rollback of secondary indexst-10.2-MDEV-24971Thirunarayanan Balathandayuthapani2021-04-131-2/+1
| | | | | - Fixing post-fix failure. In clean_new_vcol_index(), InnoDB has the wrong offset to store the virtual column
* MDEV-24135: Print warnings in XML, save test retries in XML, save the ↵Dmitriy Karpovskiy2021-04-122-14/+26
| | | | combinations in XML, replace the special symbols in the XML comment
* MDEV-25182 Complex query in Store procedure corrupts resultsbb-10.2-MDEV-25182Oleksandr Byelkin2021-04-126-7/+77
| | | | | | | | | | | | | | | | | | | | | At the second execution of the PS 1. mark_as_dependent() is called with the same parameters as at the first execution (select#4 and select#3) 2. as outer_select (select#3) has been already merged at the first execution of PS it cannot be reached using the outer_select() function anymore (and so can not stop iteration). 3. as a result all selects towards the top level select including the select for 'ca' are marked as uncacheable. 4. Marked uncacheable it executed incorrectly triggering filling its temporary table several times and using freed memory at the end. To avoid the problem we use name resolution context to go "up". NOTE: problem also exists in 10.2 but has no visible effect on execution. That is why the problem is fixed in 10.2. The patch also add debug logging of important procedures and better specify parameters types of st_select_lex::mark_as_dependent.
* MDEV-25108: Running of the EXPLAIN EXTENDED statement produces extra warning ↵bb-10.2-MDEV-25108-2Dmitry Shulga2021-04-126-15/+80
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | in case it is executed in PS (prepared statement) mode The EXPLAIN EXTENDED statement run as a prepared statement can produce extra warning comparing with a case when EXPLAIN EXTENDED statement is run as a regular statement. For example, the following test case CREATE TABLE t1 (c int); CREATE TABLE t2 (d int); EXPLAIN EXTENDED SELECT (SELECT 1 FROM t2 WHERE d = c) FROM t1; produces the extra warning "Field or reference 'c' of SELECT #2 was resolved in SELECT #1" in case the above mentioned "EXPLAIN EXTENDED" statement is executed in PS mode, that is by submitting the following statements: PREPARE stmt FROM "EXPLAIN EXTENDED SELECT (SELECT 1 FROM t2 WHERE d = c) FROM t1"; EXECUTE stmt; The reason of the extra warning emittion is in a way items are handled (being fixed) during execution of the JOIN::prepare() method. The method Item_field::fix_fields() calls the find_field_in_tables() function in case a field hasn't been associated yet with the item. Implementation of the find_field_in_tables() function first checks whether a table containing the required field was already opened and cached. It is done by checking the data member item->cached_table. This data member is set on handling the PRERARE FROM statement and checked on executing the EXECUTE statement. If the data member item->cached_table is set the find_field_in_tables() function invoked and the mark_select_range_as_dependent() function called if the field is an outer referencee. The mark_select_range_as_dependent() function calls the mark_as_dependent() function that finally invokes the push_warning_printf() function that produces extra warning. To fix the issue, calling of push_warning_printf() is elimited in case it was run indirectly in result of hanlding already opened table from the Item_field::fix_fields() method.
* MDEV-21484: galera_sst_mariabackup_encrypt_with_key test failedbb-10.2-MDEV-21484Julius Goryavsky2021-04-121-1/+0
| | | | | | This commit removes the mtr test galera_sst_mariabackup_encrypt_with_key from the list of disabled tests because the problem with it has already been fixed.
* MDEV-24971 InnoDB access freed virtual column after rollback of secondary indexThirunarayanan Balathandayuthapani2021-04-129-51/+300
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem: ======== InnoDB fails to clean the index stub if it fails to add the virtual index which contains new virtual column. But it clears the newly virtual column from index in clear_added_indexes() during inplace_alter_table. On commit, InnoDB evicts and reload the table. In case of rollback, it doesn't happen. InnoDB clears the ABORTED index while opening the table or doing the DDL. In the mean time, InnoDB can access the dropped virtual index columns while creating prebuilt or rollback of concurrent DML. Solution: ========== (1) InnoDB should maintain newly added virtual column while rollbacking the newly added virtual index. (2) InnoDB must not defer the index removal if the alter table is executed with LOCK=EXCLUSIVE. (3) For LOCK=SHARED, InnoDB should check whether the table has any other transaction lock other than alter transaction before deferring the index stub. Replaced has_new_v_col with dict_add_vcol_info in dict_index_t to indicate whether the index has any new virtual column. dict_index_t::has_new_v_col(): Returns whether the index has newly added virtual column, it doesn't say which columns are newly added virtual column ha_innobase_inplace_ctx::is_new_vcol(): Return whether the given column is added as a part of the current alter. ha_innobase_inplace_ctx::clean_new_vcol_index(): Copy the newly added virtual column to new_vcol_info in dict_index_t. Replace the column in the index fields with virtual column stored in new_vcol_info. dict_index_t::assign_new_v_col(): Store the number of virtual column added in index as a part of alter table. dict_index_t::get_n_new_vcol(): Get the number of newly added virtual column dict_index_t::assign_drop_v_col(): Allocate the memory for adding new virtual column in new_vcol_info. dict_index_t::add_drop_v_col(): Add the newly added virtual column in new_vcol_info. dict_table_t::has_lock_for_other_trx(): Whether the table has any other transaction lock than given transaction. row_merge_drop_indexes(): Add parameter alter_trx and check whether the table has any other lock than alter transaction.
* MDEV-18802 Assertion table->stat_initialized failed in ↵Marko Mäkelä2021-04-121-2/+17
| | | | | | | | | | | | | | dict_stats_update_if_needed() When a table has been evicted from dict_sys and reloaded internally by InnoDB for FOREIGN KEY processing, statistics may not be initialized, but nevertheless row_update_cascade_for_mysql() could invoke dict_stats_update_if_needed(). In that case, we cannot really update the statistics. For tables that have STATS_PERSISTENT=1 and STATS_AUTO_RECALC=1, ANALYZE TABLE might have to be executed later. dict_stats_update_if_needed(): Replace the assertion with a conditional early return.
* MDEV-24434 Assertion trx->in_rw_trx_list... in trx_sys_any_active_transactions()Marko Mäkelä2021-04-121-6/+1
| | | | | | | trx_sys_any_active_transactions(): Remove a bogus debug assertion. In trx_commit_in_memory() and trx_erase_lists(), we will remove the transaction from trx_sys->rw_trx_list and set the state to TRX_STATE_COMMITTED_IN_MEMORY.
* Deb: Stop depending on empty transitional package dh-systemdOtto Kekäläinen2021-04-122-1/+10
| | | | | | | | | MariaDB Server still supports Ubuntu 16.04 "Xenial" until it goes EOL in April 30, 2021. Thus we need to include a customization for backwards compatibility. This change is intended to be applied for all MariaDB versions still supported, i.e. 10.2 to 10.6.
* MDEV-25307: The value of the auto-increment variables changes during the testbb-10.2-MDEV-25307Julius Goryavsky2021-04-115-7/+16
| | | | | | | | | | The auto-increment variables may change intermittently during the execution of some tests from the Galera mtr suite, causing these tests to fail. This patch creates conditions in which unpredictable changes to these variables are not possible during the execution of those tests in which this problem is noticed or their values are restored before the end of testing.
* MDEV-25356: SST scripts should use the new mariabackup interfacebb-10.2-MDEV-25356Julius Goryavsky2021-04-113-14/+15
| | | | | | | | | | | SST scripts for Galera should use the new mariabackup interface instead of the innobackupex interface, which is currently only supported for compatibility reasons. This commit converts the SST script for mariabackup to use the new interface. It does not need separate tests, as any problems will be seen as failures when running multiple tests for the mariabackup-based SST.
* Removed extra spaces in generated command lines (minor "cosmetic"bb-10.2-MDEV-25328-v5Julius Goryavsky2021-04-111-7/+7
| | | | change after MDEV-24197)
* Clarified abbreviated option names in some tests, to avoidJulius Goryavsky2021-04-113-6/+6
| | | | problems with ambiguous options in the future.
* MDEV-25328: --innodb command line option causes mariabackup to failJulius Goryavsky2021-04-111-0/+2
| | | | | | | | | This patch fixes an issue with launching mariabackup during SST (when used with Galera), when during bootstrap mariabackup receives the "--innodb" option, which is incorrectly interpreted as shortcut for "--innodb-force-recovery". This patch does not require separate test for mtr, as the problem is visible in general testing on buildbot.
* BtrBulk::table_name(): Return the table name while displayingThirunarayanan Balathandayuthapani2021-04-092-2/+2
| | | | table name for fts diagnostics
* Improve diagnostics in order to catch MDEV-18868 and similar bugsThirunarayanan Balathandayuthapani2021-04-093-8/+18
|
* MDEV-13467 fixup: Improve error handlingMarko Mäkelä2021-04-081-7/+15
|
* MDEV-25019 memory allocation failures during startup becausebb-10.2-MDEV-25019Thirunarayanan Balathandayuthapani2021-04-073-0/+22
| | | | | | | | | | server failure in different, confusing ways InnoDB fails to free the buffer pool instance mutex and zip mutex If the allocation of buffer pool instance chunk fails. So it leads to freeing of buffer pool before freeing the mutexes and leads to double freeing of memory while freeing the mutex during shutdown.
* Fix postinst trigger when systemd is not running (Closes: #983563)bb-10.2-anel-systemdpatchArnaud Rebillout2021-04-061-2/+2
| | | | | | | | | | | | | | | | Checking for the existence of the systemctl command only tells us that systemd is installed, however it does not tell us if systemd is running. What we really want to do here is reload systemd if it's installed AND if it's running. The usual way to check if systemd is running is to check for the existence of '/run/systemd/system'. Why would systemd be installed but not running? This is something that happens when one sets up or upgrade a system in a chroot or container. For more details refer to the bug report: <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=983563> Closes PR #1787
* MDEV-25295 Aborted FTS_DOC_ID_INDEX considered as existing FTS_DOC_ID_INDEX ↵bb-10.2-MDEV-25295Thirunarayanan Balathandayuthapani2021-04-063-2/+31
| | | | | | | | | during DDL InnoDB should skip the dropped aborted FTS_DOC_ID_INDEX while checking the existing FTS_DOC_ID_INDEX in the table. InnoDB should able to create new FTS_DOC_ID_INDEX if the fulltext index is being added for the first time.
* MDEV-25242 Server crashes in check_grant upon invoking function with ↵Sergei Golubchik2021-04-033-1/+5
| | | | | | | | userstat enabled also fix index_stats table. followup for 5a798071199
* MDEV-25321: mariabackup failed if password is passed via environment variablebb-10.2-MDEV-25321Julius Goryavsky2021-04-011-0/+7
| | | | | | | | | | | | The mariabackup interface currently supports passing a password through an explicit command line variable, but does not support passing a password through the MYSQL_PWD environment variable. At the same time, the Galera SST script for mariabackup uses the environment variable to pass the password, which leads (in some cases) to an unsuccessful launch of mariabackup and to the inability to start the cluster. This patch fixes this issue. It does not need a separate test, as the problem is visible in general testing on buildbot.
* MDEV-24197: Add "innodb_force_recovery" for "mariabackup --prepare"Srinidhi Kaushik2021-04-016-9/+233
| | | | | | | | | | | | | | | | | | | During the prepare phase of restoring backups, "mariabackup" does not seem to allow (or recognize) the option "innodb_force_recovery" for the embedded InnoDB server instance that it starts. If page corruption observed during page recovery, the prepare step fails. While this is indeed the correct behavior ideally, allowing this option to be set in case of emergencies might be useful when the current backup is the only copy available. Some error messages during "--prepare" suggest to set "innodb_force_recovery" to 1: [ERROR] InnoDB: Set innodb_force_recovery=1 to ignore corruption. For backwards compatibility, "mariabackup --innobackupex --apply-log" should also have this option. Signed-off-by: Srinidhi Kaushik <shrinidhi.kaushik@gmail.com>
* MDEV-25047: SIGSEGV in mach_read_from_n_little_endianbb-10.2-MDEV-25047mkaruza2021-04-013-1/+33
| | | | | | | Virtual column fields are not found in prebuilt data type, so we should match InnoDB fields with `get_innobase_type_from_mysql_type` method. Reviewed-by: Jan Lindström <jan.lindstrom@mariadb.com>
* CMake - when searching bison, look also for win_bisonVladislav Vaintroub2021-03-311-1/+1
| | | | | win_bison belongs winflexbison project, which is Windows most up-to-date bison distro.
* MDEV-25221 Do not remove source file, if copy_file() fails in mariabackup ↵Vladislav Vaintroub2021-03-3111-5/+61
| | | | | | --move-back Remove an incompletely copied destination file.
* MDEV-13103 fixup: Actually fix a crash during IMPORT TABLESPACEMarko Mäkelä2021-03-311-6/+8
|
* MDEV-25294 signal handler display coredump on macDavid CARLIER2021-03-301-1/+13
|
* MDEV-25200 Index count mismatch due to aborted FULLTEXT INDEXThirunarayanan Balathandayuthapani2021-03-303-0/+59
| | | | | | | | - Aborting of fulltext index creation fails to remove the index from sys indexes table. When we try to reload the table definition, InnoDB fails with index count mismatch error. InnoDB should remove the index from sys indexes while rollbacking the secondary index creation.
* MDEV-15527 page_compressed compressed page partially during import tablespaceThirunarayanan Balathandayuthapani2021-03-301-1/+1
| | | | - Post push to address 32-bit build failure.
* Add missing have_perfschema.incMarko Mäkelä2021-03-302-0/+2
|
* MDEV-15527 page_compressed compressed page partially during import tablespacebb-10.2-MDEV-15527Thirunarayanan Balathandayuthapani2021-03-301-11/+74
| | | | | | | | - Importing table operation fails to punch the hole in the filesystem when page compressed table is involved. To achieve that, InnoDB firstly punches the hole for the IOBuffer size(1MB). After that, InnoDB should write page by page when page compression is involved.
* Add supression for warning.Jan Lindström2021-03-302-0/+3
|
* MDEV-24923 : Port selected Galera conflict resolution changes from 10.6Jan Lindström2021-03-303-121/+107
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add condition on trx->state == TRX_STATE_COMMITTED_IN_MEMORY in order to avoid unnecessary work. If a transaction has already been committed or rolled back, it will release its locks in lock_release() and let the waiting thread(s) continue execution. Let BF wait on lock_rec_has_to_wait and if necessary other BF is replayed. wsrep_trx_order_before If BF is not even replicated yet then they are ordered correctly. bg_wsrep_kill_trx Make sure victim_trx is found and check also its state. If state is TRX_STATE_COMMITTED_IN_MEMORY transaction is already committed or rolled back and will release it locks soon. wsrep_assert_no_bf_bf_wait Transaction requesting new record lock should be TRX_STATE_ACTIVE Conflicting transaction can be in states TRX_STATE_ACTIVE, TRX_STATE_COMMITTED_IN_MEMORY or in TRX_STATE_PREPARED. If conflicting transaction is already committed in memory or prepared we should wait. When transaction is committed in memory we held trx mutex, but not lock_sys->mutex. Therefore, we could end here before transaction has time to do lock_release() that is protected with lock_sys->mutex. lock_rec_has_to_wait We very well can let bf to wait normally as other BF will be replayed in case of conflict. For debug builds we will do additional sanity checks to catch unsupported bf wait if any. wsrep_kill_victim Check is victim already in TRX_STATE_COMMITTED_IN_MEMORY state and if it is we can return. lock_rec_dequeue_from_page lock_rec_unlock Remove unnecessary wsrep_assert_no_bf_bf_wait function calls. We can very well let BF wait here.
* remove broken tests/grant.plDaniel Black2021-03-301-750/+0
|
* mallinfo2: whitespace fixDaniel Black2021-03-301-1/+1
|
* Windows - suppress nonsensical(for this OS) system check.Vladislav Vaintroub2021-03-301-0/+1
| | | | Amends 48141f3c1787de941d969ad1e6675611b2b650c2
* MDEV-24586: remove mysql_to_mariadb.sqlbb-10.2-MDEV-24586-danielblack-remove-mysql_to_mariadb.sqlDaniel Black2021-03-302-23/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | This script is unused and unmaintained. The logic is implemented in scripts/mysql_system_tables_fix.sql that forms part of mysql_upgrade Its components: alter table mysql.user drop column `password_last_changed`, drop column `password_lifetime`, drop column `account_locked`; has a friendlier migration path coming MDEV-24122 alter table mysql.user change column `authentication_string` `auth_string` text COLLATE utf8_bin NOT NULL; Already part of scripts/mysql_system_tables_fix.sql alter table mysql.user add column `Password` char(41) CHARACTER SET latin1 COLLATE latin1_bin NOT NULL DEFAULT '' after `user`, add column `is_role` enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N' after `auth_string`; alter table mysql.user add column `default_role` char(80) COLLATE utf8_bin NOT NULL DEFAULT '', add column `max_statement_time` decimal(12,6) NOT NULL DEFAULT '0.000000'; corrected in MDEV-23201 to be in the right order. update mysql.user set `password`=`auth_string`, plugin='' where plugin="mysql_native_password"; Is handled in server in the function acl_load.
* Don't pass password to innobackup via command line, use environment insteadbb-10.2-codership-cmd-line-pswdAlexey Yurchenko2021-03-292-6/+6
| | | | Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>
* MDEV-25457 CREATE / DROP PROCEDURE not logged with audit plugin.Alexey Botchkov2021-03-293-5/+26
| | | | CREATE/DROP PROCEDIRE/FUNCTION is now treated as DDL.
* MDEV-25240 minor upgrade does not perform server restartbb-10.2-MDEV-25240Alexey Bychko2021-03-291-3/+8
| | | | | | | we need to stop server instance on upgrade, but it may be started either by SysV init script or by SystemD. this commit adds `mysql` target to `systemctl stop` call. `mysql` may be the name of initscript or an alias while `mariadb` is a systemd unit file.
* MDEV-13467: Feature request: Support for ST_Distance_Sphere()bb-10.2-anel-MDEV-13467-gis-feature-v1Anel Husakovic2021-03-271-2/+2
| | | | | - jump to label ‘handle_errors’ can enter to the scope of non-POD ‘Geometry_buffer buffer2’