summaryrefslogtreecommitdiff
path: root/client
Commit message (Collapse)AuthorAgeFilesLines
* Backport http://lists.mysql.com/commits/57778Vladislav Vaintroub2009-09-301-7/+0
| | | | | | | | | | | | | | | | | | | | | 2677 Vladislav Vaintroub 2008-11-04 CMakeLists.txt files cleanup - remove SAFEMALLOC and SAFE_MUTEX definitions that were present in *each* CMakeLists.txt. Instead, put them into top level CMakeLists.txt, but disable on Windows, because a) SAFEMALLOC does not add any functionality that is not already present in Debug C runtime ( and 2 safe malloc one on top of the other only unnecessarily slows down the server) b)SAFE_MUTEX does not work on Windows and have been explicitely disabled on Windows with #undef previously. Fortunately, ntdll does pretty good job identifying l problems with CRITICAL_SECTIONs. DebugBreak()s on using uninited critical section, unlocking unowned critical section) -Also, remove occationally used -D_DEBUG (added by compiler anyway)
* Backport of the patch Vladislav Vaintroub2009-09-301-10/+10
| | | | | | | | | | | | | | | | | | | | | http://lists.mysql.com/commits/57725 Vladislav Vaintroub 2008-11-03 Cleanup CMakeLists.txt(s) - remove winsock2 (ws2_32) from TARGET_LINK_LIBRARIES. Every exe or dll linked with mysys needs ws2_32, because mysys uses winsock function WSAStartup in my_init(). However, there is no need to explicitely add ws2_32 to the list of TARGET_LINK_LIBRARIES multiple times. Visual Studio comes with a handy pragma that tells linker to add library. So patch replaces bunch of ws2_32 in CMakeLists with single pragma comment(lib,"ws2_32") in my_init.c Additionally, reference to non-existing "debug" library has been removed from TARGET_LINK_LIBRARIES. The correct name of the library is "dbug".
* Windows improvements : manual backport of Vladislav Vaintroub2009-09-301-9/+9
| | | | | | | | | | | | | | | | htttp://lists.mysql.com/commits/50957?f=plain Always use TLS functions instead of __declspec(thread) to access thread local storage variables. The change removes the necessity to recomplile the same source files twice - with USE_TLS for DLLs and without USE_TLS for EXEs. Real benefit of this change is better readability and maintainability of TLS functions within MySQL. There is a performance loss using TlsXXX functions compared to __declspec but the difference is negligible in practice. In a sysbench-like benchmark I ran with with TlsGetValue, pthread_[get|set]_specific was called 600000000 times and took 0.17sec of total 35min CPU time, or 0.008%.
* mergeVladislav Vaintroub2009-09-235-75/+204
|\
| * new merge from trunkBjorn Munch2009-09-185-57/+133
| |\
| | * A patch for Bug#45118 (mysqld.exe crashed in debug modeAlexander Nozdrin2009-09-101-1/+6
| | | | | | | | | | | | | | | on Windows in dbug.c) -- part 2: a patch for the DBUG subsystem to detect misuse of DBUG_ENTER / DBUG_RETURN macros. 5.1 version.
| | * manual mergeTatiana A. Nurnberg2009-08-311-32/+100
| | |\
| | | * Bug#35132: MySQLadmin --wait ping always crashes on Windows systemsTatiana A. Nurnberg2009-08-311-29/+99
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Failing to connect would release parts of the MYSQL struct. We would then proceed to try again to connect without re- initializing the struct. We prevent the unwanted freeing of data we'll still need now.
| | * | Merge from 5.0 for 43414Staale Smedseng2009-08-284-12/+15
| | |\ \ | | | |/
| | | * Bug #43414 Parenthesis (and other) warnings compiling MySQLStaale Smedseng2009-08-285-19/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | with gcc 4.3.2 This patch fixes a number of GCC warnings about variables used before initialized. A new macro UNINIT_VAR() is introduced for use in the variable declaration, and LINT_INIT() usage will be gradually deprecated. (A workaround is used for g++, pending a patch for a g++ bug.) GCC warnings for unused results (attribute warn_unused_result) for a number of system calls (present at least in later Ubuntus, where the usual void cast trick doesn't work) are also fixed.
| | * | Fix for a few assorted compiler warnings.Davi Arnaut2009-08-282-12/+12
| | | |
| * | | initial merge from 5.1-mtrBjorn Munch2009-09-041-18/+71
| |\ \ \ | | |/ / | |/| |
| | * | Bug #32296 mysqltest fails to parse "append_file" inside a "while", it works ↵Bjorn Munch2009-09-021-10/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | inside a "if" Bug #41913 mysqltest cannot source files from if inside while Some commands require additional processing which only works first time Keep content for write_file or append_file with the st_command struct Add tests for those cases to mysqltest.test
| | * | mergeBjorn Munch2009-09-011-2/+7
| | |\ \
| | | * | Bug #39003 mtr's diff_files command failed in pushbuild without printing a ↵Bjorn Munch2009-08-191-2/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | result diff diff was actually called but result never outputted before exiting Added extra code to dump output *unless* failure was expected
| | * | | Bug #46164 memory leak in mysqltest after parse error with --debugBjorn Munch2009-08-181-3/+4
| | |/ / | | | | | | | | | | | | Moved some dynstr_free() further up
| | * | Bug #44012 mtr: test cases that are not supposed to return output always failBjorn Munch2009-08-111-3/+14
| | | | | | | | | | | | | | | | | | | | Output would match an empty result file but we don't check Allow empty output IFF there is an empty result file.
* | | | This is the downport ofVladislav Vaintroub2009-09-113-3/+3
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug#24509 - 2048 file descriptor limit on windows needs increasing, also WL#3049 - improved Windows I/O The patch replaces the use of the POSIX I/O interfaces in mysys on Windows with the Win32 API calls (CreateFile, WriteFile, etc). The Windows HANDLE for the open file is stored in the my_file_info struct, along with a flag for append mode because the Windows API does not support opening files in append mode in all cases) The default max open files has been increased to 16384 and can be increased further by setting --max-open-files=<value> during the server start. Another major change in this patch that almost all Windows specific file IO code has been moved to a new file my_winfile.c, greatly reducing the amount of code in #ifdef blocks within mysys, thus improving readability. Minor enhancements: - my_(f)stat() is changed to use __stati64 structure with 64 file size and timestamps. It will return correct file size now (C runtime implementation used to report outdated information) - my_lock on Windows is prepared to handle additional timeout parameter - after review : changed __WIN__ to _WIN32 in the new and changed code.
* | | Additional post-commit fix (bug #30946): server versionGleb Shchepa2009-08-041-1/+1
| | | | | | | | | | | | in a conditional commentary at the new SELECT ... INTO OUTFILE ... CHARACTER SET syntax has been updated to 5.1.38.
* | | Auto-mergeIgnacio Galarza2009-07-311-1/+1
|\ \ \ | | |/ | |/|
| * | Bug#17270 - mysql client tool could not find ../share/charsets folder and fails.Ignacio Galarza2009-07-311-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | - Define and pass compile time path variables as pre-processor definitions to mimic the makefile build. - Set new CMake version and policy requirements explicitly. - Changed DATADIR to MYSQL_DATADIR to avoid conflicting definition in Platform SDK header ObjIdl.h which also defines DATADIR.
| * | Bug #45287: phase 2 : 5.0 64 bit compilation warningsGeorgi Kodinov2009-07-162-3/+3
| | | | | | | | | | | | | | | Fixed various compilation warnings when compiling on a 64 bit windows.
* | | Bug# 30946: mysqldump silently ignores --default-character-setGleb Shchepa2009-07-311-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when used with --tab 1) New syntax: added CHARACTER SET clause to the SELECT ... INTO OUTFILE (to complement the same clause in LOAD DATA INFILE). mysqldump is updated to use this in --tab mode. 2) ESCAPED BY/ENCLOSED BY field parameters are documented as accepting CHAR argument, however SELECT .. INTO OUTFILE silently ignored rests of multisymbol arguments. For the symmetrical behavior with LOAD DATA INFILE the server has been modified to fail with the same error: ERROR 42000: Field separator argument is not what is expected; check the manual 3) Current LOAD DATA INFILE recognizes field/line separators "as is" without converting from client charset to data file charset. So, it is supposed, that input file of LOAD DATA INFILE consists of data in one charset and separators in other charset. For the compatibility with that [buggy] behaviour SELECT INTO OUTFILE implementation has been saved "as is" too, but the new warning message has been added: Non-ASCII separator arguments are not fully supported This message warns on field/line separators that contain non-ASCII symbols.
* | | Merge bug fix.Jim Winstead2009-07-301-3/+28
|\ \ \
| * | | The handling of NUL bytes in column data in the various output formatsJim Winstead2009-07-141-3/+28
| | | | | | | | | | | | | | | | supported by the mysql client was inconsistent. (Bug #28203)
* | | | Merge in bug fixes for client toolsJim Winstead2009-07-147-14/+57
|\ \ \ \ | |/ / /
| * | | mysqlcheck failed to fix table names when using the --fix-table-namesJim Winstead2009-05-201-2/+2
| | | | | | | | | | | | | | | | and --all-in-1 options together. (Bug #31821)
| * | | mysqladmin --count=X --sleep=Y would always delay Y seconds after the lastJim Winstead2009-05-201-3/+3
| | | | | | | | | | | | | | | | iteration before exiting. (Bug #42639)
| * | | The mysql command-line client would include superfluous spaces at the end ofJim Winstead2009-05-201-1/+4
| | | | | | | | | | | | | | | | some result set lines. (Bug #29622)
| * | | Fix warning in use of strlen().Jim Winstead2009-05-201-1/+2
| | | |
| * | | Table identifiers and file names were not quoted and escaped correctly byJim Winstead2009-05-191-3/+13
| | | | | | | | | | | | | | | | mysqlimport. (Bug #28071)
| * | | mysql_upgrade ignored the --basedir and --datadir arguments as it has no useJim Winstead2009-05-191-1/+5
| | | | | | | | | | | | | | | | for them, but it did so silently. (Bug #36558)
| * | | The mysql command-line client didn't implement the readline magic-spaceJim Winstead2009-05-191-0/+17
| | | | | | | | | | | | | | | | | | | | command, which bash does, which could result in a user accidentally disabling the use of the space key in the mysql command-line client. (Bug #27439)
| * | | mysqlslap didn't correctly handle --csv with no argument. (Bug #44412)Jim Winstead2009-05-181-2/+6
| | | |
| * | | mysqladmin did not have enough space allocated for tracking all variablesJim Winstead2009-05-181-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when using --vertical or --relative with extended-status. (Bug #40395) This patch simply increases the buffer size and adds an assert to check that it is big enough -- a more comprehensive fix would dynamically allocate the appropriate buffers.
| * | | The output of mysqldump --tab for views included a DROP TABLE statementJim Winstead2009-05-181-1/+2
| | | | | | | | | | | | | | | | | | | | without the IF EXISTS qualifier even though no temporary table is created as for all-in-one dumps including views. (Bug #37377)
* | | | Merge bug fixesJim Winstead2009-07-133-9/+18
|\ \ \ \ | |/ / /
| * | | Add usage for --base64-output=DECODE-ROWS and note that UNSPEC isJim Winstead2009-05-151-0/+3
| | | | | | | | | | | | | | | | intentionally unmentioned (it is just a placeholder). (Bug #41403)
| * | | Remove out-of-date and unnecessary comment in source code about what versionsJim Winstead2009-05-151-3/+1
| | | | | | | | | | | | | | | | are supported. (Bug #42021)
| * | | mysqlimport was not always compiled correctly to allow thread support,Jim Winstead2009-05-121-1/+1
| | | | | | | | | | | | | | | | required for the --use-threads option. (Bug #32991)
| * | | mysqldump would not dump the INFORMATION_SCHEMA even when it was explicitlyJim Winstead2009-05-121-5/+13
| | | | | | | | | | | | | | | | requested. (Bug #33762)
* | | | Bug #43397 mysql headers redefine pthread_mutex_initStaale Smedseng2009-07-081-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | unnecessarily The problem is that libmysqlclient.so is built with THREAD undefined, while a client compiling against the same header files will see THREAD as defined and definitions in my_pthread.h will be included, possibly resulting in undefined symbols that cannot be resolved with libmysqlclient.so. The suggested solution is to require that clients wanting to link with libmysqlclient.so should be built with MYSQL_CLIENT_NO_THREADS defined. This requires a documentation change, and more details for this will be supplied if this patch is approved. The MYSQL_CLIENT_NO_THREADS define was renamed from UNDEF_THREADS_HACK, to get a more suitable (less suspicious) name for the define. (The UNDEF_THREADS_HACK is retained for backwards compatibility, though.) This patch is also in anticipation of WL#4958, which will remove this problem altogether by dropping the building of libmysqlclient.
* | | | fixed compilation warnings on macosxGeorgi Kodinov2009-07-071-2/+2
| | | |
* | | | Bug#37274 client 'status' command doesn't print all info after losing ↵Kristofer Pettersson2009-07-031-31/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | connection to server If the server connection was lost during repeated status commands, the client would fail to detect this and the client output would be inconsistent. This patch fixes this issue by making sure that the server is online before the client attempts to execute the status command.
* | | | merge: 5.1-bt bug branch --> 5.1-bt latestLuis Soares2009-06-301-1/+55
|\ \ \ \
| * | | | BUG#42941: --database paramater to mysqlbinlog fails with RBRLuis Soares2009-06-071-1/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | mysqlbinlog --database parameter was being ignored when processing row events. As such no event filtering would take place. This patch addresses this by deploying a call to shall_skip_database when table_map_events are handled (as these contain also the name of the database). All other rows events referencing the table id for the filtered map event, will also be skipped.
* | | | | Merge from 5.0Staale Smedseng2009-06-292-5/+5
|\ \ \ \ \ | | |_|/ / | |/| | |
| * | | | Merge from 5.0-btStaale Smedseng2009-06-293-6/+6
| | | | |
| * | | | Automerge.Alexey Kopytov2009-06-171-1/+1
| |\ \ \ \
* | | | | | Bug#44834 strxnmov is expected to behave as you'd expectSergey Glukhov2009-06-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The problem: described in the bug report. The fix: --increase buffers where it's necessary (buffers which are used in stxnmov) --decrease buffer lengths which are used