summaryrefslogtreecommitdiff
path: root/extra
Commit message (Collapse)AuthorAgeFilesLines
* Fix race conditionsMarko Mäkelä2019-04-041-2/+7
|
* Merge 10.1 into 10.2Marko Mäkelä2019-03-264-0/+4
|\
| * Fix resource leakFaramosCZ2019-03-221-0/+1
| | | | | | | | The 'bitmap_dir' has to be closed when no longer needed
| * Fix resource leakFaramosCZ2019-03-221-0/+1
| |
| * Fix resource leakFaramosCZ2019-03-221-0/+1
| |
| * Fix resource leakFaramosCZ2019-03-221-0/+1
| |
* | Merge 10.1 into 10.2Marko Mäkelä2019-03-221-3/+2
|\ \ | |/
| * Cleanup - remove unused variables and functions after MDEV-18917Vladislav Vaintroub2019-03-152-31/+0
| |
* | Remove unused variables from non-debug buildMarko Mäkelä2019-03-211-5/+5
| |
* | Mariabackup: Ensure NUL termination in strncpy()Marko Mäkelä2019-03-212-5/+9
| |
* | post-merge: gcc 8 warningsSergei Golubchik2019-03-152-23/+0
| | | | | | | | | | | | | | note: Inherit String from Sql_alloc, to get operators new and new[] in sync in rocksdb gcc was complaining that non-lvalue was cast to const.
* | Merge branch '10.1' into 10.2Sergei Golubchik2019-03-153-39/+4
|\ \ | |/
| * MDEV-18917 Don't create xtrabackup_binlog_pos_innodb with MariabackupVladislav Vaintroub2019-03-153-36/+4
| |
* | Merge 10.1 into 10.2Marko Mäkelä2019-03-082-3/+22
|\ \ | |/
| * MDEV-18855 Mariabackup should fetch innodb_compression_level from running serverThirunarayanan Balathandayuthapani2019-03-082-3/+23
| | | | | | | | | | | | | | - Fetch innodb_compression_level from the running server.Add the value of innodb_compression_level in backup-my.cnf file during backup phase. So that prepare can use the innodb_compression_level variable from backup-my.cnf
* | Merge 10.1 into 10.2Marko Mäkelä2019-03-064-11/+18
|\ \ | |/
| * MDEV-18659: Fix string truncation/overflow in InnoDB and XtraDBMarko Mäkelä2019-03-064-14/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix the warnings issued by GCC 8 -Wstringop-truncation and -Wstringop-overflow in InnoDB and XtraDB. This work is motivated by Jan Lindström. The patch mainly differs from his original one as follows: (1) We remove explicit initialization of stack-allocated string buffers. The minimum amount of initialization that is needed is a terminating NUL character. (2) GCC issues a warning for invoking strncpy(dest, src, sizeof dest) because if strlen(src) >= sizeof dest, there would be no terminating NUL byte in dest. We avoid this problem by invoking strncpy() with a limit that is 1 less than the buffer size, and by always writing NUL to the last byte of the buffer. (3) We replace strncpy() with memcpy() or strcpy() in those cases when the result is functionally equivalent. Note: fts_fetch_index_words() never deals with len==UNIV_SQL_NULL. This was enforced by an assertion that limits the maximum length to FTS_MAX_WORD_LEN. Also, the encoding that InnoDB uses for the compressed fulltext index is not byte-order agnostic, that is, InnoDB data files that use FULLTEXT INDEX are not portable between big-endian and little-endian systems.
| * Revert "MDEV-18575 Cleanup : remove innodb-encrypt-log parameter from ↵Vladislav Vaintroub2019-02-201-0/+5
| | | | | | | | | | | | | | mariabackup" This reverts commit 3262967008bf2c2978bbf97960a3ea168fec9c26. It was checked in by mistake
| * MDEV-18575 Cleanup : remove innodb-encrypt-log parameter from mariabackupVladislav Vaintroub2019-02-141-5/+0
| |
* | MDEV-18669 mariabackup writes timestamp in version lineVladislav Vaintroub2019-02-211-1/+1
| | | | | | | | Use fprintf(stderr) instead of msg() to print the version line
* | MDEV-18611: mariabackup silently ended during xtrabackup_copy_logfile()Marko Mäkelä2019-02-191-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | log_group_read_log_seg(): Always return false when returning before reading end_lsn. xtrabackup_copy_logfile(): On error, indicate whether a corrupt log record was encountered. Only xtrabackup_copy_logfile() in Mariabackup cared about the return value of the function. InnoDB crash recovery was not affected by this bug.
* | MDEV-18204 - fixupVladislav Vaintroub2019-02-191-11/+11
| |
* | MDEV-18204 Fix rocksdb incremental backupVladislav Vaintroub2019-02-181-0/+13
| | | | | | | | | | Fix incremental prepare to copy #rocksdb subdirectory from the incremental dir.
* | MDEV-18575 remove innodb-encrypt-log parameter from mariabackupVladislav Vaintroub2019-02-141-5/+0
| | | | | | | | | | | | | | | | | | The variable is obsolete. In mariabackup --backup, encryption plugin loading code sets the value this parameter to the same as in server. In mariabackup --prepare, no new redo log is generated, and xtrabackup_logfile is removed after it anyway.
* | Merge 10.1 into 10.2Marko Mäkelä2019-02-021-18/+16
|\ \ | |/
| * mariabackup : Remove unused parameter innodb_buffer_pool_sizeVladislav Vaintroub2019-01-301-15/+0
| |
| * MDEV-18347: mariabackup doesn't read all server option groups from ↵Geoff Montee2019-01-241-4/+16
| | | | | | | | configuration files
* | MDEV-18380 : adjust max_statement_time in mariabackupVladislav Vaintroub2019-02-011-1/+1
| |
* | MDEV-18415 mariabackup.mdev-14447 test case fails with Table 'test.t' ↵Thirunarayanan Balathandayuthapani2019-02-011-4/+11
| | | | | | | | | | | | | | doesn't exist in engine - Added retry logic if validation of first page fails with checksum mismatch.
* | MDEV-18356 Renamed backup-encrypted option introduced in ↵Vladislav Vaintroub2019-01-233-8/+8
| | | | | | | | | | | | 7158edcba3af3766e9329f9927ce4adfd2a40bf8 Rename it because it caused parser warning whenever --backup was used.
* | mariabackup : use die() macro for fatal exit with error message.Vladislav Vaintroub2019-01-169-90/+63
| |
* | MDEV-18212 mariabackup: Make output format uniform whenever possibleVladislav Vaintroub2019-01-1522-476/+407
| |
* | Merge 10.1 into 10.2Marko Mäkelä2019-01-141-0/+2
|\ \ | |/
| * xb_process_datadir(): Fix resource leaksFaramosCZ2019-01-141-0/+2
| | | | | | | | Closes #983, #984
* | MDEV-18201 : mariabackup- fix processing of rename/create sequence in prepareVladislav Vaintroub2019-01-101-5/+8
| | | | | | | | | | | | | | | | | | Fix one more bug in "DDL redo" phase in prepare If table was renamed, and then new table was created with the old name, prepare can be confused, and .ibd can end up with wrong name. Fix the order of how DDL fixup is applied , once again - ".new" files should be processed after renames.
* | MDEV-18185 - mariabackup - fix specific case of table rename handing in prepare.Vladislav Vaintroub2019-01-091-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | If, during backup 1) Innodb table is dropped (after being copied to backup) and then 2) Before backup finished, another Innodb table is renamed, and new name is the name of the dropped table in 1) then, --prepare fails with assertion, as DDL fixup code in prepare did not handle this specific case. The fix is to process drops before renames, in prepare DDL-"redo" phase.
* | Fix a merge error in the parent commitMarko Mäkelä2019-01-041-2/+2
| | | | | | | | | | Fix an inadvertently inverted condition that caused galera.galera_sst_mariabackup_table_options test failure.
* | Merge 10.1 into 10.2Marko Mäkelä2019-01-033-9/+28
|\ \ | |/
| * MDEV-18129 Backup fails for encrypted tables: mariabackup: Database page ↵Marko Mäkelä2019-01-033-8/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | corruption detected at page 1 If an encrypted table is created during backup, then mariabackup --backup could wrongly fail. This caused a failure of the test mariabackup.huge_lsn once on buildbot. This is due to the way how InnoDB creates .ibd files. It would first write a dummy page 0 with no encryption information. Due to this, xb_fil_cur_open() could wrongly interpret that the table is not encrypted. Subsequently, page_is_corrupted() would compare the computed page checksum to the wrong checksum. (There are both "before" and "after" checksums for encrypted pages.) To work around this problem, we introduce a Boolean option --backup-encrypted that is enabled by default. With this option, Mariabackup will assume that a nonzero key_version implies that the page is encrypted. We need this option in order to be able to copy encrypted tables from MariaDB 10.1 or 10.2, because unencrypted pages that were originally created before MySQL 5.1.48 could contain nonzero garbage in the fields that were repurposed for encryption. Later, MDEV-18128 would clean up the way how .ibd files are created, to remove the need for this option. page_is_corrupted(): Add missing const qualifiers, and do not check space->crypt_data unless --skip-backup-encrypted has been specified. xb_fil_cur_read(): After a failed page read, output a page dump.
* | Merge 10.1 into 10.2Marko Mäkelä2018-12-291-4/+10
|\ \ | |/
| * MDEV-18105 Mariabackup fails to copy encrypted InnoDB system tablespace if ↵Marko Mäkelä2018-12-291-3/+10
| | | | | | | | | | | | | | | | | | | | LSN>4G This is a regression caused by commit 8c43f963882a9d5ac4e4289c8dd3dbcaeb40a0ce that was part of the MDEV-12112 fixes. page_is_corrupted(): Never interpret page_no=0 as encrypted.
* | Merge 10.1 into 10.2Marko Mäkelä2018-12-291-0/+9
|\ \ | |/
| * Silence LeakSanitizer by default in mariabackup, so that phanthom "leaks"Vladislav Vaintroub2018-12-291-0/+9
| | | | | | | | | | | | | | | | | | | | | | would not hide more interesting information, like invalid memory accesses. some "leaks" are expected - partly this is due to weird options parsing, that runs twice, and does not free memory after the first run. - also we do not mind to exit() whenever it makes sense, without full cleanup.
* | Add test for partial backup for partitioned table.Vladislav Vaintroub2018-12-211-8/+15
| |
* | Merge 10.1 into 10.2Marko Mäkelä2018-12-213-96/+121
|\ \ | |/
| * Cleanup recent mariabackup validation patches.Vladislav Vaintroub2018-12-203-73/+93
| | | | | | | | | | | | | | | | | | | | | | - Refactor code to isolate page validation in page_is_corrupted() function. - Introduce --extended-validation parameter(default OFF) for mariabackup --backup to enable decryption of encrypted uncompressed pages during backup. - mariabackup would still always check checksum on encrypted data, it is needed to detect partially written pages.
* | Merge 10.1 into 10.2Marko Mäkelä2018-12-191-14/+36
|\ \ | |/
| * MDEV-18025: Improve test case and consistency checksMarko Mäkelä2018-12-191-8/+30
| | | | | | | | | | | | | | | | | | | | | | | | Write a test case that computes valid crc32 checksums for an encrypted page, but zeroes out the payload area, so that the checksum after decryption fails. xb_fil_cur_read(): Validate the page number before trying any checksum calculation or decrypting or decompression. Also, skip zero-filled pages. For page_compressed pages, ensure that the FIL_PAGE_TYPE was changed. Also, reject FIL_PAGE_PAGE_COMPRESSED_ENCRYPTED if no decryption was attempted.
* | MDEV-16268 : sporadic checksum mismatch when opening system tablespace in backupVladislav Vaintroub2018-12-181-2/+9
| | | | | | | | | | Attempt to fix by retrying srv_sys_space.open_or_create() if it reports corruption.
* | Merge 10.1 into 10.2Marko Mäkelä2018-12-181-1/+24
|\ \ | |/
View Lorry Controller Status