summaryrefslogtreecommitdiff
path: root/extra
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch '10.2' into 10.3Sergei Golubchik2018-08-121-1/+1
|\
| * compiler warningSergei Golubchik2018-08-091-1/+1
| | | | | | | | warning: suggest a space before ‘;’ or explicit braces around empty body in ‘for’ statement
* | remove obsolete checks for -fno-implicit-templatesSergei Golubchik2018-08-121-3/+0
| | | | | | | | we stopped using -fno-implicit-templates many years ago
* | remove warning on WindowsVladislav Vaintroub2018-08-051-4/+1
| | | | | | | | Replace do-it-yourself version of strdup() with real strdup().
* | Merge 10.2 into 10.3Marko Mäkelä2018-08-033-14/+40
|\ \ | |/
| * mariabackup: Use snprintf() instead of sprintf()Marko Mäkelä2018-08-031-1/+1
| |
| * Merge 10.1 into 10.2Marko Mäkelä2018-08-032-5/+17
| |\
| | * Fix -Wclass-memaccess in WSREP,InnoDB,XtraDBMarko Mäkelä2018-08-032-5/+17
| | |
| * | Merge 10.1 into 10.2Marko Mäkelä2018-08-021-8/+22
| |\ \ | | |/
| | * Adopt Debian's fix-FTBFS-on-GNU-Hurd.patch.Sergei Petrunia2018-06-291-8/+22
| | | | | | | | | | | | | | | | | | | | | - Took the original patch by Ondrej Sury; - Applied a fix for a known problem in the patch: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=882062 - Fixed a few other issues
* | | Don't give warnings from perror or resolveip with safemallocMichael Widenius2018-07-292-4/+21
| | | | | | | | | | | | | | | - Added my_end(0) before exit - Fixed typo in mysql_install_db
* | | Merge branch '10.2' into 10.3Sergei Golubchik2018-06-302-8/+26
|\ \ \ | |/ /
| * | mariabackup - rename backup-rocksdb option to rocksdb-backupVladislav Vaintroub2018-06-221-1/+1
| | | | | | | | | | | | | | | to avoid "using unique option prefix 'backup' is error-prone", there is already --backup option there.
| * | MDEV-16519 : mariabackup should fail if MDL could not be acquired with ↵Vladislav Vaintroub2018-06-221-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | lock-ddl-per-table There is a tiny chance for race condition during MDL acquisition. If table is renamed just prior to SELECT 1 FROM <table_name> LIMIT 0 then this query would fail, yet mariabackup --backup does not handle it as fatal error and continues, only to fail later during file copy. The fix is to die on error, of MDL lock query fails.
| * | MDEV-16496 Mariabackup: Implement --verbose option to instrument InnoDB log ↵Marko Mäkelä2018-06-151-2/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | apply srv_print_verbose_log: Introduce the value 2 to refer to mariabackup --verbose. recv_recover_page(), recv_parse_log_recs(): Add output for mariabackup --verbose.
| * | Follow-up to MDEV-16367 mariabackup: error: failed to copy enough redo logMarko Mäkelä2018-06-151-4/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit dc9c555415b1d37b713839b9f8143a053f402c0e moved the final phase of the redo log copying to the background thread. This would sometimes cause too little redo log to be copied at the end of the backup. We would only guarantee copying up to the latest redo log checkpoint. This would produce a consistent backup, but it could refer to a too old point of time. xtrabackup_copy_log(), xtrabackup_copy_logfile(): Add the parameter 'last'. xtrabackup_backup_low(): Copy any remaining part of the log after the backup threads have terminated.
* | | Merge 10.2 into 10.3Marko Mäkelä2018-06-183-4/+291
|\ \ \ | |/ /
| * | MDEV-16457 mariabackup 10.2+ should default to innodb_checksum_algorithm=crc32Marko Mäkelä2018-06-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since MariaDB Server 10.2.2 (and MySQL 5.7), the default value of innodb_checksum_algorithm is crc32 (CRC-32C), not the inefficient "innodb" checksum. Change Mariabackup to use the same default, so that checksum validation (when using the default algorithm on the server) will take less time during mariabackup --backup. Also, mariabackup --prepare should be a little faster, and the server should read backups faster, because the page checksums would only be validated against CRC-32C.
| * | MDEV-13122 Backup myrocksdb with mariabackup.Vladislav Vaintroub2018-06-073-3/+289
| | |
* | | Merge 10.2 into 10.3Marko Mäkelä2018-06-073-60/+58
|\ \ \ | |/ /
| * | MDEV-16367 mariabackup: error: failed to copy enough redo logMarko Mäkelä2018-06-071-57/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | log_copying_thread(): Keep copying redo log until the end has been reached. (Previously, we would stop copying as soon as the first batch of xtrabackup_copy_logfile() returned.) log_copying: Remove. Use log_copying_running instead. copy_logfile: Remove. Log copying will now only be invoked from 2 places: from xtrabackup_backup_func() for the initial batch, and from log_copying_thread() until all of the log has been read. Use the global variable metadata_to_lsn for determining if the final part of the log is being copied. xtrabackup_copy_log(): Add diagnostic messages for terminating the copying. These messages should be dead code, because log_group_read_log_seg() should be checking for the same. xtrabackup_copy_logfile(): Correct the retrying logic. If anything was successfully read, process the portion that was read. On failure, let the caller close dst_log_file. io_watching_thread(): Stop throttling during the last phase of copying the log (metadata_to_lsn!=0). The final copying of the log will now be performed in log_copying_thread(). stop_backup_threads(): Clean up the message about stopping the log copying thread. xtrabackup_backup_low(): Read metadata_to_lsn from the latest checkpoint header page, even if it is the first page. Let the log_copying_thread take care of copying all of the redo log.
| * | Mariabackup: Make some globals staticMarko Mäkelä2018-06-073-4/+3
| | |
* | | Make MariaDB CRC32-lib platform independence (#780)Yuqi2018-06-011-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make mariadb crc32 lib platform independent It looks strange that someone can make use of 2 crc libraries (Power64 or AArch64) at the same time. The patch sets macros 'CRC32_LIBRARY' to make platform independence as an optional crc32 library. Change-Id: I68bbf73cafb6a12f7fb105ad57d117b114a8c4af Signed-off-by: Yuqi Gu <yuqi.gu@arm.com>
* | | Merge branch 'github/10.2' into 10.3Sergei Golubchik2018-05-221-4/+11
|\ \ \ | |/ /
| * | mariabackup : Fix race condition when killing query waiting for MDLVladislav Vaintroub2018-05-191-4/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Itcan happen that the connection is already gone during the window between quering I_S.PROCESSLIST and KILL QUERY. Fix is to tolerate ER_NO_SUCH_THREAD returned from KILL QUERY. Add small improvement in message "Killing MDL query " to actually output the query. Also do not try to kill queries that are already in Killed state.
* | | cleanup: create_temp_file()Sergei Golubchik2018-05-212-17/+3
| | | | | | | | | | | | | | | | | | simplify. move common code inside, specify common flags inside, rewrite dead code (`if (mode & O_TEMPORARY)` on Linux, where `O_TEMPORARY` is always 0) to actually do something.
* | | Merge branch '10.2' into 10.3Sergei Golubchik2018-05-113-9/+11
|\ \ \ | |/ /
| * | Merge branch '10.1' into 10.2Sergei Golubchik2018-05-103-9/+11
| |\ \ | | |/
| | * MDEV-16105: Mariabackup does not support SSLVladislav Vaintroub2018-05-083-9/+11
| | | | | | | | | | | | The reason is the missing HAVE_OPENSSL define for mariabackup.
* | | Power8: use C implementation of crc32 instead of ASMDaniel Black2018-05-0712-2661/+3174
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Compiles to same vector code, just a bit simplier. vec_crc32.c is now identical to upstream (https://github.com/antonblanchard/crc32-vpmsum/). C code by Rogerio Alves <rogealve@br.ibm.com> This implemention has been tested on big endian too. Signed-off-by: Daniel Black <daniel@linux.ibm.com>
* | | MDEV-12218: Put back mariabackup --innodb-flush-methodMarko Mäkelä2018-04-304-32/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Implement innodb_flush_method as an enum parameter in Mariabackup, instead of ignoring the option and hard-wiring it to a default value. xb0xb.h: Remove. Only xtrabackup.cc refers to the enum parameters. innodb_flush_method_names[], innodb_flush_method_typelib[]: Define as non-static, so that mariabackup can share the definitions. srv_file_flush_method: Change the type to ulong, to match the assignment in init_one_value() and handle_options() in mariabackup.
* | | MDEV-16045: Replace log_group_t with log_t::filesMarko Mäkelä2018-04-291-4/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There is only one log_sys and only one log_sys.log. log_t::files::create(): Replaces log_init(). log_t::files::close(): Replaces log_group_close(), log_group_close_all(). fil_close_log_files(): if (free) log_sys.log_close(); The callers that passed free=true used to call log_group_close_all(). log_header_read(): Replaces log_group_header_read(). log_t::files::file_header_bufs_ptr: Use a single allocation. log_t::files::file_header_bufs[]: Statically allocate the pointers. log_t::files::set_fields(): Replaces log_group_set_fields(). log_t::files::calc_lsn_offset(): Replaces log_group_calc_lsn_offset(). Simplify the computation by using fewer variables. log_t::files::read_log_seg(): Replaces log_group_read_log_seg(). log_sys_t::complete_checkpoint(): Replaces log_io_complete_checkpoint(). fil_aio_wait(): Move the logic from log_io_complete().
* | | MDEV-16045: Allocate log_sys staticallyMarko Mäkelä2018-04-291-20/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There is only one redo log subsystem in InnoDB. Allocate the object statically, to avoid unnecessary dereferencing of the pointer. log_t::create(): Renamed from log_sys_init(). log_t::close(): Renamed from log_shutdown(). log_t::checkpoint_buf_ptr: Remove. Allocate log_t::checkpoint_buf statically.
* | | MDEV-12218 Clean up InnoDB parameter validationMarko Mäkelä2018-04-294-97/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bind more InnoDB parameters directly to MYSQL_SYSVAR and remove "shadow variables". innodb_change_buffering: Declare as ENUM, not STRING. innodb_flush_method: Declare as ENUM, not STRING. innodb_log_buffer_size: Bind directly to srv_log_buffer_size, without rounding it to a multiple of innodb_page_size. LOG_BUFFER_SIZE: Remove. SysTablespace::normalize_size(): Renamed from normalize(). innodb_init_params(): A new function to initialize and validate InnoDB startup parameters. innodb_init(): Renamed from innobase_init(). Invoke innodb_init_params() before actually trying to start up InnoDB. srv_start(bool): Renamed from innobase_start_or_create_for_mysql(). Added the input parameter create_new_db. SRV_ALL_O_DIRECT_FSYNC: Define only for _WIN32. xb_normalize_init_values(): Merge to innodb_init_param().
* | | Do not divide or multiply by srv_page_sizeMarko Mäkelä2018-04-282-18/+19
| | | | | | | | | | | | Instead, shift by srv_page_size_shift.
* | | Replace univ_page_size and UNIV_PAGE_SIZEMarko Mäkelä2018-04-282-15/+16
| | | | | | | | | | | | | | | | | | Try to use one variable (srv_page_size) for innodb_page_size. Also, replace UNIV_PAGE_SIZE_SHIFT with srv_page_size_shift.
* | | Fix a lot of compiler warnings found by -WunusedMonty2018-04-261-1/+1
| | |
* | | Merge 10.2 into 10.3Marko Mäkelä2018-04-241-1/+1
|\ \ \ | |/ /
| * | Merge 10.1 into 10.2Marko Mäkelä2018-04-241-1/+1
| |\ \ | | |/
| | * MDEV-15988 Crash in ./mtr mariabackup.undo_space_idMarko Mäkelä2018-04-241-2/+2
| | | | | | | | | | | | | | | xb_assign_undo_space_start(): Correctly pass the length of the buffer, so that the file name will not be truncated.
* | | MDEV-12266 follow-up fix to MariabackupMarko Mäkelä2018-04-231-2/+1
| | | | | | | | | | | | xtrabackup_apply_delta(): Refer to fil_system.sys_space directly.
* | | Merge 10.2 into 10.3Marko Mäkelä2018-04-233-8/+51
|\ \ \ | |/ /
| * | Merge 10.1 into 10.2Marko Mäkelä2018-04-213-8/+51
| |\ \ | | |/
| | * MDEV-15779 - mariabackup incremental prepare fails on CIFS mount.Vladislav Vaintroub2018-04-121-4/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | CIFS does not like O_DIRECT flag (it is set successfully, but pread would fail). The fix is not to use O_DIRECT, there is not need for it. posix_fadvise() was used already that should prevent buffer cache pollution on Linux. As recommended by documentation of posix_fadvise(), we'll also fsync() tablespaces after a batch of writes.
| | * MDEV-15780 : Mariabackup with absolute paths in innodb_data_file_pathVladislav Vaintroub2018-04-122-4/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | System tablespace can be specified with absolute path, if innodb_data_home_dir is empty. This was not handled well by mariabackup 1. In backup phase, empty innodb_data_home_dir variable from server was not recognized. full paths were stored in backup-my.ini, even if it stored all files locally. thus prepare phase would not find the system tablespace files. 2. In copy-back phase, copy would not be done to the absolute destination path, as path would be stripped with trim_dotslash This patch fixes the above defects.
* | | Remove compiler warningsMichael Widenius2018-04-161-1/+1
| | | | | | | | | | | | | | | | | | | | | - Remove unused variables - Mark variables unused - Fix wrong types - Add no-strict-aliasing to BUILD scripts
* | | Merge remote-tracking branch '10.2' into 10.3Vicențiu Ciorbaru2018-04-124-3/+19
|\ \ \ | |/ /
| * | MDEV-15780 : mariabackup does not handle absolute names in for system ↵Vladislav Vaintroub2018-04-111-1/+2
| | | | | | | | | | | | | | | | | | | | | tablespaces Fix 10.2-specific bug - copy-back is not prepared to handle system tablespaces with absolute path.
| * | Merge branch '10.1' into 10.2Vicențiu Ciorbaru2018-04-102-2/+6
| |\ \ | | |/
| | * MDEV-15713 mariabackup: throw warning, if --stream is used without --backupVladislav Vaintroub2018-04-091-0/+4
| | |