summaryrefslogtreecommitdiff
path: root/extra
Commit message (Collapse)AuthorAgeFilesLines
* Merge 10.2 into 10.3Marko Mäkelä2019-12-121-33/+9
|\
| * MDEV-21255: Deadlock of parallel slave and mariabackup (with failed logVlad Lesin2019-12-121-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | copy thread) mariabackup hangs waiting until innodb redo log thread read log till certain LSN, and it waits under FTWRL. If there is redo log read error in the thread, it is finished, and main thread knows nothing about it, what leads to hanging. As it hangs under FTWRL, slave threads on server side can be blocked due to MDL lock conflict. The fix is to finish mariabackup with error message on innodb redo log read failure.
| * MDEV-11345 Compile english error messages into mysqld executable.Vladislav Vaintroub2019-12-111-32/+6
| | | | | | | | | | Simplify loading messages into mariabackup. Do the same as server does We're forcing english, so there is no attempt to load errmsg.sys
* | Merge remote-tracking branch 10.2 into 10.3Jan Lindström2019-12-021-11/+20
|\ \ | |/ | | | | | | | | | | | | | | Conflicts: mysql-test/suite/galera/t/galera_binlog_event_max_size_max-master.opt mysql-test/suite/innodb/r/innodb-mdev-7513.result mysql-test/suite/innodb/t/innodb-mdev-7513.test mysql-test/suite/wsrep/disabled.def storage/innobase/ibuf/ibuf0ibuf.cc
| * MDEV-18310: Aria engine: Undo phase failed with "Got error 121 whenVlad Lesin2019-11-291-11/+20
| | | | | | | | | | | | | | | | executing undo undo_key_delete" upon startup on datadir restored from incremental backup aria_log* files were not copied on --prepare --incremental-dir step from incremental to destination backup directory.
* | Lintian complains on spelling errorFaustin Lammler2019-12-026-10/+10
| | | | | | | | | | The lintian check complains on spelling error: https://salsa.debian.org/mariadb-team/mariadb-10.3/-/jobs/95739
* | Merge 10.2 into 10.3Marko Mäkelä2019-11-062-2/+2
|\ \ | |/
| * Merge 10.1 to 10.2Marko Mäkelä2019-11-062-2/+2
| |\
| | * Fix GCC 9.2.1 -Wstringop-truncationMarko Mäkelä2019-11-043-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | dict_table_rename_in_cache(): Use strcpy() instead of strncpy(), because they are known to be equivalent in this case (the length of old_name was already validated). mariabackup: Invoke strncpy() with one less than the buffer size, and explicitly add NUL as the last byte of the buffer.
* | | compilation failure on ppc with -DCMAKE_BUILD_TYPE=DebugSergei Golubchik2019-10-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | if ${CRC32_LIBRARY} target has no COMPILE_FLAGS yet, GET_TARGET_PROPERTY returns COMPILE_FLAGS-NOTFOUND, which doesn't work very well when it's later fed back into COMPILE_FLAGS. GET_PROPERTY() returns an empty string in this case. Cherry-picked from 10.4 - 13e8f728ec83133b990ed21404cbac1d8a0bc74c Signed-off-by: Vicențiu Ciorbaru <vicentiu@mariadb.org>
* | | Merge 10.2 into 10.3Marko Mäkelä2019-10-092-5/+5
|\ \ \ | |/ /
| * | MDEV-19335 Remove buf_page_t::encryptedThirunarayanan Balathandayuthapani2019-10-091-3/+1
| | | | | | | | | | | | | | | The field buf_page_t::encrypted was added in MDEV-8588. It was made mostly redundant in MDEV-12699. Remove the field.
| * | MDEV-20703: mariabackup creates binlog files in server binlog directory on ↵Vlad Lesin2019-10-011-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | --prepare --export step When "--export" mariabackup option is used, mariabackup starts the server in bootstrap mode to generate *.cfg files for the certain innodb tables. The started instance of the server reads options from the file, pointed out in "--defaults-file" mariabackup option. If the server uses the same config file as mariabackup, and binlog is switched on in that config file, then "mariabackup --prepare --export" will create binary log files in the server's binary log directory, what can cause issues. The fix is to add "--skip-log-bin" in mysld options when the server is started to generate *.cfg files.
* | | Merge 10.2 into 10.3Marko Mäkelä2019-09-234-10/+41
|\ \ \ | |/ /
| * | MDEV-18438 Don't stream xtrabackup_info of extra-lsndirSimon Lipp2019-09-194-10/+41
| | |
* | | Merge 10.2 into 10.3Marko Mäkelä2019-08-151-8/+3
|\ \ \ | |/ /
| * | MDEV-19740: Silence a bogus "may be uninitialized" warningMarko Mäkelä2019-08-151-8/+3
| | |
* | | Merge 10.2 to 10.3Marko Mäkelä2019-08-132-2/+3
|\ \ \ | |/ /
| * | Merge 10.1 into 10.2Marko Mäkelä2019-08-121-1/+2
| |\ \ | | |/
| | * MDEV-17638 Improve error message about corruption of encrypted pagebb-10.1-MDEV-17638-improve-warningEugene Kosov2019-08-011-1/+2
| | | | | | | | | | | | Help user distinguish between space ID and page number.
| * | MDEV-20060: Failing assertion: srv_log_file_size <= 512ULL << 30 while ↵Vlad Lesin2019-08-071-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | preparing backup The general reason why innodb redo log file is limited by 512G is that log_block_convert_lsn_to_no() returns value limited by 1G. But there is no need to have unique log block numbers in log group. The fix removes 512G limit and limits log group size by (uint32_t maximum value) * (minimum page size), which, in turns, can be removed if fil_io() is no longer used for innodb redo log io.
* | | Merge 10.2 into 10.3Eugene Kosov2019-07-161-1/+1
|\ \ \ | |/ /
| * | Merge 10.1 into 10.2Eugene Kosov2019-07-091-1/+1
| |\ \ | | |/
| | * imporve clang buildEugene Kosov2019-06-253-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | cmake -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_BUILD_TYPE=Debug Maintainer mode makes all warnings errors. This patch fix warnings. Mostly about deprecated `register` keyword. Too much warnings came from Mroonga and I gave up on it.
* | | Merge 10.2 into 10.3Marko Mäkelä2019-07-022-14/+89
|\ \ \ | |/ /
| * | MDEV-19781 Add page id matching check in innochecksum toolThirunarayanan Balathandayuthapani2019-06-281-13/+88
| | | | | | | | | | | | | | | | | | | | | | | | Added the condition in innochecksum tool to check page id mismatch. This could catch the write corruption caused by InnoDB. Added the debug insert inside fil_io() to check whether it writes the page to wrong offset.
| * | MDEV-19865: AddressSanitizer error in open_or_create_log_file() in mariabackupVlad Lesin2019-06-261-1/+1
| | | | | | | | | | | | Decrease array on stack in open_or_create_log_file() to avoid stack overflow.
* | | Merge 10.2 into 10.3Marko Mäkelä2019-06-111-1/+5
|\ \ \ | |/ /
| * | Fixed compiler warningMonty2019-06-031-1/+5
| | | | | | | | | | | | | | | | | | Wrong compiler warning from GCC: ‘snprintf’ output 2 or more bytes (assuming 4001) into a destination of size 4000
* | | Merge 10.2 into 10.3Marko Mäkelä2019-05-291-32/+32
|\ \ \ | |/ /
| * | MDEV-14192: mariabackup.incremental_backup failed in buildbot with Failing ↵Vlad Lesin2019-05-241-33/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | assertion: byte_offset % OS_FILE_LOG_BLOCK_SIZE == 0 In some cases it's possible that InnoDB redo log file header is re-written so, that checkpoint lsn and checkpoint lsn offset are updated, but checkpoint number stays the same. The fix is to re-read redo log header if at least one of those three parametes is changed at backup start. Repeat the logic of log_group_checkpoint() on choosing InnoDB checkpoint info field on backup start. This does not influence backup correctness, but simplifies bugs analysis.
* | | Merge 10.2 into 10.3Marko Mäkelä2019-05-14250-263/+263
|\ \ \ | |/ /
| * | Merge 10.1 into 10.2Marko Mäkelä2019-05-13251-264/+264
| |\ \ | | |/
| | * Merge branch '5.5' into 10.1Vicențiu Ciorbaru2019-05-11251-255/+255
| | |\
| | | * Update FSF AddressVicențiu Ciorbaru2019-05-11147-149/+149
| | | | | | | | | | | | | | | | * Update wrong zip-code
| | * | Update FSF addressVicențiu Ciorbaru2019-05-115-9/+9
| | | |
* | | | Merge 10.2 into 10.3Marko Mäkelä2019-05-032-1/+74
|\ \ \ \ | |/ / /
| * | | MDEV-17008 prepare with datadir, on Windows, does not set ACLVladislav Vaintroub2019-05-021-1/+67
| | | | | | | | | | | | | | | | | | | | | | | | | | | | on tablespace files Fix is to always add Full Control for NetworkService account, for every file that copyback/moveback copies around.
| * | | MDEV-18544 "missing required privilege PROCESS on *.*" using mariabackup for SSTVladislav Vaintroub2019-05-021-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | If required privilege is missing, dump the output from "SHOW GRANTS" into mariabackup log. This will help troubleshooting, and make the bug reproducible.
* | | | Merge 10.2 into 10.3Marko Mäkelä2019-04-292-4/+5
|\ \ \ \ | |/ / /
| * | | MDEV-14130 InnoDB messages should not refer to the MySQL 5.7 manualMarko Mäkelä2019-04-291-3/+4
| | | | | | | | | | | | | | | | | | | | In InnoDB error messages, replace the hyperlink URLs to point to the MariaDB knowledge base.
| * | | Fix a typoVladislav Vaintroub2019-04-291-1/+1
| | | |
* | | | Merge 10.2 into 10.3Marko Mäkelä2019-04-274-14/+14
|\ \ \ \ | |/ / /
| * | | MDEV-19231 make DB_SUCCESS equal to 0Eugene Kosov2019-04-254-12/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's a micro optimization. On most platforms CPUs has instructions to compare with 0 fast. DB_SUCCESS is the most popular outcome of functions and this patch optimized code like (err == DB_SUCCESS) BtrBulk::finish(): bogus assertion fixed fil_node_t::read_page0(): corrected usage of os_file_read() que_eval_sql(): bugus assertion removed. Apparently it checked that the field was assigned after having been zero-initialized at object creation. It turns out that the return type of os_file_read_func() was changed in mysql/mysql-server@98909cefbc37e54efc6452c7e95bccbf64ac9213 (MySQL 5.7) from ibool to dberr_t. The reviewer (if there was any) failed to point out that because of future merges, it could be a bad idea to change the return type of a function without changing the function name. This change was applied to MariaDB 10.2.2 in commit 2e814d4702d71a04388386a9f591d14a35980bfe but the MariaDB-specific code was not fully adjusted accordingly, e.g. in fil_node_open_file(). Essentially, code like !os_file_read(...) became dead code in MariaDB and later in Mariabackup 10.2, and we could be dealing with an uninitialized buffer after a failed page read.
* | | | Merge 10.2 into 10.3Marko Mäkelä2019-04-251-3/+1
|\ \ \ \ | |/ / /
| * | | Do fast exit with error code and FATAL ERROR message, if innodb cannot start ↵Vladislav Vaintroub2019-04-231-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | during prepare. Otherwise, it is possible for "prepare" to exit with error code 0, even if it did not work at all.
* | | | MDEV-14192: Add debug assertionsVlad Lesin2019-04-081-2/+2
| | | |
* | | | Merge 10.2 into 10.3Marko Mäkelä2019-04-081-25/+11
|\ \ \ \ | |/ / /
| * | | MDEV-19212 4GB Limit on large_pages - integer overflowMarko Mäkelä2019-04-081-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | os_mem_alloc_large(): Invoke the macro ut_2pow_round() with the correct argument type. innobase_large_page_size, innobase_use_large_pages, os_use_large_pages, os_large_page_size: Remove. Simply refer to opt_large_page_size, my_use_large_pages.
| * | | MDEV-14192 Mariabackup assertion failure: byte_offset % ↵Vlad Lesin2019-04-081-20/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | OS_FILE_LOG_BLOCK_SIZE == 0 xtrabackup_backup_func(): If the log checkpoint header changed since we last read it, search for the most recent checkpoint again. Otherwise, we could corrupt the backup of the redo log, because the least significant bits of checkpoint_lsn_start would not match log_sys->log.lsn.