summaryrefslogtreecommitdiff
path: root/include/atomic
Commit message (Collapse)AuthorAgeFilesLines
* Bug#56760: my_atomics failures on osx10.5-x86-64bitDavi Arnaut2010-11-301-7/+7
| | | | | | | | | | | | | | | The problem was due to a misuse of GCC asm constraints used to implement a atomic load. On x86_64, the load was implemented as a cmpxchg which implicitly uses the eax register as a source and destination operand, yet the dummy value used for comparison wasn't being properly loaded into eax (and other problems). The core problem is that cmpxchg is unnecessary as a load on x86_64 as there are other simpler instructions such as xadd. Even though, such instructions are only used to have a memory barrier as load and stores are atomic by definition. Hence, the solution is to explicitly issue the required CPU and compiler barriers.
* Bug#52419: x86 assembly based atomic CAS causes test failuresDavi Arnaut2010-09-171-8/+10
| | | | | | | | | | | | | | The problem was that the x86 assembly based atomic CAS (compare and swap) implementation could copy the wrong value to the ebx register, where the cmpxchg8b expects to see part of the "comparand" value. Since the original value in the ebx register is saved in the stack (that is, the push instruction causes the stack pointer to change), a wrong offset could be used if the compiler decides to put the source of the comparand value in the stack. The solution is to copy the comparand value directly from memory. Since the comparand value is 64-bits wide, it is copied in two steps over to the ebx and ecx registers.
* Bug#52261: 64 bit atomic operations do not work on Solaris i386 ..Davi Arnaut2010-07-271-1/+7
| | | | | Workaround a interface problem with the atomic macros that was causing warnings. The correct type is retrieved using typeof if compiling with GCC.
* Bug#22320: my_atomic-t unit test failsDavi Arnaut2010-07-233-22/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug#52261: 64 bit atomic operations do not work on Solaris i386 gcc in debug compilation One of the various problems was that the source operand to CMPXCHG8b was marked as a input/output operand, causing GCC to use the EBX register as the destination register for the CMPXCHG8b instruction. This could lead to crashes as the EBX register is also implicitly used by the instruction, causing the value to be potentially garbaged and a protection fault once the value is used to access a position in memory. Another problem was the lack of proper clobbers for the atomic operations and, also, a discrepancy between the implementations for the Compare and Set operation. The specific problems are described and fixed by Kristian Nielsen patches: Patch: 1 Fix bugs in my_atomic_cas*(val,cmp,new) that *cmp is accessed after CAS succeds. In the gcc builtin implementation, problem was that *cmp was read again after atomic CAS to check if old *val == *cmp; this fails if CAS is successful and another thread modifies *cmp in-between. In the x86-gcc implementation, problem was that *cmp was set also in the case of successful CAS; this means there is a window where it can clobber a value written by another thread after successful CAS. Patch 2: Add a GCC asm "memory" clobber to primitives that imply a memory barrier. This signifies to GCC that any potentially aliased memory must be flushed before the operation, and re-read after the operation, so that read or modification in other threads of such memory values will work as intended. In effect, it makes these primitives work as memory barriers for the compiler as well as the CPU. This is better and more correct than adding "volatile" to variables.
* Fix compiler warnings in my_atomic.hKonstantin Osipov2010-02-191-1/+1
|
* mergedSergei Golubchik2009-12-241-1/+1
|\
| * Force use of c-register in CAS instruction on x86-32 bit architecture, ↵Mikael Ronstrom2009-12-211-1/+1
| | | | | | | | b-register used for push and pop, so don't want to give compile the chance to choose the wrong register
* | fix atomic/solaris.h to conformSergei Golubchik2009-12-232-223/+31
|/ | | remove duplicated boilerplate code
* Increase probability of correct atomics implementation by choosing stable ↵Mikael Ronstrom2009-12-191-0/+1
| | | | implementations first
* Make choices of atomic implementation based on highest stabilityMikael Ronstrom2009-12-191-9/+21
|
* Fixed Solaris Atomics build issuesMikael Ronstrom2009-12-181-1/+2
|
* Added extra checks of 64-bit atomic support on GCC and Solaris, also added ↵Mikael Ronstrom2009-12-181-1/+45
| | | | 64-bit support in solaris.h which was missing
* Fix for Windows atomicsMikael Ronstrom2009-12-161-15/+19
|
* Fixed complex gcc assembler issues with 64-bit operations on 32-bit ↵Mikael Ronstrom2009-12-151-18/+47
| | | | platforms using PIC codes, commented x86-gcc.h a lot more
* Include windows.h in atomics framework for windowsMikael Ronstrom2009-12-151-0/+1
|
* Fixed 64-bit atomics on Win x86 and removed support for 8 and 16-bit atomic ↵Mikael Ronstrom2009-12-151-12/+1
| | | | operations
* Fixed atomic instruction headers for Windows and x86-gccMikael Ronstrom2009-12-152-4/+34
|
* Merge WL#5138 to mysql-next-mrMikael Ronstrom2009-11-272-6/+42
|\
| * Misc cleanupMarc Alff2009-11-171-96/+0
| |
| * WL#2595 kernel-independent atomic operationsMarc Alff2009-11-176-54/+222
| | | | | | | | | | Backport from 6.0.14 to 5.6.0 Original code from Sergei Golubchik
* | WL#5138 merged to mysql-next-mrMikael Ronstrom2009-11-207-150/+207
|\ \ | |/ |/|
| * Backported my_atomic from 6.0-codebase and added support for 64-bit atomics ↵Mikael Ronstrom2009-10-122-14/+49
| | | | | | | | to enable removal of LOCK_thread_count from every query, removed LOCK_thread_count from use in dispatch_command and close of query which is used in every query, now uses atomic increments/decrements instead
| * Moved atomics from 6.0 codebase to prepare for using atomic increments in ↵Mikael Ronstrom2009-10-096-139/+179
| | | | | | | | places where LOCK_thread_count previously was used
* | manual merge: mysql-5.1-rep+2-delivery1 --> mysql-5.1-rpl-mergeLuis Soares2009-10-224-0/+17
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts ========= Text conflict in .bzr-mysql/default.conf Text conflict in libmysqld/CMakeLists.txt Text conflict in libmysqld/Makefile.am Text conflict in mysql-test/collections/default.experimental Text conflict in mysql-test/extra/rpl_tests/rpl_row_sp006.test Text conflict in mysql-test/suite/binlog/r/binlog_tmp_table.result Text conflict in mysql-test/suite/rpl/r/rpl_loaddata.result Text conflict in mysql-test/suite/rpl/r/rpl_loaddata_fatal.result Text conflict in mysql-test/suite/rpl/r/rpl_row_create_table.result Text conflict in mysql-test/suite/rpl/r/rpl_row_sp006_InnoDB.result Text conflict in mysql-test/suite/rpl/r/rpl_stm_log.result Text conflict in mysql-test/suite/rpl_ndb/r/rpl_ndb_circular_simplex.result Text conflict in mysql-test/suite/rpl_ndb/r/rpl_ndb_sp006.result Text conflict in mysql-test/t/mysqlbinlog.test Text conflict in sql/CMakeLists.txt Text conflict in sql/Makefile.am Text conflict in sql/log_event_old.cc Text conflict in sql/rpl_rli.cc Text conflict in sql/slave.cc Text conflict in sql/sql_binlog.cc Text conflict in sql/sql_lex.h 21 conflicts encountered. NOTE ==== mysql-5.1-rpl-merge has been made a mirror of mysql-next-mr: - "mysql-5.1-rpl-merge$ bzr pull ../mysql-next-mr" This is the first cset (merge/...) committed after pulling from mysql-next-mr.
| * WL#5016: Fix header file include guardsMats Kindahl2009-09-234-0/+17
| | | | | | | | Adding header include file guards to files that are missing such.
* | Fix for BUG#45131Mikael Ronstrom2009-06-101-1/+1
| |
* | Added new file solaris.hMikael Ronstrom2008-10-161-0/+210
| |
* | Performance patch: Mysql atomic patchMikael Ronstrom2008-10-131-2/+19
|/
* Bug#33728 Atomic builtinsdavi@mysql.com/endora.local2008-01-112-2/+37
| | | | | | Use compiler provided atomic builtins as a 'backend' for MySQL's atomic primitives. The builtins are available on a handful of platforms and compilers.
* Many files:kent@mysql.com/kent-amd64.(none)2006-12-274-8/+4
| | | | Changed header to GPL version 2 only
* support for xadd emulation, workaround for Darwinserg@serg.mylan2006-06-293-9/+17
|
* atomic ops:serg@serg.mylan2006-06-174-318/+84
| | | | | my_atomic_XX_t -> intXX, no implicit locking anymore simplified framework, support for requested cleanups
* unittest:serg@serg.mylan2006-06-011-0/+3
| | | | | | | | | | | | | rename *.t* to *-t* to be automake-friendly simplify Makefiles test_atomic.c: move to unittest, add GPL comment, fix warnings, convert to tap framework. configure: remove custom tests for available types, use AC_CHECK_TYPE instead x86-gcc.h: fix gcc -ansi errors while maintaining readability ignore: added *-t
* WL#2595 - atomic operationsserg@serg.mylan2006-05-314-0/+471
View Lorry Controller Status