summaryrefslogtreecommitdiff
path: root/storage/innobase
Commit message (Collapse)AuthorAgeFilesLines
...
| | | * MDEV-12353 preparation: Clean up mtr_tMarko Mäkelä2019-11-124-495/+254
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | mtr_t::Impl, mtr_t::Command: Merge to mtr_t. MTR_MAGIC_N: Remove. MTR_STATE_COMMITTING: Remove. This state was only being set internally during mtr_t::commit(). mtr_t::Command::m_locks_released: Remove (set-and-never-read member). mtr_t::Command::m_start_lsn: Replaced with the return value of finish_write() and a parameter to release_blocks(). mtr_t::Command::m_end_lsn: Removed as a duplicate of mtr_t::m_commit_lsn. mtr_t::Command::prepare_write(): Replace a switch () with a comparison against 0. Only 2 m_log_mode are allowed.
| | | * MDEV-14602: Cleanup recv_dblwr_t::find_page()Marko Mäkelä2019-11-121-36/+17
| | | | | | | | | | | | | | | | Avoid creating std::vector, and use single instead of double traversal.
* | | | Merge 10.4 into 10.5Marko Mäkelä2019-11-1119-237/+129
|\ \ \ \ | |/ / /
| * | | MDEV-17138 follow-up: Optimize fseg_create()Marko Mäkelä2019-11-113-15/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fseg_create(): Initialize FSEG_FRAG_ARRY by a single MLOG_MEMSET record. flst_zero_addr(), flst_init(): Optimize away redundant writes. fseg_free_page_low(): Write FIL_NULL by MLOG_MEMSET.
| * | | Merge 10.3 into 10.4Marko Mäkelä2019-11-1117-244/+123
| |\ \ \ | | |/ /
| | * | Merge 10.2 into 10.3Marko Mäkelä2019-11-1118-249/+130
| | |\ \ | | | |/
| | | * MDEV-21024: Cleanup XDES_CLEAN_BITMarko Mäkelä2019-11-111-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | The XDES_CLEAN_BIT is always set for every element of the page allocation bitmap in the extent descriptor pages. Do not bother touching it, to avoid redundant writes.
| | | * MDEV-21024: Clean up dict_hdr_create()Marko Mäkelä2019-11-111-3/+2
| | | | | | | | | | | | | | | | The DICT_HDR_MAX_SPACE_ID was already zero-initialized at page allocation.
| | | * MDEV-21024: Clean up IMPORT TABLESPACEMarko Mäkelä2019-11-115-57/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | page_rec_write_field(): Remove. dict_create_index_tree_step(): If the SYS_INDEXES.PAGE does not change, do not update it in the data dictionary. Typically, all index page numbers would be unchanged before and after IMPORT TABLESPACE, except if some secondary indexes were created after loading some data. btr_root_fseg_adjust_on_import(): Remove the redundant mtr_t* parameter. Redo logging is disabled during the page adjustments that IMPORT TABLESPACE is performing.
| | | * MDEV-21024: Clean up btr_root_raise_and_insert()Marko Mäkelä2019-11-111-7/+1
| | | | | | | | | | | | | | | | | | | | The root page must never have any siblings, so it is unnecessary to clear those fields.
| | | * MDEV-21024: Clean up page allocationMarko Mäkelä2019-11-111-12/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | fsp_alloc_seg_inode_page(): Ever since commit 3926673ce7149aa223103126b6aeac819b10fab5 all newly allocated pages are zero-initialized. Assert that this is the case for the FSEG_ID fields.
| | | * MDEV-21024: Optimize writing BTR_EXTERN_LENMarko Mäkelä2019-11-111-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | btr_store_big_rec_extern_fields(): Remove the redundant initialization of the most significant 32 bits of BTR_EXTERN_LEN. InnoDB never supported BLOBs that are longer than 4GiB. In fact, dtuple_convert_big_rec() would write emit an error message if a clustered index record tuple would exceed 1,000,000,000 bytes in length. The BTR_EXTERN_LEN in the BLOB pointers in clustered index leaf page records is zero-initialized at least since commit 41bb3537ba507799ab0143acd75ccab72192931e
| | | * MDEV-21024: Clean up rtr_adjust_upper_level()Marko Mäkelä2019-11-111-1/+0
| | | | | | | | | | | | | | | | | | | | Remove the unnecessary retrieval and null-modifications of the preceding page.
| | | * Cleanup btr_page_get_prev(), btr_page_get_next()Marko Mäkelä2019-11-1113-145/+89
| | | | | | | | | | | | | | | | | | | | | | | | Remove the redundant parameter mtr_t*. Make use of page_has_prev(), page_has_next() whenever possible.
| | | * MDEV-21024: Clean up rtr_adjust_upper_level()Marko Mäkelä2019-11-111-20/+0
| | | | | | | | | | | | | | | | | | | | Remove the unnecessary retrieval and null-modifications of the preceding page.
* | | | Cleanup: Replace xdes_set_bit()Marko Mäkelä2019-11-081-40/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The XDES_CLEAN_BIT is always set for every element of the page allocation bitmap in the extent descriptor pages. Do not bother touching it, to avoid redundant writes. xdes_set_free<bool free>(): Replaces xdes_set_bit().
* | | | Cleanup: Remove redundant XDES_FREE_BIT parametersMarko Mäkelä2019-11-084-264/+94
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The page allocation bitmaps in the extent descriptor pages contain two bits per page: XDES_FREE_BIT and XDES_CLEAN_BIT, which is unused. Simplify read access. xdes_is_free(descr,mtr): Remove. Use !xdes_get_n_used(descr) instead. xdes_is_free(): Replaces xdes_get_bit(), xdes_mtr_get_bit(). xdes_find_free(): Replaces xdes_find_bit(). fsp_seg_inode_page_get_nth_inode(): Remove the redundant parameters physical_size, mtr. fsp_seg_inode_page_find_used(), fsp_seg_inode_page_find_free(): Remove the redundant parameter mtr.
* | | | Merge 10.4 into 10.5Marko Mäkelä2019-11-081-9/+1
|\ \ \ \ | |/ / /
| * | | MDEV-17138 follow-up: Use MLOG_MEMSET in xdes_init()Marko Mäkelä2019-11-081-9/+1
| | | |
* | | | Use uint16_t for FIL_PAGE_TYPEMarko Mäkelä2019-11-081-1/+1
| | | | | | | | | | | | | | | | | | | | Since commit 5d596064d676ae691d55cae653b1c461ab012e46 fil_page_type_is_index() expects uint16_t, not ulint.
* | | | MDEV-12353 preparation: Remove redundant writesMarko Mäkelä2019-11-082-16/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fsp_alloc_seg_inode_page(): Ever since commit 3926673ce7149aa223103126b6aeac819b10fab5 all newly allocated pages are zero-initialized. Assert that this is the case for the FSEG_ID fields. (Side note: before that fix, other parts of the pages could contain nonzero garbage.) btr_store_big_rec_extern_fields(): Remove the redundant initialization of the most significant 32 bits of BTR_EXTERN_LEN. InnoDB never supported BLOBs that are longer than 4GiB. In fact, dtuple_convert_big_rec() would write emit an error message if a clustered index record tuple would exceed 1,000,000,000 bytes in length.
* | | | Cleanup: Do not pass mtr_t* as NULLMarko Mäkelä2019-11-081-16/+32
| | | | | | | | | | | | | | | | PageConverter::update_index_page(): Invoke lower-level writes directly.
* | | | Cleanup: Define FIL_PAGE_TYPE constants as constexprMarko Mäkelä2019-11-083-42/+51
| | | |
* | | | Merge 10.4 into 10.5Marko Mäkelä2019-11-0813-142/+47
|\ \ \ \ | |/ / /
| * | | Cleanup: Remove mach_read_ulint()Marko Mäkelä2019-11-0811-126/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The function mach_read_ulint() is a wrapper for the lower-level functions mach_read_from_1(), mach_read_from_2(), mach_read_from_8(). Invoke those functions directly, for better readability of the code. mtr_t::read_ulint(), mtr_read_ulint(): Remove. Yes, we will lose the ability to assert that the read is covered by the mini-transaction. We would still check that on writes, and any writes that wrongly bypass mini-transaction logging would likely be caught by stress testing with Mariabackup.
| * | | MDEV-17138 follow-up: Use MLOG_MEMSET for writing FIL_NULLMarko Mäkelä2019-11-083-16/+16
| | | | | | | | | | | | | | | | | | | | Always use the MLOG_MEMSET record for writing FIL_NULL, because it is more compact.
* | | | Merge 10.4 into 10.5Marko Mäkelä2019-11-078-80/+124
|\ \ \ \ | |/ / / | | | | | | | | | | | | | | | | | | | | | | | | A conflict between MDEV-19514 (b42294bc6409794bdbd2051b32fa079d81cea61d) and MDEV-20934 (d7a2401750bb29dfdb45929a536539b9f17b347f) was resolved. We will not invoke the function ibuf_delete_recs() from ibuf_merge_or_delete_for_page(). Instead, we will add that logic to the function ibuf_read_merge_pages().
| * | | Merge 10.3 into 10.4Marko Mäkelä2019-11-068-61/+119
| |\ \ \ | | |/ /
| | * | Merge 10.2 into 10.3Marko Mäkelä2019-11-068-61/+119
| | |\ \ | | | |/
| | | * Follow-up to 792c9f9a4977ea428537ca34435d39bd17cec5ffmariadb-10.2.29Marko Mäkelä2019-11-064-29/+19
| | | | | | | | | | | | | | | | | | | | | | | | dict_index_add_to_cache(): Make the 'index' a reference to a pointer, so that the caller will avoid the expensive call to dict_index_get_if_in_cache_low().
| | | * Merge 10.1 to 10.2Marko Mäkelä2019-11-062-5/+3
| | | |\
| | | | * MDEV-20987 InnoDB fails to start when fts table has FK relationThirunarayanan Balathandayuthapani2019-11-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | InnoDB: Assertion failure in file .../dict/dict0dict.cc line ... InnoDB: Failing assertion: table->can_be_evicted This fixes a regression that was caused by the fix of MDEV-20621 (commit a41d429765c7ddb528b9b438c68b25ff55d3bd55). MySQL 5.6 (and MariaDB 10.0) introduced eviction of tables from the InnoDB data dictionary cache. Tables that are connected to FOREIGN KEY constraints or FULLTEXT INDEX are exempt of the eviction. With the problematic change, a table that would already be exempt from eviction due to FOREIGN KEY would cause the problem if there also was a FULLTEXT INDEX defined on it. dict_load_table(): Only prevent eviction if table->can_be_evicted holds.
| | | | * Fix GCC 9.2.1 -Wstringop-truncationMarko Mäkelä2019-11-041-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | dict_table_rename_in_cache(): Use strcpy() instead of strncpy(), because they are known to be equivalent in this case (the length of old_name was already validated). mariabackup: Invoke strncpy() with one less than the buffer size, and explicitly add NUL as the last byte of the buffer.
| | | * | MDEV-20934 Infinite loop on innodb_fast_shutdown=0 with inconsistent change ↵Marko Mäkelä2019-11-061-7/+76
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | buffer Due to a data corruption bug that may have occurred a long time earlier (possibly involving physical backup and MySQL Bug #69122, which was addressed in commit f166ec71b78fdf7a08ba413509cf00ad9e003b3c) it seems possible that the InnoDB change buffer might end up containing entries, while no buffered changes exist according to the change buffer bitmap pages in the .ibd files. ibuf_delete_recs(): New function, to be invoked on slow shutdown only. Remove all buffered changes for a specific page. ibuf_merge_or_delete_for_page(): If the change buffer bitmap is clean and a slow shutdown is in progress, invoke ibuf_delete_recs(). We do not want to do that during normal operation, due to the additional overhead that is involved. The bitmap page should be consistent with the change buffer in the first place.
| | | * | cleanup: replace some mtr_read_ulint() with mach_read_from_4()Eugene Kosov2019-11-011-17/+11
| | | | |
| | | * | cleanup: get rid of dict_index_add_to_cache_w_vcol()Eugene Kosov2019-11-013-50/+13
| | | | | | | | | | | | | | | | | | | | dict_index_add_to_cache_w_vcol(): merge with dict_index_add_to_cache()
* | | | | Merge 10.4 into 10.5Oleksandr Byelkin2019-11-0730-377/+335
|\ \ \ \ \ | |/ / / /
| * | | | Merge 10.3 into 10.4Marko Mäkelä2019-11-0130-384/+343
| |\ \ \ \ | | |/ / /
| | * | | MDEV-20938 Double free of dict_foreign_t during instant ALTER TABLEThirunarayanan Balathandayuthapani2019-11-011-24/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | innobase_drop_foreign_try(): Don't evict and reload the dict_foreign_t during instant ALTER TABLE if the FOREIGN KEY constraint is being dropped. The MDEV-19630 fix (commit 07b1a26c33b28812a4fd8c814de0fe7d943bbd6b) was incomplete, because it did not cover a case where the FOREIGN KEY constraint is being dropped.
| | * | | Merge branch '10.2' into 10.3Oleksandr Byelkin2019-10-3118-259/+210
| | |\ \ \ | | | |/ /
| | | * | Merge branch '10.1' into 10.2Oleksandr Byelkin2019-10-311-31/+0
| | | |\ \ | | | | |/
| | | | * MDEV-20927: Remove duplicated codeMarko Mäkelä2019-10-311-31/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In commit d1e6b0bcff0148f474e38002d5c1198726fe7970 some code was supposed to be modified, but instead it got duplicated. Remove the duplicated copy.
| | | * | Merge branch '10.1' into 10.2Oleksandr Byelkin2019-10-302-24/+44
| | | |\ \ | | | | |/
| | | | * MDEV-20927 Duplicate key with auto incrementMarko Mäkelä2019-10-301-24/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Apply the changes to InnoDB and XtraDB that had been inadvertently skipped in the merge commit ae476868a5394041a00e75a29c7d45917e8dfae8 That merge failure sabotaged part of MDEV-20127: >Revert a problematic auto_increment_increment 'fix' from 2014. >This involves replacing the MDEV-8827 fix and in 10.1, >removing some WSREP instrumentation. The code changes were re-merged manually by executing the following: # Get the parent of the problematic merge. git checkout ae476868a5394041a00e75a29c7d45917e8dfae8^ # Perform the merge again. git merge ae476868a5394041a00e75a29c7d45917e8dfae8^2 # Get the conflict resolution from that merge. git checkout ae476868a5394041a00e75a29c7d45917e8dfae8 . # Note: Any changes to these files were removed (empty diff)! git diff HEAD storage/{innobase,xtradb}/handler/ha_innodb.cc # Apply the code changes: git diff cf40393471b10ca68cc1d2804c22ab9203900978^2..MERGE_HEAD \ storage/{innobase,xtradb}/handler/ha_innodb.cc| patch -p1
| | | | * Merge 5.5 into 10.1Eugene Kosov2019-10-291-0/+11
| | | | |\
| | | | | * add .clang-format file for InnoDBbb-5.5-kevgsEugene Kosov2019-10-291-0/+11
| | | | | |
| | | * | | MDEV-18562 [ERROR] InnoDB: WSREP: referenced FK check fail: Lock wait indexJan Lindström2019-10-301-2/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Lock wait can happen on secondary index when doing FK checks for wsrep. We should just return error to upper layer and applier will retry operation when needed.
| | | * | | Clean up ut_strlcpy(), ut_strlcpy_rev()Marko Mäkelä2019-10-304-73/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ut_strlcpy(): Replace with the standard function strncpy(). ut_strlcpy_rev(): Define in the same compilation unit where the only caller resides. Avoid unnecessary definition in non-debug builds.
| | | * | | MDEV-20917 InnoDB is passing NULL to nonnull function parametersMarko Mäkelä2019-10-295-45/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | mem_heap_dup(): Avoid mem_heap_alloc() and memcpy() of data=NULL, len=0. trx_undo_report_insert_virtual(), trx_undo_page_report_insert(), trx_undo_page_report_modify(): Avoid memcpy(ptr, NULL, 0). dfield_data_is_binary_equal(): Correctly handle data=NULL, len=0. This clean-up was motivated by WITH_UBSAN, and no bug related to this was observed in the wild. It should be noted that undefined behaviour such as memcpy(ptr, NULL, 0) could allow compilers to perform unsafe optimizations, like it was the case in commit fc168c3a5e58d8b364a2e87e0d876a261ec7fced (MDEV-15587).
| | | * | | MDEV-20825 : Innodb does not start if GetDiskFreeSpace() fails.Vladislav Vaintroub2019-10-281-17/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ignore GetDiskFreeSpace() errors in os_file_get_status_win32 The call is only used to calculate filesystem block size, and this in turn is only shown in information_schema.sys_tablespaces.FS_BLOCK_SIZE. There is no other use of this field, it does not affect any Innodb functionality
View Lorry Controller Status