From 3fbbe686ee802461ef293181f952911c253639a6 Mon Sep 17 00:00:00 2001 From: "lenz@mysql.com" <> Date: Tue, 4 Feb 2003 22:30:47 +0100 Subject: - removed LIBOBJS hack (no longer required with newer versions of autoconf and actually results in an error with very recent autoconf versions! (see http://www.gnu.org/manual/autoconf/html_node/autoconf_165.html or "AC_LIBOBJ vs. LIBOBJS" in the autoconf documentation) Please merge this into 4.0 as well! --- bdb/dist/configure.in | 7 ------- 1 file changed, 7 deletions(-) diff --git a/bdb/dist/configure.in b/bdb/dist/configure.in index 6656a588a66..08d60a6c07a 100644 --- a/bdb/dist/configure.in +++ b/bdb/dist/configure.in @@ -463,13 +463,6 @@ dnl deleted getwd(). AC_REPLACE_FUNCS(getcwd getopt memcmp memcpy memmove) AC_REPLACE_FUNCS(raise snprintf strcasecmp strerror vsnprintf) -dnl XXX -dnl Nasty hack. AC_REPLACE_FUNCS added entries of the form xxx.o to the -dnl LIBOBJS variable. They have to be xxx.lo if we are building shared -dnl libraries. Use sed, configure already requires it. -tmp="`echo \"$LIBOBJS\" | sed \"s/\.o/${o}/g\"`" -LIBOBJS="$tmp" - dnl Check for system functions we optionally use. AC_CHECK_FUNCS(getuid pstat_getdynamic sysconf sched_yield strtoul yield) -- cgit v1.2.1 From a30d3cd8473e7d4ad3412a042741f34dcb004e80 Mon Sep 17 00:00:00 2001 From: "heikki@hundin.mysql.fi" <> Date: Wed, 5 Feb 2003 01:42:07 +0200 Subject: ha_innobase.cc: Backport from 4.0: fix potential bug if store_lock is called with TL_IGNORE in the middle of a query --- sql/ha_innobase.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sql/ha_innobase.cc b/sql/ha_innobase.cc index 7045e5c31d5..5b2af70f34e 100644 --- a/sql/ha_innobase.cc +++ b/sql/ha_innobase.cc @@ -3700,7 +3700,7 @@ ha_innobase::store_lock( binlog) requires the use of a locking read */ prebuilt->select_lock_type = LOCK_S; - } else { + } else if (lock_type != TL_IGNORE) { /* We set possible LOCK_X value in external_lock, not yet here even if this would be SELECT ... FOR UPDATE */ -- cgit v1.2.1 From 1454f356405301cb6e562aea050b5d8ab0f0bac6 Mon Sep 17 00:00:00 2001 From: "lenz@mysql.com" <> Date: Wed, 5 Feb 2003 11:49:51 +0100 Subject: - Yves mail address does not seem to be valid anymore - changed mail address to report bugs to bugs@mysql.com (thanks to Christian Hammers for pointing this out) - please merge this into all other trees! --- scripts/mysqlaccess.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/mysqlaccess.sh b/scripts/mysqlaccess.sh index 824dba7b65a..699e74834e3 100644 --- a/scripts/mysqlaccess.sh +++ b/scripts/mysqlaccess.sh @@ -2414,7 +2414,7 @@ sub Print_Header { sub Print_Footer { if ($MySQLaccess::CMD) { #command-line mode print "\n" - ."BUGs can be reported by email to Yves.Carlier\@rug.ac.be\n"; + ."BUGs can be reported by email to bugs\@mysql.com\n"; } if ($MySQLaccess::CGI) { #CGI-BIN mode if ($MySQLaccess::Param{'brief'}) { @@ -2422,7 +2422,7 @@ sub Print_Footer { } print "
\n" ."
\n" - ."BUGs can be reported by email to Yves.Carlier\@rug.ac.be
\n" + ."BUGs can be reported by email to bugs\@mysql.com
\n" # ."Don't forget to mention the version $VERSION!
\n" ."
\n" ."\n" -- cgit v1.2.1 From ff15b200f99a01e5c0aa650862f44e2f8b2f3574 Mon Sep 17 00:00:00 2001 From: "lenz@mysql.com" <> Date: Wed, 5 Feb 2003 12:22:28 +0100 Subject: - added word of warning about providing the password as cleartext using the --password parameter (better add it to my.cnf instead) (Thanks to Christian Hammers for the suggestion) --- scripts/mysqlhotcopy.sh | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/scripts/mysqlhotcopy.sh b/scripts/mysqlhotcopy.sh index b8d4a0a9a38..1a694247461 100644 --- a/scripts/mysqlhotcopy.sh +++ b/scripts/mysqlhotcopy.sh @@ -49,8 +49,9 @@ Usage: $0 db_name[./table_regex/] [new_db_name | directory] -?, --help display this helpscreen and exit -u, --user=# user for database login if not current user - -p, --password=# password to use when connecting to server - -h, --host=# Hostname for local server when connecting over TCP/IP + -p, --password=# password to use when connecting to server (if not set + in my.cnf, which is recommended) + -h, --host=# Hostname for local server when connecting over TCP/IP -P, --port=# port to use when connecting to local server with TCP/IP -S, --socket=# socket to use when connecting to local server @@ -893,7 +894,11 @@ user for database login if not current user =item -p, --password=# -password to use when connecting to server +password to use when connecting to the server. Note that you are strongly +encouraged *not* to use this option as every user would be able to see the +password in the process list. Instead use the '[mysqlhotcopy]' section in +one of the config files, normally /etc/my.cnf or your personal ~/.my.cnf. +(See the chapter 'my.cnf Option Files' in the manual) =item -h, -h, --host=# -- cgit v1.2.1 From 736e96f63ce62855d07e252658374ca55fa725f1 Mon Sep 17 00:00:00 2001 From: "lenz@mysql.com" <> Date: Wed, 5 Feb 2003 18:02:12 +0100 Subject: Small enhancements for Do-compile: - add version number to build log files (e.g. Logs/build-4.1-standard.log) - add host name and uname to Subject line of build failure mails (e.g. "Subject: build(Linux): mysql-4.1-standard compilation failed") -> Please merge with all other trees! --- Build-tools/Do-compile | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/Build-tools/Do-compile b/Build-tools/Do-compile index 6f11745d5b0..9b26a93d100 100755 --- a/Build-tools/Do-compile +++ b/Build-tools/Do-compile @@ -75,13 +75,17 @@ if (@config_env > 0) } chomp($host=`hostname`); +chomp($uname=`uname`); $full_host_name=$host; $connect_option= ($opt_tcpip ? "--host=$host" : ""); $host =~ /^([^.-]*)/; $host=$1 . $opt_suffix; $email="$opt_user\@mysql.com"; -$pwd = `pwd`; chomp($pwd); -$log="$pwd/Logs/$host$opt_version_suffix.log"; +chomp($pwd = `pwd`); +$VER= `basename $opt_distribution`; chop $VER; +$VER=~ /mysql.*-([1-9]\.[0-9]{1,2}\.[0-9]{1,2}.*)\.tar*/; $version=$1; +($major, $minor, $release) = split(/\./,$version); +$log="$pwd/Logs/$host-$major.$minor$opt_version_suffix.log"; $opt_distribution =~ /(mysql[^\/]*)\.tar/; $ver=$1; $gcc_version=which("gcc"); @@ -558,9 +562,9 @@ sub abort { $mail_header_file="$opt_tmp/do-command.$$"; open(TMP,">$mail_header_file"); - print TMP "From: mysql\@$full_host_name\n"; + print TMP "From: mysqldev\@$full_host_name\n"; print TMP "To: $email\n"; - print TMP "Subject: $ver$opt_version_suffix compilation failed\n\n"; + print TMP "Subject: $host($uname): $ver$opt_version_suffix compilation failed\n\n"; close TMP; system("tail -n 40 $log > $log.mail"); system("cat $mail_header_file $log.mail | $sendmail -t -f $email"); -- cgit v1.2.1 From 3cc3ec177f9169731f87c9fd3905e02ac23341de Mon Sep 17 00:00:00 2001 From: "serg@sergbook.mysql.com" <> Date: Mon, 10 Feb 2003 14:47:39 +0100 Subject: error message fixed (new error code will be introduced in 4.1) --- sql/sql_acl.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sql/sql_acl.cc b/sql/sql_acl.cc index a752bc7add8..05ec57b134a 100644 --- a/sql/sql_acl.cc +++ b/sql/sql_acl.cc @@ -995,7 +995,9 @@ static int replace_user_table(TABLE *table, const LEX_USER &combo, { if (combo.password.length != HASH_PASSWORD_LENGTH) { - my_error(ER_PASSWORD_NO_MATCH,MYF(0)); + my_printf_error(ER_PASSWORD_NO_MATCH, + "Password hash should be a %d-digit hexadecimal number", + MYF(0),HASH_PASSWORD_LENGTH); DBUG_RETURN(-1); } password=combo.password.str; -- cgit v1.2.1