From 4b9341c4c0082531364caad976bf82dbc7455f73 Mon Sep 17 00:00:00 2001
From: Sergey Vojtovich <svoj@mariadb.org>
Date: Wed, 16 Oct 2019 15:31:22 +0400
Subject: Allocate column_stats along with table_stats

Simplified away Table_statistics::column_stats: didn't serve any
purpose.

Part of MDEV-19061 - table_share used for reading statistical tables is
                     not protected
---
 sql/sql_statistics.cc | 69 +++++++++++++++++++--------------------------------
 sql/sql_statistics.h  |  1 -
 2 files changed, 25 insertions(+), 45 deletions(-)

diff --git a/sql/sql_statistics.cc b/sql/sql_statistics.cc
index ef58352dca8..cf8ecb83e60 100644
--- a/sql/sql_statistics.cc
+++ b/sql/sql_statistics.cc
@@ -2142,7 +2142,6 @@ int alloc_statistics_for_table(THD* thd, TABLE *table)
     DBUG_RETURN(1);
 
   table->collected_stats= table_stats;
-  table_stats->column_stats= column_stats;
   table_stats->index_stats= index_stats;
   table_stats->idx_avg_frequency= idx_avg_frequency;
   table_stats->histograms= histogram;
@@ -2219,7 +2218,6 @@ int alloc_statistics_for_table(THD* thd, TABLE *table)
 
 static int alloc_statistics_for_table_share(THD* thd, TABLE_SHARE *table_share)
 {
-  Field **field_ptr;
   KEY *key_info, *end;
   TABLE_STATISTICS_CB *stats_cb= &table_share->stats_cb;
 
@@ -2239,38 +2237,34 @@ static int alloc_statistics_for_table_share(THD* thd, TABLE_SHARE *table_share)
   Table_statistics *table_stats= stats_cb->table_stats;
   if (!table_stats)
   {
-    table_stats=  (Table_statistics *) alloc_root(&stats_cb->mem_root,
-                                                  sizeof(Table_statistics));
-    if (!table_stats)
+    uint fields= table_share->fields;
+    Column_statistics *column_stats;
+
+    if (!multi_alloc_root(&stats_cb->mem_root,
+                          &table_stats, sizeof(*table_stats),
+                          &column_stats, sizeof(*column_stats) * (fields + 1),
+                          NullS))
     {
       mysql_mutex_unlock(&table_share->LOCK_share);
       DBUG_RETURN(1);
     }
+
+    /* Table_statistics */
     memset(table_stats, 0, sizeof(Table_statistics));
-    stats_cb->table_stats= table_stats;
-  }
 
-  uint fields= table_share->fields;
-  Column_statistics *column_stats= table_stats->column_stats;
-  if (!column_stats)
-  {
-    column_stats= (Column_statistics *) alloc_root(&stats_cb->mem_root,
-                                                   sizeof(Column_statistics) *
-				                   (fields+1));  
-    if (column_stats)
-    { 
-      memset(column_stats, 0, sizeof(Column_statistics) * (fields+1));
-      table_stats->column_stats= column_stats;
-      for (field_ptr= table_share->field;
-           *field_ptr;
-           field_ptr++, column_stats++)
-      {
-        (*field_ptr)->read_stats= column_stats;
-        (*field_ptr)->read_stats->min_value= NULL;
-        (*field_ptr)->read_stats->max_value= NULL;
-      }
-      create_min_max_statistical_fields_for_table_share(thd, table_share);
+    /* Column_statistics */
+    memset(column_stats, 0, sizeof(Column_statistics) * (fields + 1));
+    for (Field **field_ptr= table_share->field;
+         *field_ptr;
+         field_ptr++, column_stats++)
+    {
+      (*field_ptr)->read_stats= column_stats;
+      (*field_ptr)->read_stats->min_value= NULL;
+      (*field_ptr)->read_stats->max_value= NULL;
     }
+
+    stats_cb->table_stats= table_stats;
+    create_min_max_statistical_fields_for_table_share(thd, table_share);
   }
 
   uint keys= table_share->keys;
@@ -2312,7 +2306,7 @@ static int alloc_statistics_for_table_share(THD* thd, TABLE_SHARE *table_share)
     }   
   }
 
-  if (column_stats && index_stats && idx_avg_frequency)
+  if (index_stats && idx_avg_frequency)
     stats_cb->stats_can_be_read= TRUE;
 
   mysql_mutex_unlock(&table_share->LOCK_share);
@@ -3085,27 +3079,14 @@ int read_statistics_for_table(THD *thd, TABLE *table, TABLE_LIST *stat_tables)
 
 void delete_stat_values_for_table_share(TABLE_SHARE *table_share)
 {
-  TABLE_STATISTICS_CB *stats_cb= &table_share->stats_cb;
-  Table_statistics *table_stats= stats_cb->table_stats;
-  if (!table_stats)
+  if (!table_share->stats_cb.table_stats)
     return;
-  Column_statistics *column_stats= table_stats->column_stats;
-  if (!column_stats)
-    return;
-
-  for (Field **field_ptr= table_share->field;
-       *field_ptr;
-       field_ptr++, column_stats++)
+  for (Field **field_ptr= table_share->field; *field_ptr; field_ptr++)
   {
-    if (column_stats->min_value)
+    if (auto column_stats= (*field_ptr)->read_stats)
     {
       delete column_stats->min_value;
-      column_stats->min_value= NULL;
-    }
-    if (column_stats->max_value)
-    {
       delete column_stats->max_value;
-      column_stats->max_value= NULL;
     }
   }
 }
diff --git a/sql/sql_statistics.h b/sql/sql_statistics.h
index 5fc9d7b5c75..853f573251b 100644
--- a/sql/sql_statistics.h
+++ b/sql/sql_statistics.h
@@ -292,7 +292,6 @@ public:
   my_bool cardinality_is_null;      /* TRUE if the cardinality is unknown */
   ha_rows cardinality;              /* Number of rows in the table        */
   uchar *min_max_record_buffers;    /* Record buffers for min/max values  */
-  Column_statistics *column_stats;  /* Array of statistical data for columns */
   Index_statistics *index_stats;    /* Array of statistical data for indexes */
   ulong *idx_avg_frequency;   /* Array of records per key for index prefixes */
   ulong total_hist_size;            /* Total size of all histograms */
-- 
cgit v1.2.1