From 9286d1c1452d53dd36c94fbe94a3f99be7b1dfb2 Mon Sep 17 00:00:00 2001 From: unknown Date: Fri, 3 Dec 2004 00:05:11 +0100 Subject: Prevent adding 'CREATE TABLE .. SELECT' query to the binary log when the insertion of new records partially failed. It would get logged because of the logic to log a partially-failed 'INSERT ... SELECT' (which can't be rolled back in non-transactional tables), but 'CREATE TABLE ... SELECT' is always rolled back on failure, even for non-transactional tables. (Bug #6682) (Original fix reimplemented after review by Serg and Guilhem.) mysql-test/t/insert_select.test: Add test case for Bug #6682 mysql-test/r/insert_select.result: Add results for test case for Bug #6682 sql/sql_table.cc: moved tmp_disable_binlog() and reenable_binlog macros to sql/sql_class.h sql/sql_insert.cc: disable binlog during call to super's ::send_error in select_create class sql/sql_class.h: add select_create::send_error() BitKeeper/etc/logging_ok: Logging to logging@openlogging.org accepted --- BitKeeper/etc/logging_ok | 1 + 1 file changed, 1 insertion(+) (limited to 'BitKeeper') diff --git a/BitKeeper/etc/logging_ok b/BitKeeper/etc/logging_ok index e8b795c4d80..6e6433a80ae 100644 --- a/BitKeeper/etc/logging_ok +++ b/BitKeeper/etc/logging_ok @@ -64,6 +64,7 @@ jcole@main.burghcom.com jcole@mugatu.spaceapes.com jcole@sarvik.tfr.cafe.ee jcole@tetra.spaceapes.com +jimw@mysql.com joerg@mysql.com jorge@linux.jorge.mysql.com kaj@work.mysql.com -- cgit v1.2.1