From de55a7d1f923849e221ca44d9f8e375569ffe5f0 Mon Sep 17 00:00:00 2001 From: Sergei Golubchik Date: Tue, 20 Mar 2018 20:54:58 +0100 Subject: Allow table-less selects even when wsrep is not ready It doesn't make sense to allow selects from I_S but disallow selects that don't use any tables at all, because any (disallowed) select that doesn't use tables can be made allowed by adding "FROM I_S.COLLATIONS LIMIT 1" to the end. And it break mysql-test rather badly, even check-testcase.test fails on its first `SELECT '$tmp' = 'No such row'` This reverts 9a896148576, c5dd2abf4ca, and 33028f7c4bc: Refs: MW-245 - changed logic so that in non primary node it is possible to do SET + SHOW + SELECT from information and pfs schema, when dirty reads are not enabled - however, non table selects are not allowed (e.g. SELECT 1) Refs MW-245 - logic was wrong in detecting if queries are allowed in non primary node. it allowed select with no table list to execute even if dirty reads was not specified Refs: MW-245 - Adjust tests to account for the new behavior. --- mysql-test/suite/galera/t/galera_var_dirty_reads.test | 2 -- 1 file changed, 2 deletions(-) (limited to 'mysql-test/suite/galera/t/galera_var_dirty_reads.test') diff --git a/mysql-test/suite/galera/t/galera_var_dirty_reads.test b/mysql-test/suite/galera/t/galera_var_dirty_reads.test index 85d759e4a27..138b7c1c703 100644 --- a/mysql-test/suite/galera/t/galera_var_dirty_reads.test +++ b/mysql-test/suite/galera/t/galera_var_dirty_reads.test @@ -47,10 +47,8 @@ SET @@session.wsrep_dirty_reads=OFF; --error ER_UNKNOWN_COM_ERROR SELECT i, variable_name, variable_value FROM t1, information_schema.session_variables WHERE variable_name LIKE "wsrep_dirty_reads" AND i = 1; ---error ER_UNKNOWN_COM_ERROR SELECT 1; ---error ER_UNKNOWN_COM_ERROR USE information_schema; SELECT * FROM information_schema.session_variables WHERE variable_name LIKE "wsrep_dirty_reads"; -- cgit v1.2.1