From 605f7061dc2ca28d78ad652b9b5a7225f55ccb9a Mon Sep 17 00:00:00 2001
From: unknown <stewart@mysql.com>
Date: Wed, 25 May 2005 15:35:51 +1000
Subject: BUG#10831 ndb mgmd LogDestination maxfiles does not rotate logs
properly
ndb/src/common/util/File.cpp:
my_stat returns NULL on failure, not non-zero.
i.e. exactly the opposite of stat(2).
providing confusion for unix programmers, who expect errors to be non-zero.
Clean up File_class::exists(char*) to use the my_stat interface properly.
---
ndb/src/common/util/File.cpp | 26 +++-----------------------
1 file changed, 3 insertions(+), 23 deletions(-)
(limited to 'ndb')
diff --git a/ndb/src/common/util/File.cpp b/ndb/src/common/util/File.cpp
index 937b8c0fa59..e514ad8e122 100644
--- a/ndb/src/common/util/File.cpp
+++ b/ndb/src/common/util/File.cpp
@@ -28,29 +28,9 @@
bool
File_class::exists(const char* aFileName)
{
- bool rc = true;
-#ifdef USE_MY_STAT_STRUCT
- struct my_stat stmp;
-#else
- struct stat stmp;
-#endif
- if (my_stat(aFileName, &stmp, MYF(0)) != 0)
- {
- rc = false;
- }
-
- /*
- File f;
- if (!f.open(aFileName, "r"))
- {
- rc = (errno == ENOENT ? false : true);
- }
- else
- {
- f.close();
- }
- */
- return rc;
+ MY_STAT stmp;
+
+ return (my_stat(aFileName, &stmp, MYF(0))!=NULL);
}
long
--
cgit v1.2.1