From 7c35c3d5e66b350b59fb0aaef4d1cc97f332bea7 Mon Sep 17 00:00:00 2001 From: unknown Date: Tue, 21 Nov 2006 17:47:14 +0300 Subject: Polishing: - change some return types from int to bool; - add [ERROR] tag to log_error() output; - add [INFO] tag to log_info() output; - change log messages to be more consistent. server-tools/instance-manager/IMService.cpp: Log polishing. server-tools/instance-manager/commands.cc: Log polishing. server-tools/instance-manager/commands.h: Eliminate warnings. server-tools/instance-manager/instance.cc: Log polishing. server-tools/instance-manager/instance_map.cc: Log polishing. server-tools/instance-manager/instance_options.cc: 1) Log polishing. 2) Change int-return type to bool. server-tools/instance-manager/instance_options.h: Change int-return type to bool. server-tools/instance-manager/listener.cc: Log polishing. server-tools/instance-manager/log.cc: Log polishing. server-tools/instance-manager/log.h: Log polishing. server-tools/instance-manager/manager.cc: Log polishing. server-tools/instance-manager/mysql_connection.cc: Log polishing. server-tools/instance-manager/mysql_connection.h: Change int-return type to bool. server-tools/instance-manager/mysqlmanager.cc: Log polishing. server-tools/instance-manager/priv.cc: Log polishing. server-tools/instance-manager/thread_registry.cc: 1. Print pthread_t as (unsigned long), not as (signed long) to avoid negative identifiers in output. 2. Print thread id after it will be initialized, not before. server-tools/instance-manager/user_map.cc: Log polishing. --- server-tools/instance-manager/commands.h | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) (limited to 'server-tools/instance-manager/commands.h') diff --git a/server-tools/instance-manager/commands.h b/server-tools/instance-manager/commands.h index bf387b7bb6a..8768aaab121 100644 --- a/server-tools/instance-manager/commands.h +++ b/server-tools/instance-manager/commands.h @@ -37,6 +37,10 @@ class Show_instances: public Command { +public: + Show_instances() + { } + public: int execute(st_net *net, ulong connection_id); @@ -53,6 +57,10 @@ private: class Flush_instances: public Command { +public: + Flush_instances() + { } + public: int execute(st_net *net, ulong connection_id); }; @@ -311,6 +319,10 @@ private: class Set_option: public Abstract_option_cmd { +public: + Set_option() + { } + protected: virtual bool parse_args(const char **text); virtual int process_option(Instance *instance, Named_value *option); @@ -324,6 +336,10 @@ protected: class Unset_option: public Abstract_option_cmd { +public: + Unset_option() + { } + protected: virtual bool parse_args(const char **text); virtual int process_option(Instance *instance, Named_value *option); @@ -341,6 +357,10 @@ protected: class Syntax_error: public Command { +public: + Syntax_error() + { } + public: int execute(st_net *net, ulong connection_id); }; -- cgit v1.2.1