From 7fb3b348d71ef29ed10ed7f41b332074c8ac0a3d Mon Sep 17 00:00:00 2001 From: Sergei Petrunia Date: Sat, 21 Jan 2017 22:58:04 +0300 Subject: MariaRocks port: Remove handler::init_with_fields - It turns out, ha_rocksdb::table_flags() can return HA_PRIMARY_KEY_IN_READ_INDEX for all kinds of tables (as its meaning is "if there is a PK, PK columns contribute to the secondary index tuple". There is no assumption that a certain PK column can be decoded from the secondary index. (Should probably be fixed in the upstream, too, but I was unable to construct a testcase showing this is necessary). - Following the above, we can undo the init_with_fields() changes in table.cc. MyRocks calls init_with_fields() from ha_rocksdb::open() which sets index-only read capabilities properly. --- sql/ha_partition.h | 2 -- 1 file changed, 2 deletions(-) (limited to 'sql/ha_partition.h') diff --git a/sql/ha_partition.h b/sql/ha_partition.h index 7324efcb6c9..70cd3760783 100644 --- a/sql/ha_partition.h +++ b/sql/ha_partition.h @@ -307,8 +307,6 @@ public: ha_partition *clone_arg, MEM_ROOT *clone_mem_root_arg); ~ha_partition(); - - bool init_with_fields(); /* A partition handler has no characteristics in itself. It only inherits those from the underlying handlers. Here we set-up those constants to -- cgit v1.2.1