From 9bc3976c79d484c380ed9265c51918a942cd22b7 Mon Sep 17 00:00:00 2001 From: unknown Date: Sat, 27 Aug 2005 02:33:06 +0400 Subject: Slightly amended Monty's SP replication code cleanup patch sql/item.cc: Code cleanup sql/item.h: Code cleanup sql/log.cc: Added comments sql/sp_head.cc: Code cleanup patch from Monty: in subst_spvars() - Move local variables first in block - Use res|= instead of res |= - Use strmake() instead of alloc + memcpy Added: - Fail the query if we don't have enough memory to produce a binlog-suitable query string: if we're so low on memory we're likely to fail the query anyway, and failing now removes the need for hack with THD::query_str_binlog_suitable. sql/sql_class.cc: Remove THD::query_str_binlog_unsuitable sql/sql_class.h: Remove THD::query_str_binlog_unsuitable sql/sql_delete.cc: Remove THD::query_str_binlog_unsuitable sql/sql_insert.cc: Remove THD::query_str_binlog_unsuitable sql/sql_parse.cc: Code cleanup sql/sql_update.cc: Remove THD::query_str_binlog_unsuitable --- sql/item.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'sql/item.h') diff --git a/sql/item.h b/sql/item.h index 5dfe90be2b5..b934e1f9f3f 100644 --- a/sql/item.h +++ b/sql/item.h @@ -853,7 +853,7 @@ public: return value_item->save_in_field(field, no_conversions); } - inline bool send(Protocol *protocol, String *str) + bool send(Protocol *protocol, String *str) { return value_item->send(protocol, str); } -- cgit v1.2.1