From e262e74419002711770b09f64db9136f08eb3f15 Mon Sep 17 00:00:00 2001 From: unknown Date: Fri, 6 Jan 2006 18:52:49 -0600 Subject: Bug# 15968 - Partitions: crash when insert with f1 = -1 into partition by hash(f1) fixed mysql-test/r/partition_hash.result: results for newly added test. mysql-test/t/partition_hash.test: test case for inserting a value into a hash that would generate a negative value sql/sql_partition.cc: fields that generate a negative value would also generate a negative part_id which doesn't index into the m_file array to well. --- sql/sql_partition.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'sql/sql_partition.cc') diff --git a/sql/sql_partition.cc b/sql/sql_partition.cc index 5d071c5591c..f1b77cd0240 100644 --- a/sql/sql_partition.cc +++ b/sql/sql_partition.cc @@ -2327,7 +2327,8 @@ static uint32 get_part_id_hash(uint no_parts, Item *part_expr) { DBUG_ENTER("get_part_id_hash"); - DBUG_RETURN((uint32)(part_expr->val_int() % no_parts)); + longlong int_hash_id= part_expr->val_int() % no_parts; + DBUG_RETURN(int_hash_id < 0 ? -int_hash_id : int_hash_id); } -- cgit v1.2.1