From c0878f64c5c39b9cc21f66a401040a708f4f0792 Mon Sep 17 00:00:00 2001
From: Sergei Golubchik <serg@mariadb.org>
Date: Wed, 1 Apr 2015 18:26:19 +0200
Subject: remove wrappers in encryption_keys.cc

invoke plugin methods directly
---
 sql/encryption_keys.cc    | 87 +++++++++++++++++++----------------------------
 sql/sql_plugin.cc         |  3 ++
 sql/sql_plugin_services.h |  9 -----
 3 files changed, 38 insertions(+), 61 deletions(-)

(limited to 'sql')

diff --git a/sql/encryption_keys.cc b/sql/encryption_keys.cc
index 8a9a17a5452..b7afedaa27b 100644
--- a/sql/encryption_keys.cc
+++ b/sql/encryption_keys.cc
@@ -19,61 +19,29 @@
 #include "sql_plugin.h"
 #include <my_crypt.h>
 
+#warning TODO rename to follow single consistent style
+
 /* there can be only one encryption plugin enabled */
 static plugin_ref encryption_key_manager= 0;
-static struct st_mariadb_encryption *handle;
-
-unsigned int get_latest_encryption_key_version()
-{
-  if (encryption_key_manager)
-    return handle->get_latest_key_version();
-
-  return BAD_ENCRYPTION_KEY_VERSION;
-}
+struct encryption_keys_service_st encryption_keys_handler;
 
-unsigned int has_encryption_key(uint version)
+unsigned int has_key(uint version)
 {
-  if (encryption_key_manager)
-  {
-    uint unused;
-    return handle->get_key(version, NULL, &unused) != BAD_ENCRYPTION_KEY_VERSION;
-  }
-
-  return 0;
+  uint unused;
+  return get_encryption_key(version, NULL, &unused) != BAD_ENCRYPTION_KEY_VERSION;
 }
 
-uint get_encryption_key(uint version, uchar* key, uint *size)
+uint no_key()
 {
-  if (encryption_key_manager)
-    return handle->get_key(version, key, size);
-
   return BAD_ENCRYPTION_KEY_VERSION;
 }
 
-int encrypt_data(const uchar* source, uint source_length,
-                 uchar* dest, uint* dest_length,
-                 const uchar* key, uint key_length,
-                 const uchar* iv, uint iv_length,
-                 int no_padding, uint key_version)
-{
-  if (encryption_key_manager)
-    return handle->encrypt(source, source_length,
-                           dest, dest_length, key, key_length,
-                           iv, iv_length, no_padding, key_version);
-  return 1;
-}
-
-
-int decrypt_data(const uchar* source, uint source_length,
-                 uchar* dest, uint* dest_length,
-                 const uchar* key, uint key_length,
-                 const uchar* iv, uint iv_length,
-                 int no_padding, uint key_version)
+static int no_crypt(const uchar* source, uint source_length,
+                    uchar* dest, uint* dest_length,
+                    const uchar* key, uint key_length,
+                    const uchar* iv, uint iv_length,
+                    int no_padding, uint key_version)
 {
-  if (encryption_key_manager)
-    return handle->decrypt(source, source_length,
-                           dest, dest_length, key, key_length,
-                           iv, iv_length, no_padding, key_version);
   return 1;
 }
 
@@ -91,21 +59,36 @@ int initialize_encryption_plugin(st_plugin_int *plugin)
   }
 
   encryption_key_manager= plugin_lock(NULL, plugin_int_to_ref(plugin));
-  handle= (struct st_mariadb_encryption*)
-            plugin->plugin->info;
+  st_mariadb_encryption *handle=
+    (struct st_mariadb_encryption*) plugin->plugin->info;
+
+  encryption_keys_handler.encrypt_data_func=
+    handle->encrypt ? handle->encrypt
+                    : (encrypt_decrypt_func)my_aes_encrypt_cbc;
+
+  encryption_keys_handler.decrypt_data_func=
+    handle->decrypt ? handle->decrypt
+                    : (encrypt_decrypt_func)my_aes_decrypt_cbc;
+
+  encryption_keys_handler.get_encryption_key_func=
+    handle->get_key;
 
-  /* default encryption algorithm */
-  if (!handle->encrypt)
-    handle->encrypt= (encrypt_decrypt_func)my_aes_encrypt_cbc;
-  if (!handle->decrypt)
-    handle->decrypt= (encrypt_decrypt_func)my_aes_decrypt_cbc;
+  encryption_keys_handler.get_latest_encryption_key_version_func=
+    handle->get_latest_key_version; // must be the last
 
   return 0;
 }
 
 int finalize_encryption_plugin(st_plugin_int *plugin)
 {
-  if (plugin->plugin->deinit && plugin->plugin->deinit(NULL))
+  encryption_keys_handler.encrypt_data_func= no_crypt;
+  encryption_keys_handler.decrypt_data_func= no_crypt;
+  encryption_keys_handler.has_encryption_key_func= has_key;
+  encryption_keys_handler.get_encryption_key_func=
+      (uint (*)(uint, uchar*, uint*))no_key;
+  encryption_keys_handler.get_latest_encryption_key_version_func= no_key;
+
+  if (plugin && plugin->plugin->deinit && plugin->plugin->deinit(NULL))
   {
     DBUG_PRINT("warning", ("Plugin '%s' deinit function returned error.",
                            plugin->name.str));
diff --git a/sql/sql_plugin.cc b/sql/sql_plugin.cc
index 0c9ac6b6cb8..ee6650e14e2 100644
--- a/sql/sql_plugin.cc
+++ b/sql/sql_plugin.cc
@@ -1562,6 +1562,9 @@ int plugin_init(int *argc, char **argv, int flags)
   DBUG_ASSERT(strcmp(list_of_services[4].name, "debug_sync_service") == 0);
   list_of_services[4].service= *(void**)&debug_sync_C_callback_ptr;
 
+  /* prepare encryption_keys service */
+  finalize_encryption_plugin(0);
+
   mysql_mutex_lock(&LOCK_plugin);
 
   initialized= 1;
diff --git a/sql/sql_plugin_services.h b/sql/sql_plugin_services.h
index 8deac855a53..768797a4381 100644
--- a/sql/sql_plugin_services.h
+++ b/sql/sql_plugin_services.h
@@ -139,15 +139,6 @@ static struct wsrep_service_st wsrep_handler = {
   wsrep_unlock_rollback
 };
 
-static struct encryption_keys_service_st encryption_keys_handler=
-{
-  get_latest_encryption_key_version,
-  has_encryption_key,
-  get_encryption_key,
-  encrypt_data,
-  decrypt_data
-};
-
 static struct thd_specifics_service_st thd_specifics_handler=
 {
   thd_key_create,
-- 
cgit v1.2.1