summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNeilBrown <neilb@suse.de>2011-03-22 14:47:55 +1100
committerNeilBrown <neilb@suse.de>2011-03-22 14:47:55 +1100
commit38376c2e51fdc31b7e53d285729fb80b756d8d37 (patch)
tree664394c83196a477532afcfe0f76863ae4900809
parent0cf5ef67bbc8dad949af945ab5dd4b1d9df0d0a9 (diff)
downloadmdadm-38376c2e51fdc31b7e53d285729fb80b756d8d37.tar.gz
Monitor: handle v.quick removal of devices better.
If a device fails and then is removed before Monitor sees the failure, GET_DISK_INFO returns nothing so Monitor relies on mdstat info where '_' is incorrectly interpreted as 'a spare'. We should treat '_' as 'removed' - that is safer. Without this, a v.quick fail+remove gets reported as 'Failed' then 'SpareActive'. Signed-off-by: NeilBrown <neilb@suse.de>
-rw-r--r--Monitor.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/Monitor.c b/Monitor.c
index 3f211b5..c179566 100644
--- a/Monitor.c
+++ b/Monitor.c
@@ -607,7 +607,7 @@ static int check_array(struct state *st, struct mdstat_ent *mdstat,
} else if (mse && mse->pattern && i < (int)strlen(mse->pattern)) {
switch(mse->pattern[i]) {
case 'U': newstate = 6 /* ACTIVE/SYNC */; break;
- case '_': newstate = 0; break;
+ case '_': newstate = 8 /* REMOVED */; break;
}
disc.major = disc.minor = 0;
}