diff options
author | Krzysztof Wojcik <krzysztof.wojcik@intel.com> | 2011-06-23 12:06:47 +1000 |
---|---|---|
committer | NeilBrown <neilb@suse.de> | 2011-06-23 12:06:47 +1000 |
commit | 2d3603ba0cb497429d2841d2fb4a5e36879e808b (patch) | |
tree | 899bc6fc7ab59828207e804c72fbb39a55c3d7a7 | |
parent | c281a8041977cdd4bd7eaed4e1fbead50b5640e6 (diff) | |
download | mdadm-2d3603ba0cb497429d2841d2fb4a5e36879e808b.tar.gz |
Show DELAYED, PENDING status of resync process in "--detail"
Initially there is no proper translation mdstat's DELAYED/PENDING processes
to "--detail" output.
For example, if we have recover=DELAYED in mdstat, "--detail"
shows "State: recovering" and "Rebuild Status = 0%".
It was incorrect in case of process waiting on checkpoint different
than 0%. In fact rebuild status is differnt than 0% and user is misled.
The patch fix the problem. Current "--detail" command shows
in the exampe: "State: recovering (DELAYED)" and no information
about precentage.
Signed-off-by: Krzysztof Wojcik <krzysztof.wojcik@intel.com>
Signed-off-by: NeilBrown <neilb@suse.de>
-rw-r--r-- | Detail.c | 18 | ||||
-rw-r--r-- | mdadm.h | 2 | ||||
-rw-r--r-- | mdstat.c | 8 |
3 files changed, 15 insertions, 13 deletions
@@ -372,11 +372,13 @@ int Detail(char *dev, int brief, int export, int test, char *homehost) else st = ", degraded"; - printf(" State : %s%s%s%s\n", - (array.state&(1<<MD_SB_CLEAN))?"clean":"active", - st, - (!e || e->percent < 0) ? "" : sync_action[e->resync], - larray_size ? "": ", Not Started"); + printf(" State : %s%s%s%s%s%s \n", + (array.state&(1<<MD_SB_CLEAN))?"clean":"active", st, + (!e || (e->percent < 0 && e->percent != PROCESS_PENDING && + e->percent != PROCESS_DELAYED)) ? "" : sync_action[e->resync], + larray_size ? "": ", Not Started", + e->percent == PROCESS_DELAYED ? " (DELAYED)": "", + e->percent == PROCESS_PENDING ? " (PENDING)": ""); } if (array.raid_disks) printf(" Active Devices : %d\n", array.active_disks); @@ -416,10 +418,8 @@ int Detail(char *dev, int brief, int export, int test, char *homehost) } if (e && e->percent >= 0) { - printf(" Re%s Status : %d%% complete\n", - (st && st->sb && info->reshape_active)? - "shape":"build", - e->percent); + static char *sync_action[] = {"Rebuild", "Resync", "Reshape", "Check"}; + printf(" %7s Status : %d%% complete\n", sync_action[e->resync], e->percent); is_rebuilding = 1; } free_mdstat(ms); @@ -1345,3 +1345,5 @@ static inline int xasprintf(char **strp, const char *fmt, ...) { #define PATH_MAX 4096 #endif +#define PROCESS_DELAYED -2 +#define PROCESS_PENDING -3 @@ -257,10 +257,10 @@ struct mdstat_ent *mdstat_read(int hold, int start) if (strncmp(w, "check", 5)==0) ent->resync = 3; - if (l > 8 && strcmp(w+l-8, "=DELAYED")) - ent->percent = 0; - if (l > 8 && strcmp(w+l-8, "=PENDING")) - ent->percent = 0; + if (l > 8 && strcmp(w+l-8, "=DELAYED") == 0) + ent->percent = PROCESS_DELAYED; + if (l > 8 && strcmp(w+l-8, "=PENDING") == 0) + ent->percent = PROCESS_PENDING; } else if (ent->percent == -1 && w[0] >= '0' && w[0] <= '9' && |