summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNeilBrown <neilb@suse.com>2015-07-24 16:11:23 +1000
committerNeilBrown <neilb@suse.com>2015-07-24 16:11:23 +1000
commit27aefbdb3d52b9a4f4299b931003e4a8760b5dc2 (patch)
tree3a16c344866d024a4b4d3d3defa236cb063e7325
parentd8f82d1d88f83a706478e2d1af3736032a018421 (diff)
downloadmdadm-27aefbdb3d52b9a4f4299b931003e4a8760b5dc2.tar.gz
Don't ignore return value from read and write
New gcc sometimes complains about this. Signed-off-by: NeilBrown <neilb@suse.com>
-rw-r--r--managemon.c4
-rw-r--r--xmalloc.c24
2 files changed, 19 insertions, 9 deletions
diff --git a/managemon.c b/managemon.c
index ec4586b..6d1b3d8 100644
--- a/managemon.c
+++ b/managemon.c
@@ -410,7 +410,9 @@ static int sysfs_open2(char *devnum, char *name, char *attr)
* never needs too.
*/
char buf[200];
- read(fd, buf, sizeof(buf));
+ if (read(fd, buf, sizeof(buf)) < 0)
+ /* pretend not to ignore return value */
+ return fd;
}
return fd;
}
diff --git a/xmalloc.c b/xmalloc.c
index 75ae4e2..8b3f78a 100644
--- a/xmalloc.c
+++ b/xmalloc.c
@@ -35,42 +35,50 @@ void *xmalloc(size_t len)
{
void *rv = malloc(len);
char *msg;
+ int n;
if (rv)
return rv;
msg = ": memory allocation failure - aborting\n";
- write(2, Name, strlen(Name));
- exit(4+!!write(2, msg, strlen(msg)));
+ n = write(2, Name, strlen(Name));
+ n += write(2, msg, strlen(msg));
+ exit(4+!!n);
}
void *xrealloc(void *ptr, size_t len)
{
void *rv = realloc(ptr, len);
char *msg;
+ int n;
if (rv)
return rv;
msg = ": memory allocation failure - aborting\n";
- write(2, Name, strlen(Name));
- exit(4+!!write(2, msg, strlen(msg)));
+ n = write(2, Name, strlen(Name));
+ n += write(2, msg, strlen(msg));
+ exit(4+!!n);
}
void *xcalloc(size_t num, size_t size)
{
void *rv = calloc(num, size);
char *msg;
+ int n;
if (rv)
return rv;
msg = ": memory allocation failure - aborting\n";
- write(2, Name, strlen(Name));
- exit(4+!!write(2, msg, strlen(msg)));
+ n = write(2, Name, strlen(Name));
+ n += write(2, msg, strlen(msg));
+ exit(4+!!n);
}
char *xstrdup(const char *str)
{
char *rv = strdup(str);
char *msg;
+ int n;
if (rv)
return rv;
msg = ": memory allocation failure - aborting\n";
- write(2, Name, strlen(Name));
- exit(4+!!write(2, msg, strlen(msg)));
+ n = write(2, Name, strlen(Name));
+ n += write(2, msg, strlen(msg));
+ exit(4+!!n);
}