Don't leave stale data on failed set attempt.

On a set that fails to allocate memory, remove any existing value for
the key.  Presumably, if a user was attempting to overwrite a cache
entry for whateer reason, that should at the very least be considered
an invalidation.

This catches the binary protocl up to the text wrt
5f54ede879939a160168fabbc8cfc462f28e0004.

1 files changed, 11 insertions, 0 deletions

diff --git a/memcached.c b/memcached.c
index 286d7e7..0baeb5e 100644
--- a/memcached.c
+++ b/memcached.c
@@ -1562,6 +1562,17 @@ static void process_bin_update(conn *c) {
         } else {
             write_bin_error(c, PROTOCOL_BINARY_RESPONSE_ENOMEM, vlen);
         }
+
+        /* Avoid stale data persisting in cache because we failed alloc.
+         * Unacceptable for SET. Anywhere else too? */
+        if (c->cmd == PROTOCOL_BINARY_CMD_SET) {
+            it = item_get(key, nkey);
+            if (it) {
+                item_unlink(it);
+                item_remove(it);
+            }
+        }
+
         /* swallow the data line */
         c->write_and_go = conn_swallow;
         return;