From 6107b922d633c09d0de7f9b86bac209255a172ad Mon Sep 17 00:00:00 2001 From: dormando Date: Thu, 24 Aug 2017 00:32:15 -0700 Subject: stats cachedump: always dump COLD LRU was defaulting to HOT, but HOT can be empty pretty easily and this can be confusing. --- items.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'items.c') diff --git a/items.c b/items.c index ccde768..c339c3a 100644 --- a/items.c +++ b/items.c @@ -563,7 +563,6 @@ int do_item_replace(item *it, item *new_it, const uint32_t hv) { * The data could possibly be overwritten, but this is only accessing the * headers. * It may not be the best idea to leave it like this, but for now it's safe. - * FIXME: only dumps the hot LRU with the new LRU's. */ char *item_cachedump(const unsigned int slabs_clsid, const unsigned int limit, unsigned int *bytes) { unsigned int memlimit = 2 * 1024 * 1024; /* 2MB max response size */ @@ -575,8 +574,7 @@ char *item_cachedump(const unsigned int slabs_clsid, const unsigned int limit, u char key_temp[KEY_MAX_LENGTH + 1]; char temp[512]; unsigned int id = slabs_clsid; - if (!settings.lru_segmented) - id |= COLD_LRU; + id |= COLD_LRU; pthread_mutex_lock(&lru_locks[id]); it = heads[id]; -- cgit v1.2.1