diff options
| author | Samuel Pitoiset <samuel.pitoiset@gmail.com> | 2023-02-27 10:49:16 +0100 |
|---|---|---|
| committer | Eric Engestrom <eric@engestrom.ch> | 2023-03-08 18:00:13 +0000 |
| commit | 283143c14321a527e9079c8094dadfd2f39c3fec (patch) | |
| tree | acee0f6268ff1c44a4c6ac69f50a88f277997512 | |
| parent | e4ffd343abc3c266122cc26e1e3624e940cfd4d9 (diff) | |
| download | mesa-283143c14321a527e9079c8094dadfd2f39c3fec.tar.gz | |
radv: fix flushing non-coherent images in EndCommandBuffer()
The condition was inverted.
This doesn't fix anything known.
Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21549>
(cherry picked from commit 7c62f6fa01d7c0d9d7eabec1c545950af20d0c92)
| -rw-r--r-- | .pick_status.json | 2 | ||||
| -rw-r--r-- | src/amd/vulkan/radv_cmd_buffer.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/.pick_status.json b/.pick_status.json index d304994c412..b6def48f583 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -4270,7 +4270,7 @@ "description": "radv: fix flushing non-coherent images in EndCommandBuffer()", "nominated": true, "nomination_type": 0, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": null }, diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 6e47c467e28..ce0dd902de5 100644 --- a/src/amd/vulkan/radv_cmd_buffer.c +++ b/src/amd/vulkan/radv_cmd_buffer.c @@ -5283,7 +5283,7 @@ radv_EndCommandBuffer(VkCommandBuffer commandBuffer) /* Flush noncoherent images on GFX9+ so we can assume they're clean on the start of a * command buffer. */ - if (cmd_buffer->state.rb_noncoherent_dirty && can_skip_buffer_l2_flushes(cmd_buffer->device)) + if (cmd_buffer->state.rb_noncoherent_dirty && !can_skip_buffer_l2_flushes(cmd_buffer->device)) cmd_buffer->state.flush_bits |= radv_src_access_flush( cmd_buffer, VK_ACCESS_2_COLOR_ATTACHMENT_WRITE_BIT | |