From bccb7a8eb8f13fc747f5198ee0d77ecaf1b77be7 Mon Sep 17 00:00:00 2001 From: Nirbheek Chauhan Date: Sun, 3 Dec 2017 20:20:31 +0530 Subject: unit tests: Skip coverage properly with clang --- run_unittests.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/run_unittests.py b/run_unittests.py index 2cb276cde..ff0ac12fb 100755 --- a/run_unittests.py +++ b/run_unittests.py @@ -2249,8 +2249,9 @@ class LinuxlikeTests(BasePlatformTests): raise unittest.SkipTest('gcovr not found') if not shutil.which('genhtml'): raise unittest.SkipTest('genhtml not found') - if 'clang' in os.environ.get('CC', '') and os.environ.get('TRAVIS_OS_NAME', '') == 'linux': - raise unittest.SkipTest('Gcovr has a bug and does not work with Clang in the CI environment.') + if 'clang' in os.environ.get('CC', ''): + # We need to use llvm-cov instead of gcovr with clang + raise unittest.SkipTest('Coverage does not work with clang right now, help wanted!') testdir = os.path.join(self.common_test_dir, '1 trivial') self.init(testdir, ['-Db_coverage=true']) self.build() -- cgit v1.2.1