diff options
author | Elijah Newren <newren gmail com> | 2006-10-01 21:37:00 +0000 |
---|---|---|
committer | Elijah Newren <newren@src.gnome.org> | 2006-10-01 21:37:00 +0000 |
commit | bd740c219a3733830be4f117c081438ed80a16ca (patch) | |
tree | 344a8568827568c2cfe062ffcad889fa918afbb5 | |
parent | 8fbb70ac22a74b232b87b759d95fd6a4278c005e (diff) | |
download | metacity-bd740c219a3733830be4f117c081438ed80a16ca.tar.gz |
surround the XDeleteProperty() call with a
2006-10-01 Elijah Newren <newren gmail com>
* src/window-props.c (set_title_text): surround the
XDeleteProperty() call with a
meta_error_trap_push/meta_error_trap_pop pair to prevent a crash
when closing a remote instance of gedit (and perhaps other apps).
#358514.
-rw-r--r-- | ChangeLog | 8 | ||||
-rw-r--r-- | src/window-props.c | 11 |
2 files changed, 16 insertions, 3 deletions
@@ -1,5 +1,13 @@ 2006-10-01 Elijah Newren <newren gmail com> + * src/window-props.c (set_title_text): surround the + XDeleteProperty() call with a + meta_error_trap_push/meta_error_trap_pop pair to prevent a crash + when closing a remote instance of gedit (and perhaps other apps). + #358514. + +2006-10-01 Elijah Newren <newren gmail com> + Fix longstanding focus bug with mouse (not sloppy) focus mode with popup override-redirect windows, particularly mozilla and firefox's location bar autocompletion. #357695. diff --git a/src/window-props.c b/src/window-props.c index daf4c03c..92026e08 100644 --- a/src/window-props.c +++ b/src/window-props.c @@ -22,6 +22,7 @@ #include <config.h> #include "window-props.h" +#include "errors.h" #include "xprops.h" #include "frame.h" #include "group.h" @@ -248,9 +249,13 @@ set_title_text (MetaWindow *window, /* Bug 330671 -- Don't forget to clear _NET_WM_VISIBLE_(ICON_)NAME */ if (!modified && previous_was_modified) - XDeleteProperty (window->display->xdisplay, - window->xwindow, - atom); + { + meta_error_trap_push (window->display); + XDeleteProperty (window->display->xdisplay, + window->xwindow, + atom); + meta_error_trap_pop (window->display, FALSE); + } return modified; } |