summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHavoc Pennington <hp@pobox.com>2002-03-07 03:46:12 +0000
committerHavoc Pennington <hp@src.gnome.org>2002-03-07 03:46:12 +0000
commitfdb20df78bb76ca160321f9b1fcfb72198a6e9f9 (patch)
treebb0d2b03ab2fa94a0fd0f2738076a83d4409f2a4
parent262e6fab273e1c9716854bd3034899b05a969b1a (diff)
downloadmetacity-fdb20df78bb76ca160321f9b1fcfb72198a6e9f9.tar.gz
add some assertions
2002-03-06 Havoc Pennington <hp@pobox.com> * src/core.c (meta_core_get_grab_frame): add some assertions * src/menu.c (meta_window_menu_new): make another warning into a verbose * src/display.c (meta_change_button_grab): use verbose rather than warning to log failures to grab button, since these are typically BadWindow from a destroyed window.
-rw-r--r--ChangeLog11
-rw-r--r--src/core.c4
-rw-r--r--src/display.c2
-rw-r--r--src/menu.c2
4 files changed, 17 insertions, 2 deletions
diff --git a/ChangeLog b/ChangeLog
index 41925214..a684d482 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,14 @@
+2002-03-06 Havoc Pennington <hp@pobox.com>
+
+ * src/core.c (meta_core_get_grab_frame): add some assertions
+
+ * src/menu.c (meta_window_menu_new): make another warning
+ into a verbose
+
+ * src/display.c (meta_change_button_grab): use verbose rather than
+ warning to log failures to grab button, since these are typically
+ BadWindow from a destroyed window.
+
2002-03-06 Havoc Pennington <hp@redhat.com>
* src/frames.c (meta_frames_manage_window): use hash_table_replace
diff --git a/src/core.c b/src/core.c
index 631f46cd..4f6f7b0e 100644
--- a/src/core.c
+++ b/src/core.c
@@ -525,6 +525,10 @@ meta_core_get_grab_frame (Display *xdisplay)
display = meta_display_for_x_display (xdisplay);
+ g_assert (display != NULL);
+ g_assert (display->grab_window != NULL);
+ g_assert (display->grab_window->display->xdisplay == xdisplay);
+
if (display->grab_op != META_GRAB_OP_NONE &&
display->grab_window->frame)
return display->grab_window->frame->xwindow;
diff --git a/src/display.c b/src/display.c
index 2e387854..c40a8523 100644
--- a/src/display.c
+++ b/src/display.c
@@ -2091,7 +2091,7 @@ meta_change_button_grab (MetaDisplay *display,
result = meta_error_trap_pop (display);
if (result != Success)
- meta_warning ("Failed to grab button %d with mask 0x%x for window 0x%lx error code %d\n",
+ meta_verbose ("Failed to grab button %d with mask 0x%x for window 0x%lx error code %d\n",
button, modmask | ignored_mask, xwindow, result);
++ignored_mask;
diff --git a/src/menu.c b/src/menu.c
index a803c0c8..59a9e7a3 100644
--- a/src/menu.c
+++ b/src/menu.c
@@ -281,7 +281,7 @@ meta_window_menu_new (MetaFrames *frames,
if (ops & META_MENU_OP_WORKSPACES)
{
- meta_warning ("Creating %d-workspace menu current %d\n",
+ meta_verbose ("Creating %d-workspace menu current space %d\n",
n_workspaces, active_workspace);
if (n_workspaces > 0)