minimised windows are necessarily obscured.

2008-10-22  Thomas Thurman  <tthurman@gnome.org>

        * src/core/window.c (meta_window_set_demands_attention): minimised
          windows are necessarily obscured.


svn path=/trunk/; revision=3971

2 files changed, 26 insertions, 12 deletions

diff --git a/ChangeLog b/ChangeLog
index a22d0519..1faf09d5 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 2008-10-22  Thomas Thurman  <tthurman@gnome.org>
 
+        * src/core/window.c (meta_window_set_demands_attention): minimised
+          windows are necessarily obscured.
+
+2008-10-22  Thomas Thurman  <tthurman@gnome.org>
+
         Slight transformation of the x-macros used in keybindings
         to make them clearer: write handler names out in full
         because the old suffix system was confusing to people
diff --git a/src/core/window.c b/src/core/window.c
index e4bb13b6..f4cd5931 100644
--- a/src/core/window.c
+++ b/src/core/window.c
@@ -8062,6 +8062,10 @@ meta_window_set_demands_attention (MetaWindow *window)
       /* windows on other workspaces are necessarily obscured */
       obscured = TRUE;
     }
+  else if (window->minimized)
+    {
+      obscured = TRUE;
+    }
   else
     {
       meta_window_get_outer_rect (window, &candidate_rect);
@@ -8086,21 +8090,26 @@ meta_window_set_demands_attention (MetaWindow *window)
                 }
             }
         }
-      /* If the window's in full view, there's no point setting the flag. */
-  
+    }
+
+  if (obscured)
+    {
       meta_topic (META_DEBUG_WINDOW_OPS,
-          "Not marking %s as needing attention because it's in full view\n",
-          window->desc);
-      return;
+                  "Marking %s as needing attention\n",
+                  window->desc);
+
+      window->wm_state_demands_attention = TRUE;
+      set_net_wm_state (window);
     }
-    
-  /* Otherwise, go ahead and set the flag. */
-  
-  meta_topic (META_DEBUG_WINDOW_OPS,
-      "Marking %s as needing attention\n", window->desc);
+  else
+    {
+      /* If the window's in full view, there's no point setting the flag. */
 
-  window->wm_state_demands_attention = TRUE;
-  set_net_wm_state (window);
+      meta_topic (META_DEBUG_WINDOW_OPS,
+                 "Not marking %s as needing attention because "
+                 "it's in full view\n",
+                 window->desc);
+    }
 }
 
 void