summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* Patch from jylefort@FreeBSD.org to prevent a crash when changingElijah Newren2006-05-151-14/+14
| | | | | | | | 2006-05-15 Elijah Newren <newren gmail com> * src/screen.c (reload_xinerama_infos): Patch from jylefort@FreeBSD.org to prevent a crash when changing resolution. Fixes #340847.
* Clear _NET_WM_VISIBLE_NAME (and the ICON_ equivalent) when no longer beingElijah Newren2006-05-153-13/+37
| | | | | | | | | | | | | | | 2006-05-15 Elijah Newren <newren gmail com> Clear _NET_WM_VISIBLE_NAME (and the ICON_ equivalent) when no longer being used. Fixes #330671. * src/window.[ch] (struct MetaWindow): new using_net_wm_visible_name and using_net_wm_visible_icon_name bits, (meta_window_new_with_attrs): initialize these new bits to false * src/window-props.c (set_title_text, set_window_title, set_icon_title): if the _NET_WM_VISIBLE_(ICON_)NAME property was previously set but doesn't need to be this time, make sure to clear it
* plug a small leak.Paolo Borelli2006-05-151-4/+4
| | | | | | 2006-05-15 Paolo Borelli <pborelli@katamail.com> * src/prefs.c (update_binding): plug a small leak.
* Patch from Dan Sanders to fix #334899.Elijah Newren2006-04-171-1/+7
| | | | | | | | | | | 2006-04-16 Elijah Newren <newren gmail com> Patch from Dan Sanders to fix #334899. * window.c (meta_window_new_with_attrs): Unminimize ancestors of new windows when mapped; this prevents e.g. confirmation windows from causing applications to appear locked when closing via the window list.
* Patch from Dan Sanders to fix #335076.Elijah Newren2006-04-162-4/+29
| | | | | | | | | | | 2006-04-15 Elijah Newren <newren gmail com> Patch from Dan Sanders to fix #335076. * src/core.c (meta_core_maximize, meta_core_toggle_maximize, meta_core_unmaximize): * src/window.c (meta_window_client_message): Raise windows on maximize/unmaximize.
* Patch from Ron Yorston to add a focus_new_windows option. Default isElijah Newren2006-04-136-8/+92
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2006-04-12 Elijah Newren <newren gmail com> Patch from Ron Yorston to add a focus_new_windows option. Default is 'smart' (focus by default but normal focus-stealing-prevention can kick in); 'strict' is current other choice (like 'smart' except that programs launched by the terminal will not be focused). Fixes remainder of #326159. Should also close #152004 and a bunch of others. * src/common.h: Add a MetaFocusNewWindows enum giving the current types allowed * src/display.h: Update docs on allow_terminal_deactivation to note that it is only relevant when focus_new_windows is 'strict' * src/metacity.schemas.in: add the new gconf key and explanation * src/prefs.[ch] (#define KEY_FOCUS_NEW_WINDOWS, static gboolean focus_new_windows, update_focus_new_windows, meta_prefs_init, change_notify, meta_prefs_get_focus_new_windows, meta_preference_to_string): Add all the normal preference handling stuff for this new focus-new-windows option. * src/window.c (window_state_on_map, meta_window_set_user_time): Don't focus windows launched from a terminal
* Fix constraints bug causing negative width windows and crashes. #336651Elijah Newren2006-04-021-1/+3
| | | | | | | | | | | 2006-04-02 Elijah Newren <newren gmail com> Fix constraints bug causing negative width windows and crashes. #336651 * src/constraints.c (constrain_partially_onscreen): Don't accidentally shove & resize the window by requiring more pixels to be onscreen than the size of the window.
* Fix grouping in the presence of ancestors; caught by Björn. #336184Elijah Newren2006-03-303-9/+23
| | | | | | | | | | | | | | | | | 2006-03-29 Elijah Newren <newren gmail com> Fix grouping in the presence of ancestors; caught by Björn. #336184 * src/group.c (meta_window_compute_group): Use new meta_window_find_root_ancestor() function to get ancestor; for the computed group, use the ancestor's group instead of the ancestor itself * src/window.[ch] (meta_window_find_root_ancestor, meta_window_raise): split meta_window_find_root_ancestor() functionality of meta_window_raise() and make it available elsewhere
* use g_str_has_prefix instead of a local copy of the function.Paolo Borelli2006-03-251-24/+4
| | | | | | | 2006-03-25 Paolo Borelli <pborelli@katamail.com> * src/prefs.c: use g_str_has_prefix instead of a local copy of the function.
* Always set _NET_WM_STATE when a window is shown or hidden, even if itThomas Thurman2006-03-171-20/+14
| | | | | | | | | | 2006-03-16 Thomas Thurman <thomas@thurman.org.uk> Always set _NET_WM_STATE when a window is shown or hidden, even if it wasn't mapped. * src/window.c (meta_window_hide, meta_window_show): call set_net_wm_state unconditionally
* Add debugging information for edge resistanceElijah Newren2006-03-173-27/+65
| | | | | | | | | | | | | | | | 2006-03-16 Elijah Newren <newren gmail com> Add debugging information for edge resistance * src/edge-resistance.c (cache_edges): print out the edges that are being cached if in verbose mode, (meta_window_edge_resistance_for_move, meta_window_edge_resistance_for_resize): if edge resistance kicked in then print out a message about it * src/util.c: * src/util.h: Add META_DEBUG_EDGE_RESISTANCE to MetaDebugTopic enum list
* Marking string for translation. Closes #334332Thomas James Alexander Thurman2006-03-121-1/+1
|
* Only unmaximise window before freeing if the window is actually maximised.Ryan Lortie2006-03-061-1/+2
| | | | | | | 2006-03-06 Ryan Lortie <desrt@desrt.ca> * src/window.c (meta_window_free): Only unmaximise window before freeing if the window is actually maximised. #333563.
* Patch from Thomas Thurman to prevent setting cycle_windows to keybindingsElijah Newren2006-02-273-0/+102
| | | | | | | | | | | | | | 2006-02-27 Elijah Newren <newren gmail com> Patch from Thomas Thurman to prevent setting cycle_windows to keybindings that won't work. #329676 * src/prefs.c (update_binding): Make sure that bindings which require a modifier key are set to a keybinding with one or else that the binding is reverted. * src/ui.[ch] (meta_ui_accelerator_name): New function
* Patch from Thomas Thurman to work around buggy application grouping withElijah Newren2006-02-272-2/+17
| | | | | | | | | | | | | 2006-02-27 Elijah Newren <newren gmail com> Patch from Thomas Thurman to work around buggy application grouping with transient windows. #328211 * src/group.c (meta_window_compute_group): Put transients in the same group with their parent, always. * src/window.c (update_transient_for): Update group too
* Insert #ifdef's to make it build againSøren Sandmann2006-02-161-3/+9
| | | | | | Thu Feb 16 15:54:48 2006 Søren Sandmann <sandmann@redhat.com> * src/compositor.c: Insert #ifdef's to make it build again
* Add code to destroy compositor. Implement unmanage_screen() functionality.GNOME_2_14_BRANCHPOINTSøren Sandmann2006-02-152-457/+497
| | | | | | | Wed Feb 15 18:42:03 2006 Søren Sandmann <sandmann@redhat.com> * src/compositor.[ch]: Add code to destroy compositor. Implement unmanage_screen() functionality.
* Add unused wobbly unminimize animation by KristianSøren Sandmann2006-02-153-55/+611
| | | | | | | | | | | | | | | Wed Feb 15 14:47:50 2006 Søren Sandmann <sandmann@redhat.com> * src/compositor.c (meta_compositor_unminimize): Add unused wobbly unminimize animation by Kristian * src/compositor.c (meta_compositor_minimize): Add wobbly minimize animation by Kristian. * src/compositor.c: Add support for turning updates on and off. * src/window.c (meta_window_move_resize_internal): Use sync counter to make composited resizing tear free
* Patch from Jens Granseuer to fix more build issues with gcc 2.95. #331166.Elijah Newren2006-02-141-2/+4
| | | | | | | | | | 2006-02-14 Elijah Newren <newren gmail com> Patch from Jens Granseuer to fix more build issues with gcc 2.95. #331166. * src/prefs.c (meta_prefs_init): Remove C99 style variable initiailization
* We had that prev_window code in multiple places and it was all identical.Elijah Newren2006-02-131-23/+4
| | | | | | | | | 2006-02-13 Elijah Newren <newren gmail com> * src/keybindings.c (process_tab_grab): We had that prev_window code in multiple places and it was all identical. Let's just stick it in one place to make the function easier to read.
* Allow alt-escape to cancel alt-tabbing, and vice versa. Fixes #141425.Thomas Thurman2006-02-131-3/+52
| | | | | | | | 2006-02-13 Thomas Thurman <thomas thurman org uk> * src/keybindings.c (process_tab_grab): Allow alt-escape to cancel alt-tabbing, and vice versa. Fixes #141425.
* Disable alt-f7 if a window can't be moved, and alt-f8 if it can't beThomas Thurman2006-02-121-2/+2
| | | | | | | | | | 2006-02-11 Thomas Thurman <thomas thurman org uk> Disable alt-f7 if a window can't be moved, and alt-f8 if it can't be resized. Fixes #328920. * src/keybindings.c (handle_begin_move, handle_begin_resize): check window->has_*_func before beginning operation
* actually use META_LAYER_TOP but just manually make it equal toElijah Newren2006-02-122-2/+2
| | | | | | | | | | 2006-02-11 Elijah Newren <newren gmail com> * src/stack.h (enum MetaStackLayer): * src/stack.c (get_standalone_layer): actually use META_LAYER_TOP but just manually make it equal to META_LAYER_DOCK. Add a note point to the EWMH for why we do this. #330717
* remove this legacy cruft that we stopped using years agoElijah Newren2006-02-111-11/+0
| | | | | | | 2006-02-11 Elijah Newren <newren gmail com> * src/window.c (enum GnomeWinLayer): remove this legacy cruft that we stopped using years ago
* Avoid a memory leak when checking which workspace(s) a window is on. FixesThomas Thurman2006-02-113-1/+5
| | | | | | | | | | | | | | | 2006-02-10 Thomas Thurman <thomas thurman org uk> Avoid a memory leak when checking which workspace(s) a window is on. Fixes #322059. * src/workspace.h (struct MetaWorkspace): * src/workspace.c (meta_workspace_new, meta_workspace_free): added list_containing_self member to MetaWorkspace * src/window.c (meta_window_get_workspaces): use window->workspace->list_containing_self instead of allocating (and leaking) such a list on the fly.
* add messages to explain that warnings are harmlessThomas Thurman2006-02-111-0/+6
| | | | | | | 2006-02-09 Thomas Thurman <thomas thurman org uk> * src/testboxes.c (test_regions_okay, test_clamping_to_region): add messages to explain that warnings are harmless
* Wrap fade code in #ifdef HAVE_COMPOSITE_EXTENSIONSSoeren Sandmann2006-02-071-0/+2
| | | | | | Tue Feb 7 00:58:05 2006 Soeren Sandmann <sandmann@redhat.com> * src/compositor.c: Wrap fade code in #ifdef HAVE_COMPOSITE_EXTENSIONS
* New fancy minimize animation. Fade windows in and out.Søren Sandmann2006-02-061-43/+413
| | | | | | | | | Mon Feb 6 17:45:39 2006 Søren Sandmann <sandmann@redhat.com> * src/compositor.c: New fancy minimize animation. Fade windows in and out. 2
* produce warning when invalid events with no timestamp are received, ratherThomas Thurman2006-02-031-3/+15
| | | | | | | | 2006-02-03 Thomas Thurman <thomas thurman org uk> * src/display.c (event_callback): produce warning when invalid events with no timestamp are received, rather than failing an assertion
* update the pixmap. (update) print out framerate. (dump_stacking_order) newSøren Sandmann2006-02-021-52/+182
| | | | | | | | | | | Thu Feb 2 17:58:22 2006 Søren Sandmann <sandmann@redhat.com> * compositor.c (process_map): update the pixmap. (update) print out framerate. (dump_stacking_order) new debug function. (meta_compositor_add_window) error trap fixes (MiniInfo): Make the minimize animation fade out.
* Track the active_screen, (event_callback): If the mouse enters a window onElijah Newren2006-01-302-3/+28
| | | | | | | | | | | | 2006-01-30 Elijah Newren <newren gmail com> * src/display.[ch] (struct MetaDisplay), meta_display_open, meta_display_set_input_focus_window, meta_display_focus_the_no_focus_window): Track the active_screen, (event_callback): If the mouse enters a window on a different screen, activate the default window on the new screen. May need to be modified for click-to-focus; we'll wait for feedback. Fixes #319348.
* change the order of the ||'ed items in the if to avoid using anElijah Newren2006-01-242-6/+9
| | | | | | | | | | | 2006-01-23 Elijah Newren <newren gmail com> * src/display.c (meta_display_check_threshold_reached): change the order of the ||'ed items in the if to avoid using an uninitialized value * src/prefs.c (meta_prefs_init): fix a couple uninitialized value problems
* Patch from Christian Kirbach to prevent a critical warning crasher whenElijah Newren2006-01-211-6/+14
| | | | | | | | | | | 2006-01-21 Elijah Newren <newren gmail com> Patch from Christian Kirbach to prevent a critical warning crasher when switching themes. #327847. * src/theme.c (meta_theme_free): since themes are only constructed as needed and may be NULL, check for that before freeing theme hash tables
* Patch from Dick Marinus to add a minimize double-click-titlebar-action;Elijah Newren2006-01-214-4/+21
| | | | | | | | | | | | 2006-01-21 Elijah Newren <newren gmail com> * src/common.h (enum MetaActionDoubleClickTitlebar): * src/frames.c (meta_frames_button_press_event): * src/prefs.c (action_double_click_titlebar_from_string): * src/metacity.schemas.in: Patch from Dick Marinus to add a minimize double-click-titlebar-action; slightly modified to also include a none action. #300210.
* fixed_directions is only meant for explicit user interactions; disable itElijah Newren2006-01-211-0/+14
| | | | | | | | | | 2006-01-20 Elijah Newren <newren gmail com> * src/constraints.c (setup_constraint_info): fixed_directions is only meant for explicit user interactions; disable it for everything else. There are other bugs and improvements that could be made with fixed_directions that I should be filing too, but at least put a FIXME there for now--I'm so lame. Fixes #327822.
* Avoid flashing when closing a maximized window. Fixes #317254.Elijah Newren2006-01-201-3/+18
| | | | | | | | | | | 2006-01-20 Elijah Newren <newren gmail com> Avoid flashing when closing a maximized window. Fixes #317254. * src/window.c (unmaximize_window_before_freeing): new function that just fixes the net_wm_state and sends a configure_notify, (meta_window_free): use unmaximize_window_before_freeing() instead of meta_window_unmaximize() to avoid flicker
* Fix unitialized value problem when in raise-on-click mode. Søren,Elijah Newren2006-01-202-3/+4
| | | | | | | | | | | | | | 2006-01-20 Elijah Newren <newren gmail com> Fix unitialized value problem when in raise-on-click mode. Søren, #327572. * src/display.c (meta_display_check_threshold_reached): make function be a no op if raise_on_click!=FALSE * src/display.h (struct MetaDisplay): point out that grab_initial_[xy] and grab_threshold_movement_reached are only for raise_on_click==FALSE mode.
* Patch from Søren to fix some reading-from-free'd-data errors. #327575Elijah Newren2006-01-201-1/+18
| | | | | | | | | | | | 2006-01-20 Elijah Newren <newren gmail com> Patch from Søren to fix some reading-from-free'd-data errors. #327575 * src/edge-resistance.c (meta_display_cleanup_edges): store the edges in a hash table so that we can still read their values within the loop from the other array they are stored in, then free them all at the end.
* Fix various initialization and default issues, especially forElijah Newren2006-01-202-17/+126
| | | | | | | | | | | | | | | | | | | | | | | | 2006-01-20 Elijah Newren <newren gmail com> Fix various initialization and default issues, especially for --disable-gconf. Make --disable-gconf actually work. #326661. * configure.in: Fix compilation with --disable-gconf * src/metacity.schemas.in: Add a note that if any defaults are changed in this file, src/prefs.c may need to be updated to reflect the change * src/prefs.c: set various static global vars to the right default value, (meta_prefs_init): get the titlebar_font and current_theme handled better when not using gconf, (struct MetaSimpleKeyMapping, screen_string_bindings, window_string_bindings): helper vars to allow some keybindings to work even without gconf, (init_bindings): initialize bindings for the without-gconf case too, (init_commands): make sure these are all NULL for the non-gconf case so that we don't access random memory, (init_workspace_names): just give these all a default name for the non-gconf case, (meta_prefs_change_workspace_name): actually change the name for the non-gconf case too
* More careful error handling of values returned by GConf. Fixes #326615.Elijah Newren2006-01-201-37/+51
| | | | | | | | | | | 2006-01-20 Elijah Newren <newren gmail com> More careful error handling of values returned by GConf. Fixes #326615. * src/prefs.c (get_bool): new helper function, (meta_prefs_init): use get_bool to handle the case of a gconf key not existing, (update_cursor_size): sanity check for sane values
* Prevent rapidly repeated visual bells from hanging metacity. FixesElijah Newren2006-01-202-5/+13
| | | | | | | | | | | | | | | 2006-01-20 Elijah Newren <newren gmail com> Prevent rapidly repeated visual bells from hanging metacity. Fixes #322032. * src/display.h (struct MetaDisplay): add a last_bell_time field, (XSERVER_TIME_IS_BEFORE_ASSUMING_REAL_TIMESTAMPS macro, XERVER_TIME_IS_BEFORE macro): add parentheses around usage of macro parameter * src/display.c (meta_display_open): initialize last_bell_time, (event_callback): don't allow more than one bell per second
* Patch from Kjartan Maraas to fix a lot of tiny issues (unused variableElijah Newren2006-01-2024-222/+105
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2006-01-20 Elijah Newren <newren gmail com> * src/async-getprop.c: * src/common.h: * src/display.c: * src/eggaccelerators.c: * src/frames.c: * src/gradient.c: * src/iconcache.c: * src/keybindings.c: * src/metaaccellabel.c: * src/place.c: * src/prefs.c: * src/preview-widget.c: * src/screen.c: * src/session.c: * src/stack.c: * src/tabpopup.c: * src/theme-viewer.c: * src/theme.c: * src/window-props.c: * src/window.c: * src/workspace.c: * src/tools/metacity-window-demo.c: * src/wm-tester/test-gravity.c: * src/wm-tester/test-resizing.c: * src/wm-tester/test-size-hints.c: Patch from Kjartan Maraas to fix a lot of tiny issues (unused variable removal, making unused variables used again, correction of types passed/declared for printf arguments, removal of unneeded breaks and returns, dead code removal, dead code revival, renaming to prevent shadowed variables, declaring unexported functions as static) spotted by the intel compiler. #321439
* Patch from Björn Lindqvist to fix #98340.Elijah Newren2006-01-201-24/+36
| | | | | | | | | | 2006-01-20 Elijah Newren <newren gmail com> Patch from Björn Lindqvist to fix #98340. * src/screen.c (meta_screen_ensure_tab_popup): Make sure an outline border is shown even if a window frame's width is 0. Also, correctly handle window outlines in showing desktop mode.
* Make minimize animation update again.Søren Sandmann2006-01-201-11/+36
| | | | | | Fri Jan 20 16:42:25 2006 Søren Sandmann <sandmann@redhat.com> * src/compositor.c: Make minimize animation update again.
* g_object_unref() rather than ws_region_unref().Søren Sandmann2006-01-191-2/+3
| | | | | | | Thu Jan 19 18:05:47 2006 Søren Sandmann <sandmann@redhat.com> * src/compositor.c (meta_compositor_manage_screen): g_object_unref() rather than ws_region_unref().
* Port to changes in libcmSøren Sandmann2006-01-191-49/+60
| | | | | | Thu Jan 19 16:50:50 2006 Søren Sandmann <sandmann@redhat.com> * src/compositor.c: Port to changes in libcm
* Port to changes in libcm.Søren Sandmann2006-01-171-29/+32
| | | | | | Tue Jan 17 17:25:29 2006 Søren Sandmann <sandmann@redhat.com> * src/compositor.c: Port to changes in libcm.
* manually define HOST_NAME_MAX if not already defined to fix SolarisElijah Newren2006-01-161-0/+4
| | | | | | | | 2006-01-16 Elijah Newren <newren gmail com> * src/window-props.c: manually define HOST_NAME_MAX if not already defined to fix Solaris compilation issue. Caught by Damien Carbery, patch from Havoc. #326745
* Really turn off draw-in-a-loop.Søren Sandmann2006-01-161-2/+3
| | | | | | | Mon Jan 16 11:55:20 2006 Søren Sandmann <sandmann@redhat.com> * src/compositor.c (meta_compositor_manage_screen): Really turn off draw-in-a-loop.
* If no valid window is found in the MRU list, then set focus to the desktopKyle Ambroff2006-01-161-1/+14
| | | | | | | | 2006-01-15 Kyle Ambroff <kambroff@csus.edu> * src/workspace.c (focus_ancestor_or_mru_window): If no valid window is found in the MRU list, then set focus to the desktop window. (#317405)