summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* window-props: re-add support for _NET_WM_PIDAlberts Muktupāvels2022-09-303-0/+30
| | | | | | | We will use _NET_WM_PID when xserver does not have XRes extension or its version is too old. This partially reverts 9135966673e9fd430b9e8252abdb9c946295e25b.
* display: check if XRes extension is availableAlberts Muktupāvels2022-09-302-0/+23
| | | | We are using XResQueryClientIds that is available in 1.2 version.
* window-props: define HAVE_SYS_TIME_HAlberts Muktupāvels2022-09-301-0/+1
| | | | https://gitlab.gnome.org/GNOME/libgtop/-/merge_requests/34
* icon-cache: reset origin if property change invalidates iconAlberts Muktupāvels2022-03-221-11/+16
| | | | | | | | Client theoretically can unset / remove icon. We need to reset origin to make sure we try to load icon from other sources. Test application that can be used to set/unset icons: https://gitlab.gnome.org/GNOME/libwnck/-/merge_requests/42
* icon-cache: make get_icon_invalidated staticAlberts Muktupāvels2022-03-222-2/+1
|
* window: remove incorrect mask checkAlberts Muktupāvels2022-03-221-5/+4
| | | | | | XResGetClientPid already checks for XRES_CLIENT_ID_PID_MASK and does that correctly. We were doing direct comparition that would fail if mask would include something else.
* icon-cache: remove support for KWM_WIN_ICONAlberts Muktupāvels2022-03-194-101/+2
| | | | | According to Debian Code Search only MPlayer sets this property (together with _NET_WM_ICON).
* tooltip: request client side decorationsAlberts Muktupāvels2021-10-224-1/+329
| | | | https://gitlab.gnome.org/GNOME/metacity/-/issues/25
* fix build with --disable-dependency-trackingZoltán Böszörményi2021-08-291-0/+2
| | | | | | | | | | | | | | | | | | | | With split build and source directories AND --disable-dependency-tracking (like the way Yocto builds are done) there's a reproducible make failure on my Fedora 33 build host: | Making all in src | make[2]: Entering directory '.../metacity/1_3.40.0-r0/build/src' | .../metacity/1_3.40.0-r0/recipe-sysroot-native/usr/bin/glib-mkenums --template ../../metacity-3.40.0/src/core/meta-enum-types.c.in ../../metacity-3.40.0/src/core/window-private.h ../../metacity-3.40.0/src/include/meta-compositor.h > \ | meta-enum-types.c.tmp && mv meta-enum-types.c.tmp core/meta-enum-types.c | .../metacity/1_3.40.0-r0/recipe-sysroot-native/usr/bin/glib-mkenums --template ../../metacity-3.40.0/src/core/meta-enum-types.h.in ../../metacity-3.40.0/src/core/window-private.h ../../metacity-3.40.0/src/include/meta-compositor.h > \ | meta-enum-types.h.tmp && mv meta-enum-types.h.tmp core/meta-enum-types.h | mv: cannot move 'meta-enum-types.c.tmp' to 'core/meta-enum-types.c'mv: cannot move 'meta-enum-types.h.tmp' to 'core/meta-enum-types.h': No such file or directory | : No such file or directory | make[2]: *** [Makefile:2240: core/meta-enum-types.c] Error 1 https://gitlab.gnome.org/GNOME/metacity/-/merge_requests/24 Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com>
* core: drop use of volatileAlberts Muktupāvels2021-08-211-1/+1
|
* window: offset gravity position by invisible bordersAlberts Muktupāvels2021-07-221-2/+15
| | | | https://gitlab.gnome.org/GNOME/metacity/-/issues/21
* main: use correct timestamp when closing displayAlberts Muktupāvels2021-07-191-2/+7
|
* main: add SIGINT handlerAlberts Muktupāvels2021-07-191-1/+14
| | | | | | | | | With this metacity will exit cleanly when hitting Ctrl + C. To preserve existing behaviour with XSMP do not change restart style hint to IfRunning. https://gitlab.gnome.org/GNOME/metacity/-/issues/21
* main: use g_unix_signal_add to add signal handlerAlberts Muktupāvels2021-07-191-35/+5
|
* session: always finish interactionAlberts Muktupāvels2021-07-191-0/+5
| | | | | | | | | | | After commits 0b3f45bb1bf8 and db37deb589ea SmcInteractDone and SmcSaveYourselfDone is only called if zenity dialog exits with 0 code. Finish interaction also when dialog is closed by pressing Cancel indicating that shutdown should be canceled. https://gitlab.gnome.org/GNOME/metacity/-/issues/20
* session: remove redundant assignmentAlberts Muktupāvels2021-07-191-1/+0
|
* window-props: don't set override-redirect window as parentAlberts Muktupāvels2021-06-211-0/+10
| | | | | | | | | | | | | | | | | | | | | | Before commit c656c658940d override-redirect windows was not registered with meta_display_register_x_window. This means that Metacity was treating WM_TRANSIENT_FOR hint as invalid if it was pointing to override-redirect window. EWMH specification [1] says that WM_TRANSIENT_FOR property is defined for managed windows and extends its usage for override-redirect windows. Client should set WM_TRANSIENT_FOR on override-redirect window if it is child/popup for another window. As specification does not say anyting about using override-redirect windows as parent for managed windows and because it causes crashes in Metacity ignore WM_TRANSIENT_FOR if it is pointing to override-redirect window. [1] https://specifications.freedesktop.org/wm-spec/wm-spec-latest.html#idm46291029654544 https://gitlab.gnome.org/GNOME/metacity/-/issues/18
* surface-xrender: restore opacity handlingAlberts Muktupāvels2021-06-171-1/+66
| | | | | | Commit 1021494e347da7045c1db834bf9e4f1b5e076f17 removed too much. https://gitlab.gnome.org/GNOME/metacity/-/issues/19
* compositor: enable xpresentAlberts Muktupāvels2021-04-131-1/+1
| | | | https://gitlab.gnome.org/GNOME/metacity/-/issues/13
* misc: remove Coverity annotationsAlberts Muktupāvels2021-03-193-7/+0
|
* bell: remove unused codeAlberts Muktupāvels2021-03-162-40/+0
|
* bell: remove tabsAlberts Muktupāvels2021-03-161-36/+41
|
* testboxes: fix test_find_closest_point_to_line testAlberts Muktupāvels2021-03-161-4/+12
| | | | Use g_assert_cmpfloat_with_epsilon to compare floating points.
* testboxes: use GRand to generate random numbersAlberts Muktupāvels2021-03-161-10/+9
| | | | Coverity CID: #1418268
* place: use GRand to generate random numbersAlberts Muktupāvels2021-03-161-3/+9
| | | | Coverity CID: #1445646
* display: add NULL check to fix coverity defectAlberts Muktupāvels2021-03-151-1/+1
| | | | | | | Coverity is right that window might be null but does not know that grab_op is not moving operation. Coverity CID: #1445663
* window: fix logically dead code defectAlberts Muktupāvels2021-03-151-3/+9
| | | | | | We assert that at least one of the two directions are set! Coverity CID: #1418266
* main: check g_setenv return valueAlberts Muktupāvels2021-03-141-1/+4
| | | | Coverity CID: #1502679
* core: suppress logically dead code defectAlberts Muktupāvels2021-03-141-0/+1
| | | | Coverity CID: #1445660
* place: use correct event to suppress defectsAlberts Muktupāvels2021-03-141-2/+2
| | | | Coverity CID: #1445646
* frames: use correct event to suppress defectAlberts Muktupāvels2021-03-141-1/+1
| | | | Coverity CID: #1445650
* place: suppress logically dead code defectsAlberts Muktupāvels2021-03-141-0/+6
| | | | | | Both enumeration values are handled outside of switch. Coverity CID: #1445661
* session: fix memory leakAlberts Muktupāvels2021-03-141-3/+1
| | | | Coverity CID: #1502682
* xprops: remove unneeded NULL checkAlberts Muktupāvels2021-03-141-5/+2
| | | | Coverity CID: #1418331
* frames: suppress logically dead code defectAlberts Muktupāvels2021-03-141-1/+5
| | | | | | | META_GRAB_OP_NONE enumeration value is intentionally added here to avoid compiler warning about unhandled value. Coverity CID: #1445650
* accellabel: simplify meta_accel_label_updateAlberts Muktupāvels2021-03-141-3/+0
|
* accellabel: remove signal_quote1 and signal_quote2Alberts Muktupāvels2021-03-142-4/+0
|
* accellabel: remove unneeded padding in class structAlberts Muktupāvels2021-03-141-6/+0
|
* accellabel: remove unused accel_seperatorAlberts Muktupāvels2021-03-142-4/+1
|
* stack-tracker: stop using GSliceAlberts Muktupāvels2021-03-141-5/+5
|
* core: use g_memdup2Alberts Muktupāvels2021-03-142-2/+2
|
* metacity-message: use gettext macros from glibAlberts Muktupāvels2021-03-141-5/+1
|
* util: use gettext macros from glibAlberts Muktupāvels2021-03-141-4/+1
|
* window: check XResQueryClientIds return valueAlberts Muktupāvels2020-10-221-5/+12
|
* session: check fcntl return valueAlberts Muktupāvels2020-10-211-3/+8
| | | | | | This function can fail. CID 1220275.
* compositor-xrender: use GRand to generate random numbersAlberts Muktupāvels2020-10-101-3/+9
|
* window: make window_is_terminal privateJasper St. Pierre2020-10-102-9/+5
|
* stack: don't ignore workspace in get_default_focus_windowAlberts Muktupāvels2020-10-103-7/+20
| | | | | | Commit 00b3e2af07a3 stopped using workspace argument. Redo that change to use passed in workspace instead of assuming it is always active workspace.
* compositor-vulkan: use enumeration type to find nickAlberts Muktupāvels2020-09-131-20/+9
|
* main: use enumeration type to find valueAlberts Muktupāvels2020-09-132-9/+13
|
View Lorry Controller Status