summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Gottlieb <daniel.gottlieb@mongodb.com>2019-10-03 18:40:38 +0000
committerevergreen <evergreen@mongodb.com>2019-10-03 18:40:38 +0000
commit5f8b8e01e867fa22c48636e754886dee8a84cf38 (patch)
treeaa1873de0e9a8765a829457875accb78ca14c328
parent48da27e3e5780b78debdf46661a94ad428fbecee (diff)
downloadmongo-5f8b8e01e867fa22c48636e754886dee8a84cf38.tar.gz
SERVER-43738: Remove bugprone-unused-raii in shard_key_pattern_test.cpp.
-rw-r--r--src/mongo/s/shard_key_pattern_test.cpp24
1 files changed, 12 insertions, 12 deletions
diff --git a/src/mongo/s/shard_key_pattern_test.cpp b/src/mongo/s/shard_key_pattern_test.cpp
index 36b0270861d..e8ab864f607 100644
--- a/src/mongo/s/shard_key_pattern_test.cpp
+++ b/src/mongo/s/shard_key_pattern_test.cpp
@@ -42,11 +42,11 @@ namespace {
using std::string;
TEST(ShardKeyPattern, SingleFieldShardKeyPatternsValidityCheck) {
- ShardKeyPattern(BSON("a" << 1));
- ShardKeyPattern(BSON("a" << 1.0f));
- ShardKeyPattern(BSON("a" << (long long)1L));
- ShardKeyPattern(BSON("a"
- << "hashed"));
+ ShardKeyPattern s1(BSON("a" << 1));
+ ShardKeyPattern s2(BSON("a" << 1.0f));
+ ShardKeyPattern s3(BSON("a" << (long long)1L));
+ ShardKeyPattern s4(BSON("a"
+ << "hashed"));
ASSERT_THROWS(ShardKeyPattern(BSONObj()), DBException);
ASSERT_THROWS(ShardKeyPattern(BSON("a" << -1)), DBException);
@@ -62,9 +62,9 @@ TEST(ShardKeyPattern, SingleFieldShardKeyPatternsValidityCheck) {
}
TEST(ShardKeyPattern, CompositeShardKeyPatternsValidityCheck) {
- ShardKeyPattern(BSON("a" << 1 << "b" << 1));
- ShardKeyPattern(BSON("a" << 1.0f << "b" << 1.0));
- ShardKeyPattern(BSON("a" << 1 << "b" << 1.0 << "c" << 1.0f));
+ ShardKeyPattern s1(BSON("a" << 1 << "b" << 1));
+ ShardKeyPattern s2(BSON("a" << 1.0f << "b" << 1.0));
+ ShardKeyPattern s3(BSON("a" << 1 << "b" << 1.0 << "c" << 1.0f));
ASSERT_THROWS(ShardKeyPattern(BSON("a" << 1 << "b" << -1)), DBException);
ASSERT_THROWS(ShardKeyPattern(BSON("a" << 1 << "b"
@@ -75,10 +75,10 @@ TEST(ShardKeyPattern, CompositeShardKeyPatternsValidityCheck) {
}
TEST(ShardKeyPattern, NestedShardKeyPatternsValidtyCheck) {
- ShardKeyPattern(BSON("a.b" << 1));
- ShardKeyPattern(BSON("a.b.c.d" << 1.0));
- ShardKeyPattern(BSON("a" << 1 << "c.d" << 1.0 << "e.f.g" << 1.0f));
- ShardKeyPattern(BSON("a" << 1 << "a.b" << 1.0 << "a.b.c" << 1.0f));
+ ShardKeyPattern s1(BSON("a.b" << 1));
+ ShardKeyPattern s2(BSON("a.b.c.d" << 1.0));
+ ShardKeyPattern s3(BSON("a" << 1 << "c.d" << 1.0 << "e.f.g" << 1.0f));
+ ShardKeyPattern s4(BSON("a" << 1 << "a.b" << 1.0 << "a.b.c" << 1.0f));
ASSERT_THROWS(ShardKeyPattern(BSON("a.b" << -1)), DBException);
ASSERT_THROWS(ShardKeyPattern(BSON("a" << BSON("b" << 1))), DBException);