diff options
| author | Adi Zaimi <adizaimi@yahoo.com> | 2023-02-01 22:19:52 +0000 |
|---|---|---|
| committer | Evergreen Agent <no-reply@evergreen.mongodb.com> | 2023-02-02 00:14:21 +0000 |
| commit | f5c68f8f3efb3281f2ffad462640c38268deb319 (patch) | |
| tree | a76a6019a8d813db8fb2c015f34d2f18c669b623 | |
| parent | e0fd004387a3ec6668f0a3dfba9c5cdbbf1be71f (diff) | |
| download | mongo-f5c68f8f3efb3281f2ffad462640c38268deb319.tar.gz | |
SERVER-73176: Only print actual error message in getHostFQDNs (v6.0)
| -rw-r--r-- | src/mongo/util/net/hostname_canonicalization.cpp | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/mongo/util/net/hostname_canonicalization.cpp b/src/mongo/util/net/hostname_canonicalization.cpp index f11ee345480..dd31e4b7015 100644 --- a/src/mongo/util/net/hostname_canonicalization.cpp +++ b/src/mongo/util/net/hostname_canonicalization.cpp @@ -111,7 +111,6 @@ StatusWith<std::vector<std::string>> getHostFQDNs(std::string hostName, std::vector<std::string> getNameInfoErrors; for (shim_addrinfo* p = info; p; p = p->ai_next) { - std::stringstream getNameInfoError; shim_char host[NI_MAXHOST] = {}; if ((err = shim_getnameinfo( p->ai_addr, p->ai_addrlen, host, sizeof(host), nullptr, 0, NI_NAMEREQD)) == 0) { @@ -130,6 +129,7 @@ StatusWith<std::vector<std::string>> getHostFQDNs(std::string hostName, sin_addr = reinterpret_cast<void*>(&addr_in6->sin6_addr); } + std::stringstream getNameInfoError; if (sin_addr) { invariant(inet_ntop(p->ai_family, sin_addr, ip_str, sizeof(ip_str)) != nullptr); getNameInfoError << ip_str; @@ -138,8 +138,8 @@ StatusWith<std::vector<std::string>> getHostFQDNs(std::string hostName, } getNameInfoError << ": \"" << getAddrInfoStrError(err); + getNameInfoErrors.push_back(getNameInfoError.str()); } - getNameInfoErrors.push_back(getNameInfoError.str()); } if (!getNameInfoErrors.empty()) { @@ -150,6 +150,8 @@ StatusWith<std::vector<std::string>> getHostFQDNs(std::string hostName, "errors"_attr = getNameInfoErrors); } + LOGV2_DEBUG(7317600, 4, "Name info: {results}", "Name info", "results"_attr = results); + // Deduplicate the results list std::sort(results.begin(), results.end()); results.erase(std::unique(results.begin(), results.end()), results.end()); |