SERVER-39193 Invariant instead of throwing WCE if locked incorrectly for reading oplog

1 files changed, 4 insertions, 8 deletions

diff --git a/src/mongo/db/storage/wiredtiger/wiredtiger_record_store.cpp b/src/mongo/db/storage/wiredtiger/wiredtiger_record_store.cpp
index befcd1952b6..fde4bdb01bb 100644
--- a/src/mongo/db/storage/wiredtiger/wiredtiger_record_store.cpp
+++ b/src/mongo/db/storage/wiredtiger/wiredtiger_record_store.cpp
@@ -2060,10 +2060,8 @@ std::unique_ptr<SeekableRecordCursor> StandardWiredTigerRecordStore::getCursor(
         WiredTigerRecoveryUnit* wru = WiredTigerRecoveryUnit::get(opCtx);
         // If we already have a snapshot we don't know what it can see, unless we know no one
         // else could be writing (because we hold an exclusive lock).
-        if (wru->inActiveTxn() && !opCtx->lockState()->isNoop() &&
-            !opCtx->lockState()->isCollectionLockedForMode(_ns, MODE_X)) {
-            throw WriteConflictException();
-        }
+        invariant(!wru->inActiveTxn() ||
+                  opCtx->lockState()->isCollectionLockedForMode(_ns, MODE_X));
         wru->setIsOplogReader();
     }
 
@@ -2113,10 +2111,8 @@ std::unique_ptr<SeekableRecordCursor> PrefixedWiredTigerRecordStore::getCursor(
         WiredTigerRecoveryUnit* wru = WiredTigerRecoveryUnit::get(opCtx);
         // If we already have a snapshot we don't know what it can see, unless we know no one
         // else could be writing (because we hold an exclusive lock).
-        if (wru->inActiveTxn() && !opCtx->lockState()->isNoop() &&
-            !opCtx->lockState()->isCollectionLockedForMode(_ns, MODE_X)) {
-            throw WriteConflictException();
-        }
+        invariant(!wru->inActiveTxn() ||
+                  opCtx->lockState()->isCollectionLockedForMode(_ns, MODE_X));
         wru->setIsOplogReader();
     }