diff options
| author | Alexander Neben <alexander.neben@mongodb.com> | 2023-02-10 02:30:16 +0000 |
|---|---|---|
| committer | Evergreen Agent <no-reply@evergreen.mongodb.com> | 2023-02-10 05:11:59 +0000 |
| commit | 495f532dc7a136ca15f6c22ecd1171d5cf4fef91 (patch) | |
| tree | 6250f88ac7471b11b688e124b7c033f8a9e672b1 | |
| parent | 1de0264c6f0d48a21339e6a6a6a54b6b1e916f85 (diff) | |
| download | mongo-495f532dc7a136ca15f6c22ecd1171d5cf4fef91.tar.gz | |
SERVER-71734 Removed uninterruptable lock guard from simplecpplint
| -rw-r--r-- | buildscripts/linter/simplecpplint.py | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/buildscripts/linter/simplecpplint.py b/buildscripts/linter/simplecpplint.py index c2903f5b3c7..feff202a3d9 100644 --- a/buildscripts/linter/simplecpplint.py +++ b/buildscripts/linter/simplecpplint.py @@ -61,7 +61,6 @@ _RE_UNSTRUCTURED_LOG = re.compile(r'\blogd\s*\(') _RE_STD_OPTIONAL = re.compile(r'\bstd::optional\b') _RE_TRACING_SUPPORT = re.compile(r'\bTracerProvider::(get|initialize)\b') _RE_COLLECTION_SHARDING_RUNTIME = re.compile(r'\bCollectionShardingRuntime\b') -_RE_UNINTERRUPTIBLE_LOCK_GUARD = re.compile(r'\bUninterruptibleLockGuard\s+.+\s*;') _RE_RAND = re.compile(r'\b(srand\(|rand\(\))') _RE_GENERIC_FCV_COMMENT = re.compile(r'\(Generic FCV reference\):') @@ -167,7 +166,6 @@ class Linter: self._check_for_std_optional(linenum) self._check_for_tracing_support(linenum) self._check_for_collection_sharding_runtime(linenum) - self._check_for_uninterruptible_lock_guard(linenum) self._check_for_rand(linenum) self._check_for_c_stdlib_headers(linenum) @@ -316,16 +314,6 @@ class Linter: 'CollectionShardingRuntime outside of mongo/db/s/; use CollectionShardingState ' 'instead; see src/mongo/db/s/collection_sharding_state.h for details.') - def _check_for_uninterruptible_lock_guard(self, linenum): - line = self.clean_lines[linenum] - if _RE_UNINTERRUPTIBLE_LOCK_GUARD.search(line): - self._error( - linenum, 'mongodb/uninterruptible_lock_guard', - 'Potentially incorrect use of UninterruptibleLockGuard, ' - 'the programming model inside MongoDB requires that all operations be interruptible. ' - 'Review with care and if the use is warranted, add NOLINT and a comment explaining why.' - ) - def _check_for_rand(self, linenum): line = self.clean_lines[linenum] if _RE_RAND.search(line): |