SERVER-68130 adjust autoSplitVector's estimatedAdditionalBytesPerItemInBSONArray

1 files changed, 10 insertions, 1 deletions

diff --git a/src/mongo/db/s/auto_split_vector.cpp b/src/mongo/db/s/auto_split_vector.cpp
index 7569142fde0..9f4335f9f2b 100644
--- a/src/mongo/db/s/auto_split_vector.cpp
+++ b/src/mongo/db/s/auto_split_vector.cpp
@@ -49,7 +49,16 @@
 namespace mongo {
 namespace {
 
-constexpr int estimatedAdditionalBytesPerItemInBSONArray{2};
+/*
+ * BSON arrays are serialized as BSON objects with the index of each element as a string key: for
+ * example, the array ["a","b","c"] is going to be serialized as {"0":"a","1":"b","2":"c"}. The
+ * minimum size for a BSON object is `BSONObj::kMinBSONLength`.
+ *
+ * Given that the `vector<BSONObj>` returned by `autoSplitVector` can't be greater than 16MB when
+ * serialized, pessimistically assume that each key occupies the highest possible number of bytes.
+ */
+const int estimatedAdditionalBytesPerItemInBSONArray{
+    (int)std::to_string(BSONObjMaxUserSize / BSONObj::kMinBSONLength).length()};
 
 constexpr int kMaxSplitPointsToReposition{3};