summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKeith Bostic <keith.bostic@mongodb.com>2016-08-15 18:43:06 -0400
committerAlex Gorrod <alexander.gorrod@mongodb.com>2016-08-16 08:43:06 +1000
commit2a3502b086a5656514e8abab95ea69fd27e4db56 (patch)
tree7f04edb6698712c4d27ba91cef7f609df8f27612
parent1250457e2d84ffe0f1f58b95799f488db898a783 (diff)
downloadmongo-2a3502b086a5656514e8abab95ea69fd27e4db56.tar.gz
WT-2840 clang analysis: garbage values (#2963)
Check the WT_ITEM.size value is > 0 before indirecting to an invalid offset.
-rw-r--r--src/cursor/cur_metadata.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/cursor/cur_metadata.c b/src/cursor/cur_metadata.c
index 9111afcc801..fd00acdf0ab 100644
--- a/src/cursor/cur_metadata.c
+++ b/src/cursor/cur_metadata.c
@@ -155,8 +155,9 @@ err: __wt_free(session, value);
* but also check for the internal version of the URI.
*/
#define WT_KEY_IS_METADATA(key) \
+ ((key)->size > 0 && \
(WT_STRING_MATCH(WT_METADATA_URI, (key)->data, (key)->size - 1) ||\
- WT_STRING_MATCH(WT_METAFILE_URI, (key)->data, (key)->size - 1))
+ WT_STRING_MATCH(WT_METAFILE_URI, (key)->data, (key)->size - 1)))
/*
* __curmetadata_metadata_search --