summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEliot Horowitz <eliot@10gen.com>2011-07-10 00:25:43 -0400
committerEliot Horowitz <eliot@10gen.com>2011-07-10 00:26:10 -0400
commit12cc8fb4ae8df0836f73d30ea95354155b757571 (patch)
tree94abc150e7acf7fc3bee8ec5277bef0c0ecc51c8
parentf9fcfffad6f95cf6e37d99d07b1d7c74075b56f6 (diff)
downloadmongo-12cc8fb4ae8df0836f73d30ea95354155b757571.tar.gz
better error handling for monogodump
-rw-r--r--tools/dump.cpp9
1 files changed, 8 insertions, 1 deletions
diff --git a/tools/dump.cpp b/tools/dump.cpp
index 155f84b8c35..59bdaf30915 100644
--- a/tools/dump.cpp
+++ b/tools/dump.cpp
@@ -333,11 +333,18 @@ public:
auth( "admin" );
BSONObj res = conn( true ).findOne( "admin.$cmd" , BSON( "listDatabases" << 1 ) );
- BSONObj dbs = res.getField( "databases" ).embeddedObjectUserCheck();
+ if ( ! res["databases"].isABSONObj() ) {
+ error() << "output of listDatabases isn't what we expected, no 'databases' field:\n" << res << endl;
+ }
+ BSONObj dbs = res["databases"].embeddedObjectUserCheck();
set<string> keys;
dbs.getFieldNames( keys );
for ( set<string>::iterator i = keys.begin() ; i != keys.end() ; i++ ) {
string key = *i;
+
+ if ( ! dbs[key].isABSONObj() ) {
+ error() << "database field not an object key: " << key << " value: " << dbs[key] << endl;
+ }
BSONObj dbobj = dbs.getField( key ).embeddedObjectUserCheck();