summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJudah Schvimer <judah@mongodb.com>2019-04-23 17:49:39 -0400
committerJudah Schvimer <judah@mongodb.com>2019-05-13 14:33:29 -0400
commit83e9cea65b2db8b9c7015f737472462841fddbd0 (patch)
tree06e5234430d8fbb44158277d94b8c6ec8aa38ba8
parent20107d15da5ff360378f2bf98acb8040b7a5f8a3 (diff)
downloadmongo-83e9cea65b2db8b9c7015f737472462841fddbd0.tar.gz
SERVER-40788 Improve logging around replication catchup
(cherry picked from commit 18181d9825ddc62351a6ba94325a38353086248c)
-rw-r--r--src/mongo/db/repl/replication_coordinator_impl.cpp12
1 files changed, 8 insertions, 4 deletions
diff --git a/src/mongo/db/repl/replication_coordinator_impl.cpp b/src/mongo/db/repl/replication_coordinator_impl.cpp
index d12d057db48..6d9ed949552 100644
--- a/src/mongo/db/repl/replication_coordinator_impl.cpp
+++ b/src/mongo/db/repl/replication_coordinator_impl.cpp
@@ -2935,8 +2935,10 @@ void ReplicationCoordinatorImpl::CatchupState::signalHeartbeatUpdate_inlock() {
}
// We've caught up.
- if (*targetOpTime <= _repl->_getMyLastAppliedOpTime_inlock()) {
- log() << "Caught up to the latest optime known via heartbeats after becoming primary.";
+ const auto myLastApplied = _repl->_getMyLastAppliedOpTime_inlock();
+ if (*targetOpTime <= myLastApplied) {
+ log() << "Caught up to the latest optime known via heartbeats after becoming primary. "
+ << "Target optime: " << *targetOpTime << ". My Last Applied: " << myLastApplied;
abort_inlock();
return;
}
@@ -2952,8 +2954,10 @@ void ReplicationCoordinatorImpl::CatchupState::signalHeartbeatUpdate_inlock() {
}
auto targetOpTimeCB = [this, targetOpTime]() {
// Double check the target time since stepdown may signal us too.
- if (*targetOpTime <= _repl->_getMyLastAppliedOpTime_inlock()) {
- log() << "Caught up to the latest known optime successfully after becoming primary.";
+ const auto myLastApplied = _repl->_getMyLastAppliedOpTime_inlock();
+ if (*targetOpTime <= myLastApplied) {
+ log() << "Caught up to the latest known optime successfully after becoming primary. "
+ << "Target optime: " << *targetOpTime << ". My Last Applied: " << myLastApplied;
abort_inlock();
}
};