diff options
author | Judah Schvimer <judah@mongodb.com> | 2019-04-23 17:49:39 -0400 |
---|---|---|
committer | Judah Schvimer <judah@mongodb.com> | 2019-05-13 11:39:03 -0400 |
commit | 07d92d96d8a7f949a578b6606103a59cb7060e49 (patch) | |
tree | 770f0c45bdc3f43691f78cbae39b69003cd34e66 | |
parent | bd29d88a111b3d3f663b39fc5d8a70e1e7f4d68b (diff) | |
download | mongo-07d92d96d8a7f949a578b6606103a59cb7060e49.tar.gz |
SERVER-40788 Improve logging around replication catchup
(cherry picked from commit 18181d9825ddc62351a6ba94325a38353086248c)
-rw-r--r-- | src/mongo/db/repl/replication_coordinator_impl.cpp | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/src/mongo/db/repl/replication_coordinator_impl.cpp b/src/mongo/db/repl/replication_coordinator_impl.cpp index 024ed39bd0b..c415dc00b49 100644 --- a/src/mongo/db/repl/replication_coordinator_impl.cpp +++ b/src/mongo/db/repl/replication_coordinator_impl.cpp @@ -2876,8 +2876,10 @@ void ReplicationCoordinatorImpl::CatchupState::signalHeartbeatUpdate_inlock() { } // We've caught up. - if (*targetOpTime <= _repl->_getMyLastAppliedOpTime_inlock()) { - log() << "Caught up to the latest optime known via heartbeats after becoming primary."; + const auto myLastApplied = _repl->_getMyLastAppliedOpTime_inlock(); + if (*targetOpTime <= myLastApplied) { + log() << "Caught up to the latest optime known via heartbeats after becoming primary. " + << "Target optime: " << *targetOpTime << ". My Last Applied: " << myLastApplied; abort_inlock(); return; } @@ -2893,8 +2895,10 @@ void ReplicationCoordinatorImpl::CatchupState::signalHeartbeatUpdate_inlock() { } auto targetOpTimeCB = [this, targetOpTime]() { // Double check the target time since stepdown may signal us too. - if (*targetOpTime <= _repl->_getMyLastAppliedOpTime_inlock()) { - log() << "Caught up to the latest known optime successfully after becoming primary."; + const auto myLastApplied = _repl->_getMyLastAppliedOpTime_inlock(); + if (*targetOpTime <= myLastApplied) { + log() << "Caught up to the latest known optime successfully after becoming primary. " + << "Target optime: " << *targetOpTime << ". My Last Applied: " << myLastApplied; abort_inlock(); } }; |