SERVER-46942 Cancel timer before leaving onAcquireConn

Avoid leaking state information if server closes too quickly on network_interface_tl.

1 files changed, 5 insertions, 4 deletions

diff --git a/src/mongo/executor/network_interface_tl.cpp b/src/mongo/executor/network_interface_tl.cpp
index 1872e5322e7..1dfbf7b3300 100644
--- a/src/mongo/executor/network_interface_tl.cpp
+++ b/src/mongo/executor/network_interface_tl.cpp
@@ -438,6 +438,11 @@ void NetworkInterfaceTL::_onAcquireConn(std::shared_ptr<CommandState> state,
             return RemoteCommandOnAnyResponse(target, std::move(response));
         })
         .getAsync([this, state, baton](StatusWith<RemoteCommandOnAnyResponse> swr) {
+            // Cancel `state->timer` before returning to prevent leaking `state`.
+            if (state->timer) {
+                state->timer->cancel(baton);
+            }
+
             if (!swr.isOK()) {
                 state->conn->indicateFailure(swr.getStatus());
             } else if (!swr.getValue().isOK()) {
@@ -460,10 +465,6 @@ void NetworkInterfaceTL::_onAcquireConn(std::shared_ptr<CommandState> state,
                 }
             }
 
-            if (state->timer) {
-                state->timer->cancel(baton);
-            }
-
             state->promise.setFromStatusWith(std::move(swr));
         });
 }