diff options
author | Adi Zaimi <adizaimi@yahoo.com> | 2023-01-23 15:53:18 +0000 |
---|---|---|
committer | Evergreen Agent <no-reply@evergreen.mongodb.com> | 2023-01-23 16:16:18 +0000 |
commit | 605725ecdb59272e989210d066a5e88b091906e7 (patch) | |
tree | b13f26b86789534668fcbbc1d46f866240cb4347 | |
parent | 555aa16828008a8ddff440f35ff02c780c2cd185 (diff) | |
download | mongo-605725ecdb59272e989210d066a5e88b091906e7.tar.gz |
SERVER-73176: Only print actual error message in getHostFQDNsr4.4.19-rc0
-rw-r--r-- | src/mongo/util/net/hostname_canonicalization.cpp | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/mongo/util/net/hostname_canonicalization.cpp b/src/mongo/util/net/hostname_canonicalization.cpp index b329d0f6149..6ceb543f027 100644 --- a/src/mongo/util/net/hostname_canonicalization.cpp +++ b/src/mongo/util/net/hostname_canonicalization.cpp @@ -107,7 +107,6 @@ std::vector<std::string> getHostFQDNs(std::string hostName, HostnameCanonicaliza std::vector<std::string> getNameInfoErrors; for (shim_addrinfo* p = info; p; p = p->ai_next) { - std::stringstream getNameInfoError; shim_char host[NI_MAXHOST] = {}; if ((err = shim_getnameinfo( p->ai_addr, p->ai_addrlen, host, sizeof(host), nullptr, 0, NI_NAMEREQD)) == 0) { @@ -126,6 +125,7 @@ std::vector<std::string> getHostFQDNs(std::string hostName, HostnameCanonicaliza sin_addr = reinterpret_cast<void*>(&addr_in6->sin6_addr); } + std::stringstream getNameInfoError; if (sin_addr) { invariant(inet_ntop(p->ai_family, sin_addr, ip_str, sizeof(ip_str)) != nullptr); getNameInfoError << ip_str; @@ -134,8 +134,8 @@ std::vector<std::string> getHostFQDNs(std::string hostName, HostnameCanonicaliza } getNameInfoError << ": \"" << getAddrInfoStrError(err); + getNameInfoErrors.push_back(getNameInfoError.str()); } - getNameInfoErrors.push_back(getNameInfoError.str()); } if (!getNameInfoErrors.empty()) { @@ -146,6 +146,8 @@ std::vector<std::string> getHostFQDNs(std::string hostName, HostnameCanonicaliza "errors"_attr = getNameInfoErrors); } + LOGV2_DEBUG(7317600, 4, "Name info: {results}", "Name info", "results"_attr = results); + // Deduplicate the results list std::sort(results.begin(), results.end()); results.erase(std::unique(results.begin(), results.end()), results.end()); |