diff options
| author | Gregory Wlodarek <gregory.wlodarek@mongodb.com> | 2023-02-07 22:49:42 +0000 |
|---|---|---|
| committer | Evergreen Agent <no-reply@evergreen.mongodb.com> | 2023-02-10 23:57:03 +0000 |
| commit | d74542dd8333db36eea8ad173357b4bbeea705de (patch) | |
| tree | e1254c4e6df996962fd05853c23c6fb88309e99e | |
| parent | 57c08db7751a049911c9d36837006814cd5ac3b5 (diff) | |
| download | mongo-d74542dd8333db36eea8ad173357b4bbeea705de.tar.gz | |
SERVER-73706 Save WTRecordStoreUassertOutOfOrder fail point state to prevent concurrency bugs in testing
(cherry picked from commit 237c050c840b906a8d4b4cd48e7e71e219f72df4)
| -rw-r--r-- | src/mongo/db/storage/wiredtiger/wiredtiger_record_store.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/mongo/db/storage/wiredtiger/wiredtiger_record_store.cpp b/src/mongo/db/storage/wiredtiger/wiredtiger_record_store.cpp index 92aa0d0514a..6b997f3306f 100644 --- a/src/mongo/db/storage/wiredtiger/wiredtiger_record_store.cpp +++ b/src/mongo/db/storage/wiredtiger/wiredtiger_record_store.cpp @@ -2195,9 +2195,9 @@ boost::optional<Record> WiredTigerRecordStoreCursorBase::next() { return {}; } - if ((_forward && _lastReturnedId >= id) || - MONGO_unlikely(WTRecordStoreUassertOutOfOrder.shouldFail())) { - if (!WTRecordStoreUassertOutOfOrder.shouldFail()) { + const bool failWithOutOfOrderForTest = WTRecordStoreUassertOutOfOrder.shouldFail(); + if ((_forward && _lastReturnedId >= id) || MONGO_unlikely(failWithOutOfOrderForTest)) { + if (!failWithOutOfOrderForTest) { // Crash when testing diagnostics are enabled and not explicitly uasserting on // out-of-order keys. invariant(!TestingProctor::instance().isEnabled(), "cursor returned out-of-order keys"); |