summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTommaso Tocci <tommaso.tocci@mongodb.com>2023-04-03 19:10:10 +0000
committerEvergreen Agent <no-reply@evergreen.mongodb.com>2023-04-03 20:43:20 +0000
commitef5113992e87df2d0e1a9f28c74ffa4da12f28e0 (patch)
tree5e71dd2c4fb97538faf86eba824142a2274f1c7e
parent55e39610a134df426540d2768d0455b3593beb2e (diff)
downloadmongo-ef5113992e87df2d0e1a9f28c74ffa4da12f28e0.tar.gz
SERVER-75605 Fix vector access in FindRoutingTableRangeOverlapInconsistency unit test
-rw-r--r--src/mongo/db/s/metadata_consistency_util_test.cpp11
1 files changed, 4 insertions, 7 deletions
diff --git a/src/mongo/db/s/metadata_consistency_util_test.cpp b/src/mongo/db/s/metadata_consistency_util_test.cpp
index b19d9b5a81c..b61a077db66 100644
--- a/src/mongo/db/s/metadata_consistency_util_test.cpp
+++ b/src/mongo/db/s/metadata_consistency_util_test.cpp
@@ -274,8 +274,8 @@ TEST_F(MetadataConsistencyRandomRoutingTableTest, FindRoutingTableRangeOverlapIn
return;
}
- auto it = chunks.begin() + (_random.nextInt64(chunks.size()));
- auto chunk = *it;
+ const auto chunkIdx = static_cast<size_t>(_random.nextInt64(chunks.size()));
+ auto& chunk = chunks.at(chunkIdx);
auto overlapMax = [&]() {
if (_random.nextInt64(10) == 0) {
@@ -299,9 +299,9 @@ TEST_F(MetadataConsistencyRandomRoutingTableTest, FindRoutingTableRangeOverlapIn
}
};
- if (it == chunks.begin()) {
+ if (chunkIdx == 0) {
overlapMax();
- } else if (it == chunks.end() - 1) {
+ } else if (chunkIdx == (chunks.size() - 1)) {
overlapMin();
} else {
// With 1/2 probability, overlap min or max
@@ -312,9 +312,6 @@ TEST_F(MetadataConsistencyRandomRoutingTableTest, FindRoutingTableRangeOverlapIn
}
}
- chunks.erase(it);
- chunks.insert(it, chunk);
-
inconsistencies =
metadata_consistency_util::checkChunksInconsistencies(operationContext(), _coll, chunks);