summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMark Benvenuto <mark.benvenuto@mongodb.com>2016-09-16 12:30:45 -0400
committerMark Benvenuto <mark.benvenuto@mongodb.com>2016-09-16 12:30:45 -0400
commitb50e092ab2856db10c29055fe11b6b3b6fa5d783 (patch)
treef3ea361e215abdeae0f56fdfa0b205b360a64f47
parent805a82ee4398e429814df8257fa393965525db17 (diff)
downloadmongo-b50e092ab2856db10c29055fe11b6b3b6fa5d783.tar.gz
SERVER-25759 Quote appname in slow log output
-rw-r--r--jstests/noPassthrough/client_metadata_slowlog.js2
-rw-r--r--src/mongo/db/curop.cpp3
2 files changed, 3 insertions, 2 deletions
diff --git a/jstests/noPassthrough/client_metadata_slowlog.js b/jstests/noPassthrough/client_metadata_slowlog.js
index 5a270693d56..bef9b0ce9e7 100644
--- a/jstests/noPassthrough/client_metadata_slowlog.js
+++ b/jstests/noPassthrough/client_metadata_slowlog.js
@@ -22,7 +22,7 @@
print(`Checking ${conn.fullOptions.logFile} for client metadata message`);
let log = cat(conn.fullOptions.logFile);
assert(
- /COMMAND .* command test.foo appName:MongoDB Shell command: count { count: "foo", query: { \$where: function ()/
+ /COMMAND .* command test.foo appName: "MongoDB Shell" command: count { count: "foo", query: { \$where: function ()/
.test(log),
"'slow query' log line missing in mongod log file!\n" + "Log file contents: " +
conn.fullOptions.logFile +
diff --git a/src/mongo/db/curop.cpp b/src/mongo/db/curop.cpp
index 527847c4df6..9d14fbd44c5 100644
--- a/src/mongo/db/curop.cpp
+++ b/src/mongo/db/curop.cpp
@@ -44,6 +44,7 @@
#include "mongo/rpc/metadata/client_metadata.h"
#include "mongo/rpc/metadata/client_metadata_ismaster.h"
#include "mongo/util/log.h"
+#include "mongo/util/stringutils.h"
namespace mongo {
@@ -425,7 +426,7 @@ string OpDebug::report(Client* client,
if (clientMetadata) {
auto appName = clientMetadata.get().getApplicationName();
if (!appName.empty()) {
- s << " appName:" << appName;
+ s << " appName: \"" << escape(appName) << '\"';
}
}