SERVER-39303 Fix several useless Client* checks

The checks performed in functions that are never passed a nullptr and
would crash later if null was ever passed.  Removing the checks makes
coverity happy.

(cherry picked from commit e61f7582788f51b2287f179c8f27ec8fa41744f7)

1 files changed, 2 insertions, 2 deletions

diff --git a/src/mongo/db/service_context.cpp b/src/mongo/db/service_context.cpp
index 0930c9c9a61..7d64f9c5a2a 100644
--- a/src/mongo/db/service_context.cpp
+++ b/src/mongo/db/service_context.cpp
@@ -241,7 +241,7 @@ void ServiceContext::ClientDeleter::operator()(Client* client) const {
 
 ServiceContext::UniqueOperationContext ServiceContext::makeOperationContext(Client* client) {
     auto opCtx = std::make_unique<OperationContext>(client, _nextOpId.fetchAndAdd(1));
-    if (client && client->session()) {
+    if (client->session()) {
         _numCurrentOps.addAndFetch(1);
     }
 
@@ -262,7 +262,7 @@ ServiceContext::UniqueOperationContext ServiceContext::makeOperationContext(Clie
 
 void ServiceContext::OperationContextDeleter::operator()(OperationContext* opCtx) const {
     auto client = opCtx->getClient();
-    if (client && client->session()) {
+    if (client->session()) {
         _numCurrentOps.subtractAndFetch(1);
     }
     auto service = client->getServiceContext();