summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlberto Massari <alberto.massari@mongodb.com>2022-08-29 07:39:35 +0000
committerEvergreen Agent <no-reply@evergreen.mongodb.com>2022-08-29 08:15:30 +0000
commit440849b9ebe471ddf4103185c261813dd01f1a01 (patch)
treecf2a5063dccefedf0f55305f47e80eb0b80d2b6b
parentfb80d4bd415d287dcfc85e712ce596318889ae37 (diff)
downloadmongo-440849b9ebe471ddf4103185c261813dd01f1a01.tar.gz
SERVER-67102 Complete the removal of unnecessary string copies in MetricsCollector
-rw-r--r--src/mongo/db/storage/wiredtiger/wiredtiger_column_store.cpp10
-rw-r--r--src/mongo/db/storage/wiredtiger/wiredtiger_index_cursor_generic.h2
2 files changed, 6 insertions, 6 deletions
diff --git a/src/mongo/db/storage/wiredtiger/wiredtiger_column_store.cpp b/src/mongo/db/storage/wiredtiger/wiredtiger_column_store.cpp
index d21279e0baf..b3aef5dc0a6 100644
--- a/src/mongo/db/storage/wiredtiger/wiredtiger_column_store.cpp
+++ b/src/mongo/db/storage/wiredtiger/wiredtiger_column_store.cpp
@@ -173,7 +173,7 @@ void WiredTigerColumnStore::WriteCursor::insert(PathView path, RowId rid, CellVi
int ret = WT_OP_CHECK(wiredTigerCursorInsert(_opCtx, c()));
auto& metricsCollector = ResourceConsumption::MetricsCollector::get(_opCtx);
- metricsCollector.incrementOneIdxEntryWritten(std::string(c()->uri), keyItem.size);
+ metricsCollector.incrementOneIdxEntryWritten(c()->uri, keyItem.size);
// TODO: SERVER-65978, we may have to specially handle WT_DUPLICATE_KEY error here.
if (ret) {
@@ -197,7 +197,7 @@ void WiredTigerColumnStore::WriteCursor::remove(PathView path, RowId rid) {
invariantWTOK(ret, c()->session);
auto& metricsCollector = ResourceConsumption::MetricsCollector::get(_opCtx);
- metricsCollector.incrementOneIdxEntryWritten(std::string(c()->uri), keyItem.size);
+ metricsCollector.incrementOneIdxEntryWritten(c()->uri, keyItem.size);
}
void WiredTigerColumnStore::update(OperationContext* opCtx,
PathView path,
@@ -217,7 +217,7 @@ void WiredTigerColumnStore::WriteCursor::update(PathView path, RowId rid, CellVi
int ret = WT_OP_CHECK(wiredTigerCursorUpdate(_opCtx, c()));
auto& metricsCollector = ResourceConsumption::MetricsCollector::get(_opCtx);
- metricsCollector.incrementOneIdxEntryWritten(std::string(c()->uri), keyItem.size);
+ metricsCollector.incrementOneIdxEntryWritten(c()->uri, keyItem.size);
// TODO: SERVER-65978, may want to handle WT_NOTFOUND specially.
if (ret != 0)
@@ -321,7 +321,7 @@ private:
invariantWTOK(ret, c->session);
auto& metricsCollector = ResourceConsumption::MetricsCollector::get(_opCtx);
- metricsCollector.incrementOneCursorSeek(std::string(c->uri));
+ metricsCollector.incrementOneCursorSeek(c->uri);
_eof = false;
@@ -398,7 +398,7 @@ public:
invariantWTOK(wiredTigerCursorInsert(_opCtx, _cursor.get()), _cursor->session);
ResourceConsumption::MetricsCollector::get(_opCtx).incrementOneIdxEntryWritten(
- std::string(_cursor->uri), keyItem.size);
+ _cursor->uri, keyItem.size);
}
private:
diff --git a/src/mongo/db/storage/wiredtiger/wiredtiger_index_cursor_generic.h b/src/mongo/db/storage/wiredtiger/wiredtiger_index_cursor_generic.h
index 87862974b38..9692d84b129 100644
--- a/src/mongo/db/storage/wiredtiger/wiredtiger_index_cursor_generic.h
+++ b/src/mongo/db/storage/wiredtiger/wiredtiger_index_cursor_generic.h
@@ -90,7 +90,7 @@ protected:
invariantWTOK(cursor->get_key(cursor, key), cursor->session);
auto& metricsCollector = ResourceConsumption::MetricsCollector::get(_opCtx);
- metricsCollector.incrementOneIdxEntryRead(std::string(cursor->internal_uri), key->size);
+ metricsCollector.incrementOneIdxEntryRead(cursor->internal_uri, key->size);
}
OperationContext* _opCtx;