summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKevin Pulo <kevin.pulo@mongodb.com>2018-10-29 19:44:29 +0000
committerKevin Pulo <kevin.pulo@mongodb.com>2018-10-30 15:43:55 +0000
commit3545daef3b7f0dade1237c7536ba896b7b21b25b (patch)
tree81ba87932aceedfcb090f3a29dcc922fd2fa7a48
parent8e846d7a3701cf0bd9a79fc0b0f58a03472fd9d3 (diff)
downloadmongo-3545daef3b7f0dade1237c7536ba896b7b21b25b.tar.gz
SERVER-18985 log setParameter commands
(cherry picked from commit 4d8c956efe27360e8b6828ee62fd3df3ad8f5710)
-rw-r--r--src/mongo/db/commands/parameters.cpp32
1 files changed, 29 insertions, 3 deletions
diff --git a/src/mongo/db/commands/parameters.cpp b/src/mongo/db/commands/parameters.cpp
index 170b7bef7d9..f543517dc6c 100644
--- a/src/mongo/db/commands/parameters.cpp
+++ b/src/mongo/db/commands/parameters.cpp
@@ -30,6 +30,8 @@
* it in the license file.
*/
+#define MONGO_LOG_DEFAULT_COMPONENT ::mongo::logger::LogComponent::kCommand
+
#include "mongo/platform/basic.h"
#include <set>
@@ -46,6 +48,7 @@
#include "mongo/db/storage/storage_options.h"
#include "mongo/logger/logger.h"
#include "mongo/logger/parse_log_component_settings.h"
+#include "mongo/util/log.h"
#include "mongo/util/mongoutils/str.h"
#include "mongo/util/net/ssl_manager.h"
#include "mongo/util/net/ssl_options.h"
@@ -214,11 +217,34 @@ public:
return false;
}
- if (numSet == 0) {
- foundParameter->second->append(opCtx, result, "was");
+ auto oldValueObj = ([&] {
+ BSONObjBuilder bb;
+ if (numSet == 0) {
+ foundParameter->second->append(opCtx, bb, "was");
+ }
+ return bb.obj();
+ })();
+ auto oldValue = oldValueObj.firstElement();
+
+ if (oldValue) {
+ result.append(oldValue);
+ }
+
+ try {
+ uassertStatusOK(foundParameter->second->set(parameter));
+ } catch (const DBException& ex) {
+ log() << "error setting parameter " << parameterName << " to "
+ << redact(parameter.toString(false)) << " errMsg: " << redact(ex);
+ throw;
}
- uassertStatusOK(foundParameter->second->set(parameter));
+ log() << "successfully set parameter " << parameterName << " to "
+ << redact(parameter.toString(false))
+ << (oldValue ? std::string(str::stream() << " (was "
+ << redact(oldValue.toString(false))
+ << ")")
+ : "");
+
numSet++;
}