summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGregory Wlodarek <gregory.wlodarek@mongodb.com>2019-05-07 14:21:28 -0400
committerGregory Wlodarek <gregory.wlodarek@mongodb.com>2019-05-08 16:44:26 -0400
commit39c90b5d46ec0c745c5df251e63d04712728741e (patch)
tree8b45c1c4c5280fa5d90b5ea2b93f33f3b39721f6
parentda440146f98c92d22a4c3e1c638f839e93869b11 (diff)
downloadmongo-39c90b5d46ec0c745c5df251e63d04712728741e.tar.gz
SERVER-13006 getParameter for journalCommitInterval returns the appropriate value
-rw-r--r--src/mongo/db/storage/storage_parameters.idl1
-rw-r--r--src/mongo/db/storage/wiredtiger/wiredtiger_kv_engine.cpp5
-rw-r--r--src/mongo/db/storage/wiredtiger/wiredtiger_kv_engine.h1
-rw-r--r--src/mongo/db/storage/wiredtiger/wiredtiger_oplog_manager.cpp3
4 files changed, 1 insertions, 9 deletions
diff --git a/src/mongo/db/storage/storage_parameters.idl b/src/mongo/db/storage/storage_parameters.idl
index 39555967ba8..f5e40e65785 100644
--- a/src/mongo/db/storage/storage_parameters.idl
+++ b/src/mongo/db/storage/storage_parameters.idl
@@ -53,6 +53,7 @@ server_parameters:
description: 'Number of milliseconds between journal commits'
set_at: runtime
cpp_varname: 'storageGlobalParams.journalCommitIntervalMs'
+ default: 100
validator:
gte: 1
lte: { expr: 'StorageGlobalParams::kMaxJournalCommitIntervalMs' }
diff --git a/src/mongo/db/storage/wiredtiger/wiredtiger_kv_engine.cpp b/src/mongo/db/storage/wiredtiger/wiredtiger_kv_engine.cpp
index f6d89fc21ae..275687829b3 100644
--- a/src/mongo/db/storage/wiredtiger/wiredtiger_kv_engine.cpp
+++ b/src/mongo/db/storage/wiredtiger/wiredtiger_kv_engine.cpp
@@ -167,8 +167,6 @@ using std::string;
namespace dps = ::mongo::dotted_path_support;
-const int WiredTigerKVEngine::kDefaultJournalDelayMillis = 100;
-
class WiredTigerKVEngine::WiredTigerSessionSweeper : public BackgroundJob {
public:
explicit WiredTigerSessionSweeper(WiredTigerSessionCache* sessionCache)
@@ -240,9 +238,6 @@ public:
}
int ms = storageGlobalParams.journalCommitIntervalMs.load();
- if (!ms) {
- ms = kDefaultJournalDelayMillis;
- }
MONGO_IDLE_THREAD_BLOCK;
sleepmillis(ms);
diff --git a/src/mongo/db/storage/wiredtiger/wiredtiger_kv_engine.h b/src/mongo/db/storage/wiredtiger/wiredtiger_kv_engine.h
index 1f07e81debc..c7f6efd48cc 100644
--- a/src/mongo/db/storage/wiredtiger/wiredtiger_kv_engine.h
+++ b/src/mongo/db/storage/wiredtiger/wiredtiger_kv_engine.h
@@ -65,7 +65,6 @@ struct WiredTigerFileVersion {
class WiredTigerKVEngine final : public KVEngine {
public:
- static const int kDefaultJournalDelayMillis;
static StringData kTableUriPrefix;
WiredTigerKVEngine(const std::string& canonicalName,
diff --git a/src/mongo/db/storage/wiredtiger/wiredtiger_oplog_manager.cpp b/src/mongo/db/storage/wiredtiger/wiredtiger_oplog_manager.cpp
index 98df9ac9c3d..ff45337699d 100644
--- a/src/mongo/db/storage/wiredtiger/wiredtiger_oplog_manager.cpp
+++ b/src/mongo/db/storage/wiredtiger/wiredtiger_oplog_manager.cpp
@@ -171,9 +171,6 @@ void WiredTigerOplogManager::_oplogJournalThreadLoop(WiredTigerSessionCache* ses
// If we're not shutting down and nobody is actively waiting for the oplog to become
// durable, delay journaling a bit to reduce the sync rate.
auto journalDelay = Milliseconds(storageGlobalParams.journalCommitIntervalMs.load());
- if (journalDelay == Milliseconds(0)) {
- journalDelay = Milliseconds(WiredTigerKVEngine::kDefaultJournalDelayMillis);
- }
auto now = Date_t::now();
auto deadline = now + journalDelay;
auto shouldSyncOpsWaitingForJournal = [&] {