diff options
| author | Andrew Morrow <acm@mongodb.com> | 2018-08-22 14:23:45 -0400 |
|---|---|---|
| committer | Andrew Morrow <acm@mongodb.com> | 2018-08-22 14:24:13 -0400 |
| commit | d8810253bff426c58ee9040689302f8964053c9c (patch) | |
| tree | 4bb523e8554d407ea07a8bdadd2d300fefe2f052 /SConstruct | |
| parent | 5df9e94b0c4840680d1d17fcf2f04412cf6d70cf (diff) | |
| download | mongo-d8810253bff426c58ee9040689302f8964053c9c.tar.gz | |
Revert "SERVER-33912 Make warnings fatal for embedded builders"
This reverts commit bce25d5e123843c0e594d6d743981099f236c983.
Diffstat (limited to 'SConstruct')
| -rw-r--r-- | SConstruct | 28 |
1 files changed, 0 insertions, 28 deletions
diff --git a/SConstruct b/SConstruct index 7e30882c31a..4917d4c97ac 100644 --- a/SConstruct +++ b/SConstruct @@ -1698,29 +1698,6 @@ if env.ToolchainIs('msvc'): if env.TargetOSIs('posix'): - # On linux, C code compiled with gcc/clang -std=c11 causes - # __STRICT_ANSI__ to be set, and that drops out all of the feature - # test definitions, resulting in confusing errors when we run C - # language configure checks and expect to be able to find newer - # POSIX things. Explicitly enabling _XOPEN_SOURCE fixes that, and - # should be mostly harmless as on Linux, these macros are - # cumulative. The C++ compiler already sets _XOPEN_SOURCE, and, - # notably, setting it again does not disable any other feature - # test macros, so this is safe to do. Other platforms like macOS - # and BSD have crazy rules, so don't try this there. - # - # Furthermore, as both C++ compilers appears to unconditioanlly - # define _GNU_SOURCE (because libstdc++ requires it), it seems - # prudent to explicitly add that too, so that C language checks - # see a consistent set of definitions. - if env.TargetOSIs('linux'): - env.AppendUnique( - CPPDEFINES=[ - ('_XOPEN_SOURCE', 700), - '_GNU_SOURCE', - ], - ) - # Everything on OS X is position independent by default. Solaris doesn't support PIE. if not env.TargetOSIs('darwin', 'solaris'): if get_option('runtime-hardening') == "on": @@ -2105,11 +2082,6 @@ def doConfigure(myenv): # As of clang-3.4, this warning appears in v8, and gets escalated to an error. AddToCCFLAGSIfSupported(myenv, "-Wno-tautological-constant-out-of-range-compare") - # As of clang in Android NDK 17, these warnings appears in boost and/or ICU, and get escalated to errors - AddToCCFLAGSIfSupported(myenv, "-Wno-tautological-constant-compare") - AddToCCFLAGSIfSupported(myenv, "-Wno-tautological-unsigned-zero-compare") - AddToCCFLAGSIfSupported(myenv, "-Wno-tautological-unsigned-enum-zero-compare") - # New in clang-3.4, trips up things mostly in third_party, but in a few places in the # primary mongo sources as well. AddToCCFLAGSIfSupported(myenv, "-Wno-unused-const-variable") |